Settings\Form\AbstractSettingsForm

Complexity

Total Complexity

12

Size/Duplication

Total Lines	110
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	4

Importance

Changes	2
Bugs	2	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	getHydrator()	0	8	2
A	setObject()	0	11	2
A	setName()	0	10	1
A	bind()	0	6	1
A	getModuleName()	0	8	1
A	__construct()	0	5	1
B	build()	0	25	3
A	factory()	0	4	1

<?php
/**
 * YAWIK
 *
 * @filesource
 * @copyright (c) 2013 - 2016 Cross Solution (http://cross-solution.de)
 * @license   MIT
 */

/** AbstractSettingsForm.php */
namespace Settings\Form;

use Core\Form\Form;
use Settings\Entity\ModuleSettingsContainerInterface;
use Zend\ServiceManager\ServiceLocatorInterface;
use Zend\Form\FormInterface;
use Settings\Entity\Hydrator\SettingsEntityHydrator;

class AbstractSettingsForm extends Form
{
    /**
     * @var bool
     */
    protected $isBuild = false;
    
    /**
     * @var ServiceLocatorInterface
     */
    protected $formManager;
    
    /**
     * @param ServiceLocatorInterface $formManager
     */
    public function __construct(ServiceLocatorInterface $formManager)
    {
        parent::__construct();
        $this->formManager = $formManager;
    }
    
    /**
     * @see \Core\Form\Form::getHydrator()
     */
    public function getHydrator()
    {
        if (!$this->hydrator) {
            $hydrator = new SettingsEntityHydrator();
            $this->setHydrator($hydrator);
        }
        return $this->hydrator;
    }
    
    public function build()
    {
        if ($this->isBuild) {
            return;
        }
        $this->setAttribute('method', 'post');
        $object = $this->getObject();
        $fieldsetName = $object->getModuleName() . '/SettingsFieldset';
        
        if ($this->formManager->has($fieldsetName)) {
            $fieldset = $this->formManager->get($fieldsetName);
        } else {
            $fieldset = $this->formManager->get('Settings/Fieldset');
            $fieldset->setLabel($object->getModuleName());
        }
        
        $fieldset->setUseAsBaseFieldset(true)
                 ->setName('base');
        
        $fieldset->setObject($object);
        $this->add($fieldset);

It seems like $fieldset can also be of type object; however, Core\Form\Form::add() does only seem to accept array|object<Traversable>|object<Zend\Form\ElementInterface>, maybe add an additional type check?

        
        $this->add($this->formManager->get('DefaultButtonsFieldset'));
        $this->isBuild=true;
    }
        

    public function setObject($object)
    {
        if (!$object instanceof ModuleSettingsContainerInterface) {
            throw new \InvalidArgumentException('Object must implement ModuleSettingsContainerInterface');
        }
        parent::setObject($object);
        $moduleName = $object->getModuleName();
        $this->setName($moduleName);
        $this->build();
        return $this;
    }
    
    public function setName($name)
    {
        parent::setName(strtolower($name) . '-settings');
        $urlHelper = $this->formManager->getServiceLocator()

It seems like you code against a concrete implementation and not the interface Zend\ServiceManager\ServiceLocatorInterface as the method getServiceLocator() does only exist in the following implementations of said interface: Acl\Assertion\AssertionManager, Core\Mail\MailService, Core\Paginator\PaginatorService, Zend\Barcode\ObjectPluginManager, Zend\Barcode\RendererPluginManager, Zend\Cache\PatternPluginManager, Zend\Cache\Storage\AdapterPluginManager, Zend\Cache\Storage\PluginManager, Zend\Config\ReaderPluginManager, Zend\Config\WriterPluginManager, Zend\Feed\Reader\ExtensionPluginManager, Zend\Feed\Writer\ExtensionPluginManager, Zend\File\Transfer\Adapter\FilterPluginManager, Zend\File\Transfer\Adapter\ValidatorPluginManager, Zend\Filter\FilterPluginManager, Zend\Form\FormElementManager\FormElementManagerV2Polyfill, Zend\Form\FormElementManager\FormElementManagerV3Polyfill, Zend\Hydrator\HydratorPluginManager, Zend\I18n\Translator\LoaderPluginManager, Zend\InputFilter\InputFilterPluginManager, Zend\Log\FilterPluginManager, Zend\Log\FormatterPluginManager, Zend\Log\ProcessorPluginManager, Zend\Log\WriterPluginManager, Zend\Log\Writer\FilterPluginManager, Zend\Log\Writer\FormatterPluginManager, Zend\Mail\Protocol\SmtpPluginManager, Zend\Mvc\Controller\ControllerManager, Zend\Mvc\Controller\PluginManager, Zend\Mvc\Router\RoutePluginManager, Zend\Paginator\AdapterPluginManager, Zend\Paginator\ScrollingStylePluginManager, Zend\Serializer\AdapterPluginManager, Zend\ServiceManager\AbstractPluginManager, Zend\Tag\Cloud\DecoratorPluginManager, Zend\Text\Table\DecoratorManager, Zend\Validator\ValidatorPluginManager, Zend\View\HelperPluginManager, Zend\View\Helper\Navigation\PluginManager.

                     ->get('ViewHelperManager')
                     ->get('url');
        
        $url = $urlHelper('lang/settings', array('module' => $name), true);
        $this->setAttribute('action', $url);
    }

    
    public function bind($object, $flags = FormInterface::VALUES_NORMALIZED)
    {
        /** Ensure the form is build prior to binding */
        $this->setObject($object);
        return parent::bind($object);
    }
    
    
    protected function getModuleName()
    {
        $refl       = new \ReflectionClass($this);
        $namespace  = ltrim($refl->getNamespaceName(), '\\');
        $moduleName = substr($namespace, 0, strpos($namespace, '\\'));

        return strtolower($moduleName);
    }
    
    /**
     * @param ServiceLocatorInterface $formManager
     * @return AbstractSettingsForm
     */
    public static function factory(ServiceLocatorInterface $formManager)
    {
        return new static($formManager);
    }
}