Completed
Push — develop ( f102ca...488b09 )
by Mathias
20:12 queued 11:00
created
module/Jobs/src/Queue/FindJobsWithExternalImageJob.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -75,8 +75,8 @@  discard block
 block discarded – undo
75 75
         foreach ($cursor->toArray() as $job) {
76 76
             if (0 === strpos($job->getLogoRef(), 'http')) {
77 77
                 $queue->push(FetchExternalImageJob::create($job));
78
-                $logger->debug('Found external image uri: ' . $job->getLogoRef());
79
-                $logger->info('Pushed fetch image job for Job: '  . $job->getId());
78
+                $logger->debug('Found external image uri: '.$job->getLogoRef());
79
+                $logger->info('Pushed fetch image job for Job: '.$job->getId());
80 80
             } else {
81 81
                 $invalidJobs += 1;
82 82
             }
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 
85 85
         $delay = 0 >= ($cursor->count() - $invalidJobs) ? '+2 hours' : '+5 minutes';
86 86
         $queue->push(self::create(), ['delay' => $delay]);
87
-        $logger->info('Reinserted to fetch more jobs with delay: ' . $delay);
87
+        $logger->info('Reinserted to fetch more jobs with delay: '.$delay);
88 88
     }
89 89
 
90 90
 }
Please login to merge, or discard this patch.
module/Jobs/src/Queue/FetchExternalImageJob.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -63,34 +63,34 @@  discard block
 block discarded – undo
63 63
         $jobEntity = $this->repository->find($payload['jobId']);
64 64
 
65 65
         if (!$jobEntity) {
66
-            $logger->err('No job entity with the id ' . $payload['jobId'] . ' was found.');
66
+            $logger->err('No job entity with the id '.$payload['jobId'].' was found.');
67 67
 
68
-            throw new FatalJobException('No job entity with the id ' . $payload['jobId'] . ' was found.');
68
+            throw new FatalJobException('No job entity with the id '.$payload['jobId'].' was found.');
69 69
         }
70 70
 
71 71
         $uri = $jobEntity->getLogoRef();
72 72
 
73 73
         if (0 !== strpos($uri, 'http')) {
74
-            $logger->notice('logoRef seems not to be external: ' . $uri);
74
+            $logger->notice('logoRef seems not to be external: '.$uri);
75 75
             $logger->info('Skip fetching for this job.');
76 76
             return;
77 77
         }
78 78
 
79
-        $logger->debug('Trying to fetch image from ' . $uri);
79
+        $logger->debug('Trying to fetch image from '.$uri);
80 80
 
81 81
         $client = new Client($uri);
82 82
         $response = $client->send();
83 83
 
84 84
         if (200 != $response->getStatusCode()) {
85
-            $logger->err('Received status code ' . $response->getStatusCode() . ' when trying to fetch ' . $uri);
85
+            $logger->err('Received status code '.$response->getStatusCode().' when trying to fetch '.$uri);
86 86
 
87
-            throw new RecoverableJobException('Status code ' . $response->getStatusCode() . ' received.', ['delay' => '+5 minutes']);
87
+            throw new RecoverableJobException('Status code '.$response->getStatusCode().' received.', ['delay' => '+5 minutes']);
88 88
         }
89 89
 
90 90
         $content = $response->getBody();
91 91
         $type = $response->getHeaders()->get('Content-Type')->getFieldValue();
92 92
         list(,$ext) = explode('/', $type, 2);
93
-        $imageName = '/static/Jobs/logos/' . $jobEntity->getId() . '.' . $ext;
93
+        $imageName = '/static/Jobs/logos/'.$jobEntity->getId().'.'.$ext;
94 94
 
95 95
         if (false === file_put_contents("public$imageName", $content, FILE_BINARY)) {
96 96
             $logger->err('Writing image failed.');
@@ -98,10 +98,10 @@  discard block
 block discarded – undo
98 98
             throw new FatalJobException('Writing image failed.');
99 99
         }
100 100
 
101
-        $logger->info('Saved job logo as ' . basename($imageName));
101
+        $logger->info('Saved job logo as '.basename($imageName));
102 102
         $jobEntity->setLogoRef($imageName);
103 103
         $this->repository->store($jobEntity);
104
-        $logger->info('Saved job logo as ' . basename($imageName));
104
+        $logger->info('Saved job logo as '.basename($imageName));
105 105
 
106 106
     }
107 107
 }
Please login to merge, or discard this patch.