ResultConverter::validateDate() - Code Metrics - Inspection of "Refactored hydration of job entities" - cross-solution/YAWIK - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — develop (#284)

unknown

created 2016-09-22 07:24 UTC

ResultConverter::validateDate() B

↳ Parent: Project

Complexity

Conditions	5
Paths	5

Size

Total Lines	14
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
dl	0
loc	14
rs	8.8571
c	1
b	0
f	1
cc	5
eloc	10
nc	5
nop	1

<?php
/**
 * YAWIK
 *
 * @filesource
 * @copyright (c) 2013 - 2016 Cross Solution (http://cross-solution.de)
 * @license   MIT
 */

namespace Solr\Bridge;

use Core\Repository\RepositoryService;
use Solr\Filter\AbstractPaginationQuery;
use Zend\ServiceManager\ServiceLocatorInterface;
use ArrayAccess;
use InvalidArgumentException;

/**
 * Class ResultConverter
 *
 * Convert SOLR query result into Doctrine ODM Entity
 *
 * @author Anthonius Munthi <[email protected]>
 * @author Miroslav Fedeleš <[email protected]>
 * @package Solr\Bridge
 * @since 0.26
 */
class ResultConverter
{

    /**
     * @var RepositoryService
     */
    protected $repositories;

    /**
     * @param RepositoryService $repositories
     */
    public function __construct(RepositoryService $repositories)
    {
        $this->repositories = $repositories;
    }

    /**
     * Convert result into entities
     *
     * @param AbstractPaginationQuery $filter
     * @param ArrayAccess $response
     * @return array Array of entities
     * @throws InvalidArgumentException
     */
    public function convert(AbstractPaginationQuery $filter, ArrayAccess $response)
    {
        $entities = [];
        $ids = [];
        $return = [];

        if (!isset($response['response'])
            || !isset($response['response']['docs'])
            || !is_array($response['response']['docs']))
        {
            throw new InvalidArgumentException('invalid response');
        }
        
        foreach ($response['response']['docs'] as $doc) {
            $ids[] = $doc->id;
        }

        // fetch entities with given IDs
        $repository = $this->repositories->get($filter->getRepositoryName());
        $qb = $repository->createQueryBuilder() /* @var $repository \Core\Repository\AbstractRepository */
            ->field('id')
            ->in($ids);
        $result = $qb->getQuery()->execute();
        
        foreach ($result as $document) {
            $entities[$document->getId()] = $document;
        }
        
        // iterate over Solr response to preserve sorting
        foreach ($response['response']['docs'] as $doc) {
            $entity = isset($entities[$doc->id]) ? $entities[$doc->id] : $repository->create();

            $return[] = $filter->proxyFactory($entity, $doc);
        }
        
        return $return;
    }

    /**
     * Create a new instance of ResultConverter
     * @param   ServiceLocatorInterface $sl
     * @return  ResultConverter
     */
    static public function factory(ServiceLocatorInterface $sl)

    {
        return new static($sl->get('repositories'));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}

1			<?php
2			/**
3			* YAWIK
4			*
5			* @filesource
6			* @copyright (c) 2013 - 2016 Cross Solution (http://cross-solution.de)
7			* @license MIT
8			*/
9
10			namespace Solr\Bridge;
11
12			use Core\Repository\RepositoryService;
13			use Solr\Filter\AbstractPaginationQuery;
14			use Zend\ServiceManager\ServiceLocatorInterface;
15			use ArrayAccess;
16			use InvalidArgumentException;
17
18			/**
19			* Class ResultConverter
20			*
21			* Convert SOLR query result into Doctrine ODM Entity
22			*
23			* @author Anthonius Munthi <[email protected]>
24			* @author Miroslav Fedeleš <[email protected]>
25			* @package Solr\Bridge
26			* @since 0.26
27			*/
28			class ResultConverter
29			{
30
31			/**
32			* @var RepositoryService
33			*/
34			protected $repositories;
35
36			/**
37			* @param RepositoryService $repositories
38			*/
39			public function __construct(RepositoryService $repositories)
40			{
41			$this->repositories = $repositories;
42			}
43
44			/**
45			* Convert result into entities
46			*
47			* @param AbstractPaginationQuery $filter
48			* @param ArrayAccess $response
49			* @return array Array of entities
50			* @throws InvalidArgumentException
51			*/
52			public function convert(AbstractPaginationQuery $filter, ArrayAccess $response)
53			{
54			$entities = [];
55			$ids = [];
56			$return = [];
57
58			if (!isset($response['response'])
59			\|\| !isset($response['response']['docs'])
60			\|\| !is_array($response['response']['docs']))
61			{
62			throw new InvalidArgumentException('invalid response');
63			}
64
65			foreach ($response['response']['docs'] as $doc) {
66			$ids[] = $doc->id;
67			}
68
69			// fetch entities with given IDs
70			$repository = $this->repositories->get($filter->getRepositoryName());
71			$qb = $repository->createQueryBuilder() /* @var $repository \Core\Repository\AbstractRepository */
72			->field('id')
73			->in($ids);
74			$result = $qb->getQuery()->execute();
75
76			foreach ($result as $document) {
77			$entities[$document->getId()] = $document;
78			}
79
80			// iterate over Solr response to preserve sorting
81			foreach ($response['response']['docs'] as $doc) {
82			$entity = isset($entities[$doc->id]) ? $entities[$doc->id] : $repository->create();
			0 ignored issues – show Bug introduced 2016-09-21 13:16 UTC by Report Bug Copy Issue Report The method `create()` does not exist on `Doctrine\ODM\MongoDB\DocumentRepository`. Did you maybe mean `createQueryBuilder()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
83			$return[] = $filter->proxyFactory($entity, $doc);
84			}
85
86			return $return;
87			}
88
89			/**
90			* Create a new instance of ResultConverter
91			* @param ServiceLocatorInterface $sl
92			* @return ResultConverter
93			*/
94			static public function factory(ServiceLocatorInterface $sl)
			0 ignored issues – show Coding Style introduced 2016-07-01 06:20 UTC by Report Bug Copy Issue Report As per PSR2, the `static` declaration should come after the visibility declaration. Loading history...
95			{
96			return new static($sl->get('repositories'));
			0 ignored issues – show Documentation introduced 2016-09-16 09:35 UTC by Report Bug Copy Issue Report `$sl->get('repositories')` is of type `object\|array`, but the function expects a `object<Core\Repository\RepositoryService>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
97			}
98			}

cross-solution / YAWIK

Pull Request — develop (#284)

ResultConverter::validateDate() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like