Completed
Push — develop ( beb977...f996e0 )
by
unknown
06:44
created
module/Core/src/Core/Factory/EventManager/EventManagerAbstractFactory.php 4 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -278,7 +278,7 @@
 block discarded – undo
278 278
             /* @var \Core\Listener\DeferredListenerAggregate $aggregate */
279 279
             $aggregate = $services->get('Core/Listener/DeferredListenerAggregate');
280 280
             $aggregate->setListeners($lazyListeners)
281
-                      ->attach($eventManager);
281
+                        ->attach($eventManager);
282 282
         }
283 283
     }
284 284
 
Please login to merge, or discard this patch.
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -209,8 +209,7 @@
 block discarded – undo
209 209
             /* @var \Zend\EventManager\EventInterface $event */
210 210
             $event = $services->has($config['event']) ? $services->get($config['event']) : new $config['event']();
211 211
             $events->setEventPrototype($event);
212
-        }
213
-        else {
212
+        } else {
214 213
             $events->setEventClass($config['event']);
215 214
         }
216 215
 
Please login to merge, or discard this patch.
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
      * @param  string             $requestedName
114 114
      * @param  null|array         $options
115 115
      *
116
-     * @return object
116
+     * @return \Zend\EventManager\EventManagerInterface
117 117
      * @throws ServiceNotFoundException if unable to resolve the service.
118 118
      * @throws ServiceNotCreatedException if an exception is raised when
119 119
      *     creating a service.
@@ -333,7 +333,7 @@  discard block
 block discarded – undo
333 333
      * @param string|array $options String is either event name or aggregate name (when name is int).
334 334
      *                              Array are the options from config. [ [event,..], method, priority, lazy]
335 335
      *
336
-     * @return array
336
+     * @return \Zend\EventManager\EventManagerInterface
337 337
      */
338 338
     protected function normalizeListenerOptions($name, $options)
339 339
     {
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
      */
165 165
     public function createServiceWithName(ServiceLocatorInterface $serviceLocator, $name, $requestedName)
166 166
     {
167
-        return $this($serviceLocator,$requestedName);
167
+        return $this($serviceLocator, $requestedName);
168 168
     }
169 169
 
170 170
     /**
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
         $defaults = [
184 184
             'service' => 'EventManager',
185 185
             'configure' => true,
186
-            'identifiers' => [ $name ],
186
+            'identifiers' => [$name],
187 187
             'event' => '\Zend\EventManager\Event',
188 188
             'listeners' => [],
189 189
         ];
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
         foreach ($listeners as $name => $options) {
275 275
             $options = $this->normalizeListenerOptions($name, $options);
276 276
 
277
-            if ($options['lazy'] && null !== $options['attach'] ) {
277
+            if ($options['lazy'] && null !== $options['attach']) {
278 278
                 foreach ($options['attach'] as $spec) {
279 279
                     $lazyListeners[] = [
280 280
                         'service' => $options['service'],
@@ -304,7 +304,7 @@  discard block
 block discarded – undo
304 304
             }
305 305
 
306 306
             foreach ($options['attach'] as $spec) {
307
-                $callback = $spec['method'] ? [ $listener, $spec['method'] ] : $listener;
307
+                $callback = $spec['method'] ? [$listener, $spec['method']] : $listener;
308 308
                 $eventManager->attach($spec['event'], $callback, $spec['priority']);
309 309
             }
310 310
         }
@@ -375,7 +375,7 @@  discard block
 block discarded – undo
375 375
 
376 376
         if (is_string($options)) {
377 377
             /* Only an event name is provided in config */
378
-            $normalized['attach'] = [ [ 'event' => $options, 'method' => null, 'priority' => 1 ] ];
378
+            $normalized['attach'] = [['event' => $options, 'method' => null, 'priority' => 1]];
379 379
             return $normalized;
380 380
 
381 381
         }
@@ -404,7 +404,7 @@  discard block
 block discarded – undo
404 404
             } else if (is_string($opt)) {
405 405
                 if (null === $event) {
406 406
                     /* first string found is assumed to be the event name */
407
-                    $event = [ $opt ];
407
+                    $event = [$opt];
408 408
                 } else {
409 409
                     /* second string found must be a method name. */
410 410
                     $method = $opt;
@@ -421,7 +421,7 @@  discard block
 block discarded – undo
421 421
         }
422 422
 
423 423
         foreach ($event as &$eventSpec) {
424
-            $eventSpec = [ 'event' => $eventSpec, 'method' => $method, 'priority' => $priority ];
424
+            $eventSpec = ['event' => $eventSpec, 'method' => $method, 'priority' => $priority];
425 425
         }
426 426
 
427 427
         $normalized['attach'] = $event;
@@ -433,7 +433,7 @@  discard block
 block discarded – undo
433 433
     protected function normalizeEventsSpec($options)
434 434
     {
435 435
         $listenerPriority = isset($options['priority']) ? $options['priority'] : 1;
436
-        $listenerMethod   = isset($options['method'])   ? $options['method']   : '__none__';
436
+        $listenerMethod   = isset($options['method']) ? $options['method'] : '__none__';
437 437
         $events = [];
438 438
 
439 439
         foreach ($options['events'] as $event => $spec) {
@@ -453,7 +453,7 @@  discard block
 block discarded – undo
453 453
             } else if (is_array($spec)) {
454 454
                 if (isset($spec['method'])) {
455 455
                     if (!is_array($spec['method'])) {
456
-                        $spec['method'] = [ $spec['method'] ];
456
+                        $spec['method'] = [$spec['method']];
457 457
                     }
458 458
 
459 459
                     foreach ($spec['method'] as $method => $methodPriority) {
Please login to merge, or discard this patch.
module/Applications/src/Applications/Listener/StatusChange.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -157,7 +157,7 @@
 block discarded – undo
157 157
 
158 158
     /**
159 159
      * @param Application $application
160
-     * @param             $status
160
+     * @param             string $status
161 161
      *
162 162
      * @return AddressList
163 163
      */
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
      *
69 69
      * @param ApplicationEvent $e
70 70
      */
71
-    public function prepareFormData(ApplicationEvent $e){
71
+    public function prepareFormData(ApplicationEvent $e) {
72 72
         if ($e->isPostRequest()) {
73 73
             return;
74 74
         }
@@ -95,13 +95,13 @@  discard block
 block discarded – undo
95 95
                 $key = 'mailRejectionText';
96 96
                 break;
97 97
             default:
98
-                throw new \InvalidArgumentException('Unknown status value: ' .$status);
98
+                throw new \InvalidArgumentException('Unknown status value: '.$status);
99 99
         }
100
-        $mailText      = $settings->$key ? $settings->$key : '';
100
+        $mailText = $settings->$key ? $settings->$key : '';
101 101
         $mail->setBody($mailText);
102 102
         $mail->setApplication($this->application);
103 103
         $mailText = $mail->getBodyText();
104
-        $mailSubject   = sprintf(
104
+        $mailSubject = sprintf(
105 105
             $this->translator->translate('Your application dated %s'),
106 106
             strftime('%x', $this->application->getDateCreated()->getTimestamp())
107 107
         );
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
      *
122 122
      * @param ApplicationEvent $event
123 123
      */
124
-    public function  sendMail(ApplicationEvent $event){
124
+    public function  sendMail(ApplicationEvent $event) {
125 125
         if (!$event->isPostRequest()) {
126 126
             return;
127 127
         }
@@ -167,7 +167,7 @@  discard block
 block discarded – undo
167 167
         $this->mailService->send($mail);
168 168
 
169 169
 
170
-        $historyText = sprintf($this->translator->translate('Mail was sent to %s'), key($recipient) ?: $recipient[0] );
170
+        $historyText = sprintf($this->translator->translate('Mail was sent to %s'), key($recipient) ?: $recipient[0]);
171 171
         $this->application->changeStatus($status, $historyText);
172 172
         $event->setNotification($historyText);
173 173
     }
@@ -178,7 +178,7 @@  discard block
 block discarded – undo
178 178
      *
179 179
      * @return AddressList
180 180
      */
181
-    protected function getRecipient( Application $application, $status) {
181
+    protected function getRecipient(Application $application, $status) {
182 182
 
183 183
         $recipient = Status::ACCEPTED == $status
184 184
             ? $application->getJob()->getUser()->getInfo()
@@ -187,7 +187,7 @@  discard block
 block discarded – undo
187 187
         $email = $recipient->getEmail();
188 188
         $name  = $recipient->getDisplayName(false);
189 189
 
190
-        return $name ? [ $email => $name ] : [ $email ];
190
+        return $name ? [$email => $name] : [$email];
191 191
     }
192 192
 
193 193
 }
194 194
\ No newline at end of file
Please login to merge, or discard this patch.
module/Organizations/src/Organizations/Entity/WorkflowSettingsInterface.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@  discard block
 block discarded – undo
17 17
      * @param bool $acceptApplicationByDepartmentManager
18 18
      * @return WorkflowSettings
19 19
      */
20
-    public function setAcceptApplicationByDepartmentManager( $acceptApplicationByDepartmentManager );
20
+    public function setAcceptApplicationByDepartmentManager($acceptApplicationByDepartmentManager);
21 21
 
22 22
     /**
23 23
      * Gets AcceptApplicationByDepartmentManager
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
      * @param bool $assignDepartmentManagersToJobs
33 33
      * @return WorkflowSettings
34 34
      */
35
-    public function setAssignDepartmentManagersToJobs( $assignDepartmentManagersToJobs );
35
+    public function setAssignDepartmentManagersToJobs($assignDepartmentManagersToJobs);
36 36
 
37 37
     /**
38 38
      * Gets AssignDepartmentManagersToJobs
Please login to merge, or discard this patch.
module/Organizations/src/Organizations/Entity/WorkflowSettings.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -40,9 +40,9 @@  discard block
 block discarded – undo
40 40
      * @param bool $acceptApplicationByDepartmentManager
41 41
      * @return WorkflowSettings
42 42
      */
43
-    public function setAcceptApplicationByDepartmentManager( $acceptApplicationByDepartmentManager )
43
+    public function setAcceptApplicationByDepartmentManager($acceptApplicationByDepartmentManager)
44 44
     {
45
-        $this->acceptApplicationByDepartmentManager= $acceptApplicationByDepartmentManager;
45
+        $this->acceptApplicationByDepartmentManager = $acceptApplicationByDepartmentManager;
46 46
         return $this;
47 47
     }
48 48
     
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
      * @param bool $assignDepartmentManagersToJobs
63 63
      * @return WorkflowSettings
64 64
      */
65
-    public function setAssignDepartmentManagersToJobs( $assignDepartmentManagersToJobs )
65
+    public function setAssignDepartmentManagersToJobs($assignDepartmentManagersToJobs)
66 66
     {
67 67
         $this->assignDepartmentManagersToJobs = $assignDepartmentManagersToJobs;
68 68
         return $this;
Please login to merge, or discard this patch.
module/Applications/src/Applications/Entity/Settings.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@
 block discarded – undo
142 142
     /**
143 143
      * @return bool
144 144
      */
145
-    public function getAutoConfirmMail(){
145
+    public function getAutoConfirmMail() {
146 146
         return $this->autoConfirmMail;
147 147
     }
148 148
 }
Please login to merge, or discard this patch.
module/Applications/src/Applications/Listener/Events/ApplicationEvent.php 2 patches
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -30,17 +30,17 @@  discard block
 block discarded – undo
30 30
     /**
31 31
      * Event is fired when a new application is saved.
32 32
      */
33
-    const EVENT_APPLICATION_POST_CREATE   = 'application.post.create';
33
+    const EVENT_APPLICATION_POST_CREATE = 'application.post.create';
34 34
 
35 35
     /**
36 36
      * Event is fired when a users deleted application
37 37
      */
38
-    const EVENT_APPLICATION_PRE_DELETE   = 'application.pre.delete';
38
+    const EVENT_APPLICATION_PRE_DELETE = 'application.pre.delete';
39 39
 
40 40
     /**
41 41
      * Event is fired when the status of an application is changed
42 42
      */
43
-    const EVENT_APPLICATION_STATUS_CHANGE   = 'application.status.change';
43
+    const EVENT_APPLICATION_STATUS_CHANGE = 'application.status.change';
44 44
 
45 45
     /**
46 46
      * @var Application $application
@@ -233,12 +233,12 @@  discard block
 block discarded – undo
233 233
             $this->setApplicationEntity($params->application);
234 234
         }
235 235
 
236
-        if(is_array($params) && isset($params['user'])) {
236
+        if (is_array($params) && isset($params['user'])) {
237 237
             $this->setUser($params['user']);
238 238
             unset($params['user']);
239 239
         }
240 240
 
241
-        if(is_array($params) && isset($params['status'])) {
241
+        if (is_array($params) && isset($params['status'])) {
242 242
             $this->setStatus($params['status']);
243 243
             unset($params['status']);
244 244
         }
Please login to merge, or discard this patch.
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
     }
139 139
 
140 140
     /**
141
-     * @param $notification
141
+     * @param string $notification
142 142
      *
143 143
      * @return $this
144 144
      */
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
     }
169 169
 
170 170
     /**
171
-     * @return mixed
171
+     * @return string
172 172
      */
173 173
     public function getStatus()
174 174
     {
@@ -176,7 +176,7 @@  discard block
 block discarded – undo
176 176
     }
177 177
 
178 178
     /**
179
-     * @return mixed
179
+     * @return boolean
180 180
      */
181 181
     public function isPostRequest()
182 182
     {
Please login to merge, or discard this patch.
module/Applications/src/Applications/Controller/IndexController.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
             $params->set('by', 'me');
41 41
         }
42 42
 
43
-         //default sorting
43
+            //default sorting
44 44
         if (!isset($params['sort'])) {
45 45
             $params['sort']="-date";
46 46
         }
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -42,10 +42,10 @@
 block discarded – undo
42 42
 
43 43
          //default sorting
44 44
         if (!isset($params['sort'])) {
45
-            $params['sort']="-date";
45
+            $params['sort'] = "-date";
46 46
         }
47 47
         $params->count = 5;
48
-        $params->pageRange=5;
48
+        $params->pageRange = 5;
49 49
 
50 50
         $this->paginationParams()->setParams('Applications\Index', $params);
51 51
 
Please login to merge, or discard this patch.
module/Core/src/Core/Form/LocalizationSettingsFieldset.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
             )
47 47
         );
48 48
 
49
-        $timezones=array_merge(
49
+        $timezones = array_merge(
50 50
             \DateTimeZone::listIdentifiers(\DateTimeZone::AFRICA),
51 51
             \DateTimeZone::listIdentifiers(\DateTimeZone::AMERICA),
52 52
             \DateTimeZone::listIdentifiers(\DateTimeZone::ASIA),
Please login to merge, or discard this patch.
module/Applications/src/Applications/Controller/ApplyController.php 2 patches
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
239 239
             ->getHybridAuth();
240 240
         /* @var $authProfile \Hybrid_User_Profile */
241 241
         $authProfile = $hybridAuth->authenticate($network)
242
-           ->getUserProfile();
242
+            ->getUserProfile();
243 243
 
244 244
         /* @var \Auth\Entity\SocialProfiles\AbstractProfile $profile */
245 245
         $profile = $this->plugin('Auth/SocialProfiles')->fetch($network);
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
292 292
         }
293 293
         
294 294
         return $this->redirect()
295
-           ->toRoute('lang/apply', ['applyId' => $job->getApplyId()], $urlOptions);
295
+            ->toRoute('lang/apply', ['applyId' => $job->getApplyId()], $urlOptions);
296 296
     }
297 297
 
298 298
     public function processPreviewAction()
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
                 throw new \RuntimeException('Invalid application id.');
92 92
             }
93 93
 
94
-            $action     = 'process';
94
+            $action = 'process';
95 95
 
96 96
             $routeMatch->setParam('action', $action);
97 97
         } else {
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
     {
183 183
         $this->response->setStatusCode(410);
184 184
         $model = new ViewModel(
185
-            [ 'content' => /*@translate*/ 'Invalid apply id']
185
+            ['content' => /*@translate*/ 'Invalid apply id']
186 186
         );
187 187
         $model->setTemplate('applications/error/not-found');
188 188
         return $model;
@@ -360,13 +360,13 @@  discard block
 block discarded – undo
360 360
         }
361 361
 
362 362
         if ('previewmail' == $this->params()->fromQuery('do')) {
363
-            $this->mailer('Applications/CarbonCopy', [ 'application' => $application], true);
363
+            $this->mailer('Applications/CarbonCopy', ['application' => $application], true);
364 364
             $this->notification()->success(/*@translate*/ 'Mail has been send');
365 365
             return new JsonModel();
366 366
         }
367 367
 
368 368
         if ('sendmail' == $this->params()->fromQuery('do')) {
369
-            $jobEntity         = $application->getJob();
369
+            $jobEntity = $application->getJob();
370 370
 
371 371
             $mailData = array(
372 372
                 'application' => $application,
@@ -396,8 +396,8 @@  discard block
 block discarded – undo
396 396
 
397 397
         $repositories->store($application);
398 398
         
399
-        $events   = $services->get('Applications/Events');
400
-        $events->trigger(ApplicationEvent::EVENT_APPLICATION_POST_CREATE, $this, [ 'application' => $application ]);
399
+        $events = $services->get('Applications/Events');
400
+        $events->trigger(ApplicationEvent::EVENT_APPLICATION_POST_CREATE, $this, ['application' => $application]);
401 401
 
402 402
         $model = new ViewModel(
403 403
             array(
Please login to merge, or discard this patch.