Auth\Factory\Form\SocialProfilesFieldsetFactory

Complexity

Total Complexity

6

Size/Duplication

Total Lines	65
Duplicated Lines	9.23 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	__invoke()	6	33	5
A	createService()	0	4	1

<?php
/**
 * YAWIK
 *
 * @filesource
 * @copyright (c) 2013 - 2016 Cross Solution (http://cross-solution.de)
 * @license   MIT
 */

/** Auth forms */
namespace Auth\Factory\Form;

use Interop\Container\ContainerInterface;
use Zend\ServiceManager\FactoryInterface;
use Zend\ServiceManager\ServiceLocatorInterface;
use Auth\Form\SocialProfilesFieldset;

/**
 * Factory for a SocialProfilesFieldset
 *
 * @author Mathias Gelhausen <gelhausen@cross-solution.de>
 */
class SocialProfilesFieldsetFactory implements FactoryInterface
{
    /**
     * Creates a {@link SocialProfilesFieldset}
     *
     * Uses config from the config key [form_element_config][attach_social_profiles_fieldset]
     * to configure fetch_url, preview_url and name or uses the defaults:
     *  - fetch_url: Route named "auth-social-profiles" with the suffix "?network=%s"
     *  - preview_url: Route named "lang/applications/detail" with the suffix "?action=social-profile&network=%s"
     *  - name: "social_profiles"
     *
     * @param  ContainerInterface $container
     * @param  string             $requestedName
     * @param  null|array         $options
     *
     * @return object
     * @throws ServiceNotFoundException if unable to resolve the service.
     * @throws ServiceNotCreatedException if an exception is raised when
     *     creating a service.
     * @throws ContainerException if any other error occurs
     */
    public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
    {
        /* @var $router         \Zend\Mvc\Router\RouteStackInterface */

        $router = $container->get('Router');
        $config = $container->get('Config');
        $options = isset($config['form_element_config']['attach_social_profiles_fieldset'])
            ? $config['form_element_config']['attach_social_profiles_fieldset']
            : array();

        if (!isset($options['fetch_url'])) {
            $options['fetch_url'] =
                $router->assemble(array('action' => 'fetch'), array('name' => 'auth-social-profiles'))
                . '?network=%s';
        }
        if (!isset($options['preview_url'])) {
            $options['preview_url'] =
                $router->assemble(array('id' => 'null'), array('name' => 'lang/applications/detail'), true)

The call to RouteStackInterface::assemble() has too many arguments starting with true.

                . '?action=social-profile&network=%s';
        }
        if (isset($options['name'])) {

This code seems to be duplicated across your project.

            $name = $options['name'];
            unset($options['name']);
        } else {
            $name = 'social_profiles';
        }
        $options['is_disable_capable'] = false;
        $options['is_disable_elements_capable'] = false;

        $fieldset = new SocialProfilesFieldset($name, $options);

        return $fieldset;
    }
    
    /**
     * @param ServiceLocatorInterface $serviceLocator
     * @return SocialProfilesFieldset
     * @see \Zend\ServiceManager\FactoryInterface::createService()
     */
    public function createService(ServiceLocatorInterface $serviceLocator)
    {
        return $this($serviceLocator->getServiceLocator(), SocialProfilesFieldset::class);

It seems like you code against a concrete implementation and not the interface Zend\ServiceManager\ServiceLocatorInterface as the method getServiceLocator() does only exist in the following implementations of said interface: Acl\Assertion\AssertionManager, Core\Mail\MailService, Core\Paginator\PaginatorService, Zend\Barcode\ObjectPluginManager, Zend\Barcode\RendererPluginManager, Zend\Cache\PatternPluginManager, Zend\Cache\Storage\AdapterPluginManager, Zend\Cache\Storage\PluginManager, Zend\Config\ReaderPluginManager, Zend\Config\WriterPluginManager, Zend\Feed\Reader\ExtensionPluginManager, Zend\Feed\Writer\ExtensionPluginManager, Zend\File\Transfer\Adapter\FilterPluginManager, Zend\File\Transfer\Adapter\ValidatorPluginManager, Zend\Filter\FilterPluginManager, Zend\Form\FormElementManager\FormElementManagerV2Polyfill, Zend\Form\FormElementManager\FormElementManagerV3Polyfill, Zend\Hydrator\HydratorPluginManager, Zend\I18n\Translator\LoaderPluginManager, Zend\InputFilter\InputFilterPluginManager, Zend\Log\FilterPluginManager, Zend\Log\FormatterPluginManager, Zend\Log\ProcessorPluginManager, Zend\Log\WriterPluginManager, Zend\Log\Writer\FilterPluginManager, Zend\Log\Writer\FormatterPluginManager, Zend\Mail\Protocol\SmtpPluginManager, Zend\Mvc\Controller\ControllerManager, Zend\Mvc\Controller\PluginManager, Zend\Mvc\Router\RoutePluginManager, Zend\Paginator\AdapterPluginManager, Zend\Paginator\ScrollingStylePluginManager, Zend\Serializer\AdapterPluginManager, Zend\ServiceManager\AbstractPluginManager, Zend\Stdlib\Hydrator\HydratorPluginManager, Zend\Tag\Cloud\DecoratorPluginManager, Zend\Text\Table\DecoratorManager, Zend\Validator\ValidatorPluginManager, Zend\View\HelperPluginManager, Zend\View\Helper\Navigation\PluginManager.

    }
}