Completed
Pull Request — develop (#241)
by ANTHONIUS
07:56
created
module/Jobs/src/Jobs/Form/AdminJobEdit.php 1 patch
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -30,21 +30,21 @@
 block discarded – undo
30 30
         ));
31 31
 
32 32
         $this->add([
33
-                       'type' => 'Jobs/StatusSelect',
33
+                        'type' => 'Jobs/StatusSelect',
34 34
 
35
-                   ]);
35
+                    ]);
36 36
 
37 37
         $this->add([
38
-                       'type' => 'Core/Datepicker',
39
-                       'name' => 'datePublishStart',
40
-                       'options' => [
41
-                           'label' => /*@translate*/ 'Start date',
42
-                           'description' => /*@translate*/ 'Set the start date of this job.',
43
-                       ],
44
-                       'attributes' => [
45
-                           'data-date-autoclose' => 'true',
46
-                       ],
47
-                   ]);
38
+                        'type' => 'Core/Datepicker',
39
+                        'name' => 'datePublishStart',
40
+                        'options' => [
41
+                            'label' => /*@translate*/ 'Start date',
42
+                            'description' => /*@translate*/ 'Set the start date of this job.',
43
+                        ],
44
+                        'attributes' => [
45
+                            'data-date-autoclose' => 'true',
46
+                        ],
47
+                    ]);
48 48
         $this->setIsDescriptionsEnabled(true);
49 49
     }
50 50
 
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Listener/Publisher.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -171,14 +171,14 @@
 block discarded – undo
171 171
                 $jsonLastError = json_last_error();
172 172
                 if (json_last_error() != JSON_ERROR_NONE) {
173 173
                     // not able to decode json
174
-                    $log->info('RestCall Response not Json [errorCode: ' . $jsonLastError . ']: ' . var_export($body, true));
174
+                    $log->info('RestCall Response not Json [errorCode: '.$jsonLastError.']: '.var_export($body, true));
175 175
                 } else {
176 176
                     // does the provider want to have an own ID for Identification ?
177 177
                     $response_referenceUpdate = $decodedBody->referenceUpdate;
178 178
                     $response_externalIdUpdate = $decodedBody->applyIdUpdate;
179 179
 
180 180
                     if ($publisher->externalId != $response_externalIdUpdate || $publisher->reference != $response_referenceUpdate) {
181
-                        $log->info('RestCall changed externalID [' . var_export($publisher->externalId, true) . ' => ' . var_export($response_externalIdUpdate, true) . '], reference  [' . var_export($publisher->reference, true) . ' => ' . var_export($response_referenceUpdate, true) . ']');
181
+                        $log->info('RestCall changed externalID ['.var_export($publisher->externalId, true).' => '.var_export($response_externalIdUpdate, true).'], reference  ['.var_export($publisher->reference, true).' => '.var_export($response_referenceUpdate, true).']');
182 182
                         $publisher->reference = $response_referenceUpdate;
183 183
                         $publisher->externalId = $response_externalIdUpdate;
184 184
                         $serviceManager->get('repositories')->store($entity);
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Controller/AdminController.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@
 block discarded – undo
71 71
             return new JsonModel([
72 72
                 'valid' => $valid,
73 73
                 'errors' => $errors
74
-                                 ]);
74
+                                    ]);
75 75
         }
76 76
 
77 77
         $form->bind($job);
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -26,9 +26,9 @@  discard block
 block discarded – undo
26 26
     public function indexAction()
27 27
     {
28 28
         return $this->pagination([
29
-            'params'    => [ 'Jobs_Admin', ['text', 'page' => 1, 'companyId', 'status' ] ],
30
-            'form'      => [ 'as' => 'form', 'Jobs/AdminSearch' ],
31
-            'paginator' => [ 'as' => 'jobs', 'Jobs/Admin' ],
29
+            'params'    => ['Jobs_Admin', ['text', 'page' => 1, 'companyId', 'status']],
30
+            'form'      => ['as' => 'form', 'Jobs/AdminSearch'],
31
+            'paginator' => ['as' => 'jobs', 'Jobs/Admin'],
32 32
         ]);
33 33
     }
34 34
 
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
                     $oldStatus = $job->getStatus();
55 55
                     $job->changeStatus($post['status'], '[System] Status changed via Admin GUI.');
56 56
                     $events = $services->get('Jobs/Events');
57
-                    $events->trigger(JobEvent::EVENT_STATUS_CHANGED, $this, [ 'job' => $job, 'status' => $oldStatus ]);
57
+                    $events->trigger(JobEvent::EVENT_STATUS_CHANGED, $this, ['job' => $job, 'status' => $oldStatus]);
58 58
                 }
59 59
             }
60 60
 
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 
67 67
         $form->bind($job);
68 68
 
69
-        return [ 'form' => $form, 'job' => $job ];
69
+        return ['form' => $form, 'job' => $job];
70 70
     }
71 71
     
72 72
 }
73 73
\ No newline at end of file
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Controller/AssignUserController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
         $job = $this->repository->find($id);
63 63
 
64 64
         if (!$job) {
65
-            throw new \RuntimeException('No job found with id "' . $id . '"');
65
+            throw new \RuntimeException('No job found with id "'.$id.'"');
66 66
         }
67 67
 
68 68
         $this->acl($job, 'edit');
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Controller/ConsoleController.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -39,10 +39,10 @@  discard block
 block discarded – undo
39 39
                     
40 40
                 case "days":
41 41
                     $date = new \DateTime();
42
-                    $date->modify('-' . (int) $value. ' day');
42
+                    $date->modify('-'.(int) $value.' day');
43 43
                     $q = array('$lt' => $date);
44 44
                     if (isset($query['datePublishStart.date'])) {
45
-                        $query['datePublishStart.date']= array_merge(
45
+                        $query['datePublishStart.date'] = array_merge(
46 46
                             $query['datePublishStart.date'],
47 47
                             $q
48 48
                         );
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
         
73 73
         echo "$count jobs found, which have to expire ...\n";
74 74
         
75
-        $progress     = new ProgressBar(
75
+        $progress = new ProgressBar(
76 76
             new ConsoleAdapter(
77 77
                 array(
78 78
                 'elements' => array(
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 
96 96
         /* @var \Jobs\Entity\Job $job */
97 97
         foreach ($jobs as $job) {
98
-            $progress->update($i++, 'Job ' . $i . ' / ' . $count);
98
+            $progress->update($i++, 'Job '.$i.' / '.$count);
99 99
 
100 100
             $job->changeStatus('expired');
101 101
 
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
         $i            = 0;
125 125
         /* @var Job $job */
126 126
         foreach ($jobs as $job) {
127
-            $progress->update($i++, 'Job ' . $i . ' / ' . $count);
127
+            $progress->update($i++, 'Job '.$i.' / '.$count);
128 128
             
129 129
             $permissions = $job->getPermissions();
130 130
             $user        = $job->getUser();
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
                 continue;
133 133
             }
134 134
             try {
135
-                $group       = $user->getGroup($job->getCompany());
135
+                $group = $user->getGroup($job->getCompany());
136 136
             } catch (\Exception $e) {
137 137
                 continue;
138 138
             }
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Controller/Plugin/InitializeJob.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -41,9 +41,9 @@  discard block
 block discarded – undo
41 41
 
42 42
     public function __construct(RepositoryService $repositoryService, AuthenticationService $auth, Acl $acl)
43 43
     {
44
-        $this->repositoryService=$repositoryService;
45
-        $this->auth=$auth;
46
-        $this->acl=$acl;
44
+        $this->repositoryService = $repositoryService;
45
+        $this->auth = $auth;
46
+        $this->acl = $acl;
47 47
     }
48 48
 
49 49
     public function __invoke()
@@ -61,12 +61,12 @@  discard block
 block discarded – undo
61 61
     public function get(Params $params, $allowDraft = false)
62 62
     {
63 63
         /* @var \Jobs\Repository\Job $jobRepository */
64
-        $jobRepository  = $this->repositoryService->get('Jobs/Job');
64
+        $jobRepository = $this->repositoryService->get('Jobs/Job');
65 65
         $idFromRoute   = $params('id', 0);
66 66
         $idFromQuery   = $params->fromQuery('id', 0);
67 67
         $idFromSubForm = $params->fromPost('job', 0);
68 68
 
69
-        $id = empty($idFromRoute)? (empty($idFromQuery)?$idFromSubForm:$idFromQuery) : $idFromRoute;
69
+        $id = empty($idFromRoute) ? (empty($idFromQuery) ? $idFromSubForm : $idFromQuery) : $idFromRoute;
70 70
 
71 71
         if (empty($id) && $allowDraft) {
72 72
             $this->acl->__invoke('Jobs/Manage', 'new');
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 
85 85
         $job = $jobRepository->find($id);
86 86
         if (!$job) {
87
-            throw new \RuntimeException('No job found with id "' . $id . '"');
87
+            throw new \RuntimeException('No job found with id "'.$id.'"');
88 88
         }
89 89
         return $job;
90 90
     }
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Factory/Form/MultipostingSelectFactory.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -34,8 +34,8 @@  discard block
 block discarded – undo
34 34
         $router = $services->get('Router');
35 35
         $select  = new MultipostingSelect();
36 36
         $helpers = $services->get('ViewHelperManager');
37
-       // $headScript = $helpers->get('headScript');
38
-       /// $basePath  = $helpers->get('basePath');
37
+        // $headScript = $helpers->get('headScript');
38
+        /// $basePath  = $helpers->get('basePath');
39 39
         $currencyFormat  = $helpers->get('currencyFormat');
40 40
 
41 41
         $channels = $services->get('Jobs/Options/Provider');
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 
56 56
             $link = $router->assemble($channel->getParams(), array('name' => $channel->getRoute()));
57 57
             $groups[$category]['options'][$channel->getKey()] =
58
-                              $channel->getLabel() . '|'
58
+                                $channel->getLabel() . '|'
59 59
                             . $channel->getHeadLine() . '|'
60 60
                             . $channel->getDescription() . '|'
61 61
                             . $channel->getLinkText() . '|'
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
         $helpers = $services->get('ViewHelperManager');
37 37
        // $headScript = $helpers->get('headScript');
38 38
        /// $basePath  = $helpers->get('basePath');
39
-        $currencyFormat  = $helpers->get('currencyFormat');
39
+        $currencyFormat = $helpers->get('currencyFormat');
40 40
 
41 41
         $channels = $services->get('Jobs/Options/Provider');
42 42
 
@@ -55,11 +55,11 @@  discard block
 block discarded – undo
55 55
 
56 56
             $link = $router->assemble($channel->getParams(), array('name' => $channel->getRoute()));
57 57
             $groups[$category]['options'][$channel->getKey()] =
58
-                              $channel->getLabel() . '|'
59
-                            . $channel->getHeadLine() . '|'
60
-                            . $channel->getDescription() . '|'
61
-                            . $channel->getLinkText() . '|'
62
-                            . $link . '|' . $channel->getPublishDuration() . '|'
58
+                              $channel->getLabel().'|'
59
+                            . $channel->getHeadLine().'|'
60
+                            . $channel->getDescription().'|'
61
+                            . $channel->getLinkText().'|'
62
+                            . $link.'|'.$channel->getPublishDuration().'|'
63 63
                             . $channel->getLogo();
64 64
         }
65 65
 
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Factory/Filter/ViewModelTemplateFilterFactory.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@
 block discarded – undo
58 58
             $filter->setViewHelperForm($viewHelperForm);
59 59
         }
60 60
         if (!isset($filter)) {
61
-            throw new \InvalidArgumentException(get_class($element) . ' cannot be used to initialize a template');
61
+            throw new \InvalidArgumentException(get_class($element).' cannot be used to initialize a template');
62 62
         }
63 63
         $viewManager = $this->service->get('viewHelperManager');
64 64
         $basePathHelper = $viewManager->get('basePath');
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Factory/Service/JobsPublisherFactory.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
         if (!array_key_exists('path', $config)) {
40 40
             throw new \RuntimeException('path is missing', 500);
41 41
         }
42
-        return $config['scheme'] . '://' . $config['host'] . '/' . $config['path'];
42
+        return $config['scheme'].'://'.$config['host'].'/'.$config['path'];
43 43
     }
44 44
 
45 45
     /**
Please login to merge, or discard this patch.