cross-solution /
YAWIK
| Conditions | 15 |
| Paths | 156 |
| Total Lines | 99 |
| Code Lines | 57 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 64 | public function renderBare(FormInterface $form, $layout = self::LAYOUT_HORIZONTAL, $parameter = array()) |
||
| 65 | { |
||
| 66 | /* @var $renderer \Zend\View\Renderer\PhpRenderer |
||
| 67 | * @var $headscript \Zend\View\Helper\HeadScript |
||
| 68 | * @var $basepath \Zend\View\Helper\BasePath */ |
||
| 69 | $renderer = $this->getView(); |
||
| 70 | $headscript = $renderer->plugin('headscript'); |
||
| 71 | $basepath = $renderer->plugin('basepath'); |
||
| 72 | |||
| 73 | $headscript->appendFile($basepath('modules/Core/js/core.spinnerbutton.js')) |
||
| 74 | //->appendFile($basepath('/assets/select2/js/select2.min.js')) |
||
| 75 | ->appendFile($basepath('modules/Core/js/core.forms.js')); |
||
| 76 | |||
| 77 | /* @noinspection PhpParamsInspection */ |
||
| 78 | //$renderer->headLink()->appendStylesheet($basepath('/assets/select2/css/select2.css')); |
||
| 79 | |||
| 80 | if ($scripts = $form->getOption('headscript')) { |
||
| 81 | if (!is_array($scripts)) { |
||
| 82 | $scripts = array($scripts); |
||
| 83 | } |
||
| 84 | foreach ($scripts as $script) { |
||
| 85 | $headscript->appendFile($basepath($script)); |
||
| 86 | } |
||
| 87 | } |
||
| 88 | |||
| 89 | $class = $form->getAttribute('class'); |
||
| 90 | $class = preg_replace('~\bform-[^ ]+\b~', '', $class); |
||
| 91 | $class .= ' ' . $layout; |
||
| 92 | |||
| 93 | $form->setAttribute('class', $class); |
||
| 94 | |||
| 95 | $formId = $form->getAttribute('id') ?: $form->getName(); |
||
| 96 | $formId = preg_replace( |
||
| 97 | array('~[^A-Za-z0-9_-]~', '~--+~', '~^-|-$~'), |
||
| 98 | array('-' , '-' , '' ), |
||
| 99 | $formId |
||
| 100 | ); |
||
| 101 | $form->setAttribute( |
||
| 102 | 'id', |
||
| 103 | $formId |
||
| 104 | |||
| 105 | ); |
||
| 106 | |||
| 107 | if (method_exists($form, 'prepare')) { |
||
| 108 | $form->prepare(); |
||
| 109 | } |
||
| 110 | |||
| 111 | $formContent = ''; |
||
| 112 | |||
| 113 | if ($form instanceof ViewPartialProviderInterface) { |
||
| 114 | return $renderer->partial($form->getViewPartial(), array_merge(['element' => $form], $parameter)); |
||
| 115 | } |
||
| 116 | |||
| 117 | /* @var $element \Zend\Form\ElementInterface */ |
||
| 118 | foreach ($form as $element) { |
||
| 119 | $parameterPartial = $parameter; |
||
| 120 | $elementId = $element->getAttribute('id'); |
||
| 121 | if (!$elementId) { |
||
| 122 | $elementId = preg_replace( |
||
| 123 | array('~[^A-Za-z0-9_-]~', '~--+~', '~^-|-$~'), |
||
| 124 | array('-' , '-', ''), |
||
| 125 | $element->getName() |
||
| 126 | ); |
||
| 127 | } |
||
| 128 | $element->setAttribute('id', "$formId-$elementId"); |
||
| 129 | $element->setOption('__form_id__', $formId); |
||
| 130 | if ($element instanceof ExplicitParameterProviderInterface) { |
||
| 131 | /* @var $element ExplicitParameterProviderInterface */ |
||
| 132 | $parameterPartial = array_merge($element->getParams(), $parameterPartial); |
||
| 133 | } |
||
| 134 | |||
| 135 | if ($element instanceof ViewPartialProviderInterface) { |
||
| 136 | /* @var $element ViewPartialProviderInterface */ |
||
| 137 | $parameterPartial = array_merge(array('element' => $element, 'layout' => $layout), $parameterPartial); |
||
| 138 | /** @noinspection PhpToStringImplementationInspection */ |
||
| 139 | $formContent .= $renderer->partial( |
||
| 140 | $element->getViewPartial(), |
||
| 141 | $parameterPartial |
||
| 142 | ); |
||
| 143 | } elseif ($element instanceof FieldsetInterface) { |
||
| 144 | if ($element instanceof ViewHelperProviderInterface) { |
||
| 145 | /* @var $element ViewHelperProviderInterface */ |
||
| 146 | $helper = $element->getViewHelper(); |
||
| 147 | if (is_string($helper)) { |
||
| 148 | $helper = $renderer->plugin($helper); |
||
| 149 | } |
||
| 150 | |||
| 151 | $formContent .= $helper($element); |
||
| 152 | } else { |
||
| 153 | $formContent .= $renderer->formCollection($element, true, $layout); |
||
| 154 | } |
||
| 155 | } elseif (false !== $element->getOption('use_formrow_helper')) { |
||
| 156 | $formContent .= $renderer->formRow($element, null, null, $layout); |
||
| 157 | } else { |
||
| 158 | $formContent .= $renderer->formElement($element); |
||
| 159 | } |
||
| 160 | } |
||
| 161 | |||
| 162 | return $this->openTag($form) . $formContent . $this->closeTag(); |
||
| 163 | } |
||
| 231 |
Loading history...
