Passed
Pull Request — master (#631)
by ANTHONIUS
08:16
created
module/Cv/test/CvTest/Factory/Form/EducationCollectionFactoryTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
 
36 36
     private $target = EducationCollectionFactory::class;
37 37
 
38
-    private $inheritance = [ FactoryInterface::class ];
38
+    private $inheritance = [FactoryInterface::class];
39 39
 
40 40
     public function testInvokation()
41 41
     {
Please login to merge, or discard this patch.
module/Cv/test/CvTest/Entity/CvTest.php 1 patch
Spacing   +26 added lines, -26 removed lines patch added patch discarded remove patch
@@ -39,15 +39,15 @@  discard block
 block discarded – undo
39 39
 
40 40
     private $target = Cv::class;
41 41
 
42
-    private $inheritance = [ AbstractIdentifiableEntity::class, CvInterface::class, DraftableEntityInterface::class ];
42
+    private $inheritance = [AbstractIdentifiableEntity::class, CvInterface::class, DraftableEntityInterface::class];
43 43
 
44 44
     public function propertiesProvider()
45 45
     {
46 46
         $coll = new ArrayCollection();
47 47
         $prefJob = new PreferredJob();
48
-        $defaultOptions = [ 'default' => $coll, 'value' => $coll ];
49
-        $indexedByOptions = function ($prop) use ($coll) {
50
-            return [ $prop, [ 'value' => $coll, 'getter_method' => 'get*IndexedById', 'expect' => '@' . IdentityWrapper::class]];
48
+        $defaultOptions = ['default' => $coll, 'value' => $coll];
49
+        $indexedByOptions = function($prop) use ($coll) {
50
+            return [$prop, ['value' => $coll, 'getter_method' => 'get*IndexedById', 'expect' => '@'.IdentityWrapper::class]];
51 51
         };
52 52
         $permissions = $this
53 53
             ->getMockBuilder(Permissions::class)
@@ -69,46 +69,46 @@  discard block
 block discarded – undo
69 69
 
70 70
 
71 71
         return [
72
-            [ 'educations', $defaultOptions],
73
-            [ 'employments',$defaultOptions],
74
-            [ 'skills',     $defaultOptions],
75
-            [ 'languageSkills', $defaultOptions],
76
-            [ 'nativeLanguages', ['default' => [], 'value' => []]],
77
-            [ 'preferredJob', [ 'default' => $prefJob, 'value' => $prefJob]],
78
-            [ 'user', new User() ],
79
-            [ 'contact', new Contact()],
80
-            [ 'contact', ['value' => new Info(), 'expect' => '@' . Contact::class ]],
72
+            ['educations', $defaultOptions],
73
+            ['employments', $defaultOptions],
74
+            ['skills', $defaultOptions],
75
+            ['languageSkills', $defaultOptions],
76
+            ['nativeLanguages', ['default' => [], 'value' => []]],
77
+            ['preferredJob', ['default' => $prefJob, 'value' => $prefJob]],
78
+            ['user', new User()],
79
+            ['contact', new Contact()],
80
+            ['contact', ['value' => new Info(), 'expect' => '@'.Contact::class]],
81 81
             $indexedByOptions('languageSkills'),
82 82
             $indexedByOptions('employments'),
83 83
             $indexedByOptions('educations'),
84 84
             $indexedByOptions('skills'),
85
-            [ 'isDraft', [ 'value' => false, 'getter_method' => '*']],
86
-            [ 'status', ['value' => new Status(), 'default' => new Status() ]],
87
-            [ 'status', ['value' => Status::NONPUBLIC, 'expect' => '@' . Status::class]],
88
-            [ 'status', ['value' => Status::PUBLIC_TO_ALL, 'ignore_getter' => true,
89
-                         'pre' => function () use ($permissions2) {
85
+            ['isDraft', ['value' => false, 'getter_method' => '*']],
86
+            ['status', ['value' => new Status(), 'default' => new Status()]],
87
+            ['status', ['value' => Status::NONPUBLIC, 'expect' => '@'.Status::class]],
88
+            ['status', ['value' => Status::PUBLIC_TO_ALL, 'ignore_getter' => true,
89
+                         'pre' => function() use ($permissions2) {
90 90
                              $this->target->setPermissions($permissions2);
91 91
                          }]
92 92
             ],
93
-            [ 'status', ['value' => Status::NONPUBLIC, 'ignore_getter' => true,
94
-                         'pre' => function () use ($permissions2) {
93
+            ['status', ['value' => Status::NONPUBLIC, 'ignore_getter' => true,
94
+                         'pre' => function() use ($permissions2) {
95 95
                              $this->target->setPermissions($permissions2);
96 96
                          },
97
-                         'post' => function () use ($permissions2) {
97
+                         'post' => function() use ($permissions2) {
98 98
                              $permissions2->__phpunit_verify();
99 99
                          }]
100 100
             ],
101
-            [ 'attachments', $defaultOptions],
102
-            [ 'user', ['value' => new User(), 'ignore_getter' => true,
103
-                        'pre' => function () use ($permissions) {
101
+            ['attachments', $defaultOptions],
102
+            ['user', ['value' => new User(), 'ignore_getter' => true,
103
+                        'pre' => function() use ($permissions) {
104 104
                             $this->target->setUser(new User())->setPermissions($permissions);
105 105
                         },
106
-                        'post' => function () use ($permissions) {
106
+                        'post' => function() use ($permissions) {
107 107
                             $permissions->__phpunit_verify();
108 108
                         }
109 109
             ]],
110 110
 
111
-            [ 'resourceId', ['value' => 'Entity/Cv', 'ignore_setter' => true ]],
111
+            ['resourceId', ['value' => 'Entity/Cv', 'ignore_setter' => true]],
112 112
         ];
113 113
     }
114 114
 }
Please login to merge, or discard this patch.
module/Cv/test/CvTest/Form/EmploymentFieldsetTest.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -47,19 +47,19 @@  discard block
 block discarded – undo
47 47
             'mock' => [
48 48
                 'add',
49 49
                 'setName' => ['with' => 'employment', 'count' => 1, 'return' => '__self__'],
50
-                'setHydrator' => ['@with' => ['isInstanceOf', EntityHydrator::class ], 'count' => 1, 'return' => '__self__'],
51
-                'setObject' => ['@with' => ['isInstanceOf', Employment::class ], 'count' => 1, 'return' => '__self__'],
50
+                'setHydrator' => ['@with' => ['isInstanceOf', EntityHydrator::class], 'count' => 1, 'return' => '__self__'],
51
+                'setObject' => ['@with' => ['isInstanceOf', Employment::class], 'count' => 1, 'return' => '__self__'],
52 52
             ],
53 53
             'args' => false,
54 54
         ],
55 55
         '@testPopulateValues' => [
56
-            'mock' => [ 'get' ],
56
+            'mock' => ['get'],
57 57
         ],
58 58
     ];
59 59
 
60
-    private $inheritance = [ Fieldset::class, InputFilterProviderInterface::class, ViewPartialProviderInterface::class ];
60
+    private $inheritance = [Fieldset::class, InputFilterProviderInterface::class, ViewPartialProviderInterface::class];
61 61
 
62
-    private $traits = [ ViewPartialProviderTrait::class ];
62
+    private $traits = [ViewPartialProviderTrait::class];
63 63
 
64 64
     private $attributes = [
65 65
         'defaultPartial' => 'cv/form/employment',
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
              ],
110 110
         ];
111 111
 
112
-        $addArgValidator = function ($arg) use ($add) {
112
+        $addArgValidator = function($arg) use ($add) {
113 113
             static $count = 0;
114 114
 
115 115
             /* PPHUnit calls this callback again after all invokations are made
@@ -137,11 +137,11 @@  discard block
 block discarded – undo
137 137
     public function populateValuesDataProvider()
138 138
     {
139 139
         return [
140
-            [ [ ], false ],
141
-            [ ['currentIndicator'=>true], false ],
142
-            [ ['currentIndicator' => false, 'endDate' => 'endDate' ], false ],
143
-            [ ['endDate' => 'endDate'], false ],
144
-            [ ['currentIndicator' => true, 'endDate' => 'endDate'], true ],
140
+            [[], false],
141
+            [['currentIndicator'=>true], false],
142
+            [['currentIndicator' => false, 'endDate' => 'endDate'], false],
143
+            [['endDate' => 'endDate'], false],
144
+            [['currentIndicator' => true, 'endDate' => 'endDate'], true],
145 145
         ];
146 146
     }
147 147
 
Please login to merge, or discard this patch.
module/Cv/test/CvTest/Form/EducationFieldsetTest.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -47,19 +47,19 @@  discard block
 block discarded – undo
47 47
             'mock' => [
48 48
                 'add',
49 49
                 'setName' => ['with' => 'education', 'count' => 1, 'return' => '__self__'],
50
-                'setHydrator' => ['@with' => ['isInstanceOf', EntityHydrator::class ], 'count' => 1, 'return' => '__self__'],
51
-                'setObject' => ['@with' => ['isInstanceOf', Education::class ], 'count' => 1, 'return' => '__self__'],
50
+                'setHydrator' => ['@with' => ['isInstanceOf', EntityHydrator::class], 'count' => 1, 'return' => '__self__'],
51
+                'setObject' => ['@with' => ['isInstanceOf', Education::class], 'count' => 1, 'return' => '__self__'],
52 52
             ],
53 53
             'args' => false,
54 54
         ],
55 55
         '@testPopulateValues' => [
56
-            'mock' => [ 'get' ],
56
+            'mock' => ['get'],
57 57
         ],
58 58
     ];
59 59
 
60
-    private $inheritance = [ Fieldset::class, InputFilterProviderInterface::class, ViewPartialProviderInterface::class ];
60
+    private $inheritance = [Fieldset::class, InputFilterProviderInterface::class, ViewPartialProviderInterface::class];
61 61
 
62
-    private $traits = [ ViewPartialProviderTrait::class ];
62
+    private $traits = [ViewPartialProviderTrait::class];
63 63
 
64 64
     private $attributes = [
65 65
         'defaultPartial' => 'cv/form/education',
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
              ],
136 136
         ];
137 137
 
138
-        $addArgValidator = function ($arg) use ($add) {
138
+        $addArgValidator = function($arg) use ($add) {
139 139
             static $count = 0;
140 140
 
141 141
             /* PPHUnit calls this callback again after all invokations are made
@@ -163,11 +163,11 @@  discard block
 block discarded – undo
163 163
     public function populateValuesDataProvider()
164 164
     {
165 165
         return [
166
-            [ [ ], false ],
167
-            [ ['currentIndicator'=>true], false ],
168
-            [ ['currentIndicator' => false, 'endDate' => 'endDate' ], false ],
169
-            [ ['endDate' => 'endDate'], false ],
170
-            [ ['currentIndicator' => true, 'endDate' => 'endDate'], true ],
166
+            [[], false],
167
+            [['currentIndicator'=>true], false],
168
+            [['currentIndicator' => false, 'endDate' => 'endDate'], false],
169
+            [['endDate' => 'endDate'], false],
170
+            [['currentIndicator' => true, 'endDate' => 'endDate'], true],
171 171
         ];
172 172
     }
173 173
 
Please login to merge, or discard this patch.
module/Cv/test/CvTest/Form/PreferredJobFieldsetTest.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -44,14 +44,14 @@  discard block
 block discarded – undo
44 44
             'mock' => [
45 45
                 'add',
46 46
                 'setName' => ['with' => 'preferredJob', 'count' => 1, 'return' => '__self__'],
47
-                'setHydrator' => ['@with' => ['isInstanceOf', EntityHydrator::class ], 'count' => 1, 'return' => '__self__'],
48
-                'setObject' => ['@with' => ['isInstanceOf', PreferredJob::class ], 'count' => 1, 'return' => '__self__'],
47
+                'setHydrator' => ['@with' => ['isInstanceOf', EntityHydrator::class], 'count' => 1, 'return' => '__self__'],
48
+                'setObject' => ['@with' => ['isInstanceOf', PreferredJob::class], 'count' => 1, 'return' => '__self__'],
49 49
             ],
50 50
             'args' => false,
51 51
         ],
52 52
     ];
53 53
 
54
-    private $inheritance = [ Fieldset::class ];
54
+    private $inheritance = [Fieldset::class];
55 55
 
56 56
     private $attributes = [
57 57
         'typeOfApplicationOptions' => [
@@ -151,13 +151,13 @@  discard block
 block discarded – undo
151 151
         ];
152 152
 
153 153
         $callCount = count($add);
154
-        $addArgValidator = function ($arg) use ($add, $callCount) {
154
+        $addArgValidator = function($arg) use ($add, $callCount) {
155 155
             static $count = 0;
156 156
 
157 157
             /* PPHUnit calls this callback again after all invokations are made
158 158
              * I don't know why, but therefor the need to check if $count is greater that 7
159 159
              */
160
-            return $callCount - 1  < $count || $arg == $add[$count++];
160
+            return $callCount - 1 < $count || $arg == $add[$count++];
161 161
         };
162 162
 
163 163
         $this->target
Please login to merge, or discard this patch.
Install/test/InstallTest/Controller/Plugin/YawikConfigCreatorTest.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -68,11 +68,11 @@
 block discarded – undo
68 68
 
69 69
     public function testWritingConfigFileWorks()
70 70
     {
71
-        $dir = sys_get_temp_dir() . '/YawikConfigCreator-' . uniqid();
71
+        $dir = sys_get_temp_dir().'/YawikConfigCreator-'.uniqid();
72 72
 
73 73
         mkdir($dir);
74
-        mkdir($dir . '/config');
75
-        mkdir($dir . '/config/autoload');
74
+        mkdir($dir.'/config');
75
+        mkdir($dir.'/config/autoload');
76 76
 
77 77
         chdir($dir);
78 78
 
Please login to merge, or discard this patch.
module/Install/test/InstallTest/Controller/Plugin/UserCreatorTest.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
         $dm = $this->createMock(DocumentManager::class);
55 55
 
56 56
         $this->target = new UserCreator($credentialFilter, $dm);
57
-        $this->credentialFilter= $credentialFilter;
57
+        $this->credentialFilter = $credentialFilter;
58 58
         $this->documentManager = $dm;
59 59
     }
60 60
 
Please login to merge, or discard this patch.
module/Install/test/InstallTest/Validator/MongoDbConnectionStringTest.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -46,9 +46,9 @@  discard block
 block discarded – undo
46 46
     public function invalidConnectionStringProvider()
47 47
     {
48 48
         return [
49
-            [ 'noconnstr' ],
50
-            [ 'mongodb://user name:pass@server' ],
51
-            [ 'mongodb://server/db.with.dot' ],
49
+            ['noconnstr'],
50
+            ['mongodb://user name:pass@server'],
51
+            ['mongodb://server/db.with.dot'],
52 52
         ];
53 53
     }
54 54
 
@@ -59,26 +59,26 @@  discard block
 block discarded – undo
59 59
     {
60 60
         $target = new MongoDbConnectionString();
61 61
 
62
-        $this->assertFalse($target->isValid($connStr), 'Failed with: ' . $connStr);
62
+        $this->assertFalse($target->isValid($connStr), 'Failed with: '.$connStr);
63 63
     }
64 64
 
65 65
     public function validConnectionStringsProvider()
66 66
     {
67 67
         return [
68
-            [ 'mongodb://server' ],
69
-            [ 'mongodb://server/database' ],
70
-            [ 'mongodb://server:1234' ],
71
-            [ 'mongodb://server:1234/database' ],
72
-            [ 'mongodb://user@server' ],
73
-            [ 'mongodb://user@server:1234' ],
74
-            [ 'mongodb://user@server/database' ],
75
-            [ 'mongodb://user@server:1234/database' ],
76
-            [ 'mongodb://user:pass@server' ],
77
-            [ 'mongodb://user:pass@server/database' ],
78
-            [ 'mongodb://user:pass@server:1234' ],
79
-            [ 'mongodb://user:pass@server:1234/database' ],
80
-            [ 'mongodb://server:23432/dbName?option=value' ],
81
-            [ 'mongodb://name:[email protected]:27017,cluster0-shard-00-01-nvwmc.mongodb.net:27017,cluster0-shard-00-02-nvwmc.mongodb.net:27017/?ssl=true&replicaSet=Cluster0-shard-0&authSource=admin' ],
68
+            ['mongodb://server'],
69
+            ['mongodb://server/database'],
70
+            ['mongodb://server:1234'],
71
+            ['mongodb://server:1234/database'],
72
+            ['mongodb://user@server'],
73
+            ['mongodb://user@server:1234'],
74
+            ['mongodb://user@server/database'],
75
+            ['mongodb://user@server:1234/database'],
76
+            ['mongodb://user:pass@server'],
77
+            ['mongodb://user:pass@server/database'],
78
+            ['mongodb://user:pass@server:1234'],
79
+            ['mongodb://user:pass@server:1234/database'],
80
+            ['mongodb://server:23432/dbName?option=value'],
81
+            ['mongodb://name:[email protected]:27017,cluster0-shard-00-01-nvwmc.mongodb.net:27017,cluster0-shard-00-02-nvwmc.mongodb.net:27017/?ssl=true&replicaSet=Cluster0-shard-0&authSource=admin'],
82 82
         ];
83 83
     }
84 84
 
@@ -91,6 +91,6 @@  discard block
 block discarded – undo
91 91
     {
92 92
         $target = new MongoDbConnectionString();
93 93
 
94
-        $this->assertTrue($target->isValid($connStr), 'Failed with: "' . $connStr . '"');
94
+        $this->assertTrue($target->isValid($connStr), 'Failed with: "'.$connStr.'"');
95 95
     }
96 96
 }
Please login to merge, or discard this patch.
module/Install/test/TestConfig.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@
 block discarded – undo
5 5
     // This should be an array of module namespaces used in the application.
6 6
 
7 7
 use PHPUnit\Framework\TestCase;
8
-    'modules' => array_merge($commonModules,array(
8
+    'modules' => array_merge($commonModules, array(
9 9
         'Install',
10 10
     )),
11 11
 
Please login to merge, or discard this patch.