Cv\Service\UploadHandler::createFromApplication()

Complexity

Conditions	3
Paths	2

Size

Total Lines	54
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function createFromApplication(Application $application, UserInterface $user)
    {
        $repository = $this->cvRepo;
        $cv = $repository->create();

The method create() does not exist on Doctrine\Persistence\ObjectRepository. It seems like you code against a sub-type of Doctrine\Persistence\ObjectRepository such as Core\Repository\SnapshotRepository or Core\Repository\AbstractRepository.

        $cv->setContact($application->getContact());

        $assignedUser = $application->getJob()->getUser();
        $cv->setUser($assignedUser);

        $perms = $cv->getPermissions();

        $perms->inherit($application->getPermissions());
        // grant view permission to the user that issued this creation.
        $perms->grant($user, PermissionsInterface::PERMISSION_VIEW);
        // revoke change permission to the original applicant
        $perms->revoke($application->getUser(), PermissionsInterface::PERMISSION_CHANGE);

        $applicationAttachments = $application->getAttachments();

        if (count($applicationAttachments) > 0) {
            $cvAttachments = [];
            $fileManager = $this->fileManager;

            foreach ($applicationAttachments as $from) {
                //$gridfs = new \MongoGridFS($this->dm->getClient());
                //$file = new \MongoGridFSFile($gridfs, $appAttachment->getFile());

                /*
                $cvAttachment = new CvAttachment();
                $cvAttachment->setName($applicationAttachment->getName());
                $cvAttachment->setType($applicationAttachment->getType());
                $cvAttachment->setUser($assignedUser);
                $cvAttachment->setFile($file);
                $cvAttachment->setDateUploaded($applicationAttachment->getDateUploaded());
                */
                $fromMetadata = $from->getMetadata();
                $metadata = new FileMetadata();
                $metadata->setContentType($fromMetadata->getContentType());
                $metadata->setUser($assignedUser);

It seems like $assignedUser can also be of type null; however, parameter $user of Core\Entity\FileMetadata::setUser() does only seem to accept Auth\Entity\UserInterface, maybe add an additional type check?

                $fromStream = $fileManager->getStream($from);
                $toAttachment = $fileManager->uploadFromStream(
                    Attachment::class,
                    $metadata,
                    $from->getName(),

It seems like $from->getName() can also be of type null; however, parameter $fileName of Core\Service\FileManager::uploadFromStream() does only seem to accept string, maybe add an additional type check?

                    $fromStream
                );
                $cvAttachments[] = $toAttachment;
            }

            $cv->setAttachments(new ArrayCollection($cvAttachments));
        }

        return $cv;
    }
}