cross-solution / YAWIK

module/Auth/src/Auth/Factory/Listener/ExceptionStrategyFactory.php

Spacing +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
                 break;
         }
 
-        $config   = $container->get('Config');
+        $config = $container->get('Config');
 
         if (isset($config['view_manager'])) {
             if (isset($config['view_manager']['display_exceptions'])) {

module/Core/src/Core/Entity/AttachableEntityInterface.php

Doc Comments +1 added lines

@@ -22,6 +22,7 @@
     /**
      * @param AttachableEntityManager $attachableEntityManager
      * @throws \LogicException If attachable entity manager is already set
+     * @return AttachableEntityTrait
      */
     public function setAttachableEntityManager(AttachableEntityManager $attachableEntityManager);
 

module/Core/src/Core/Entity/AttachableEntityTrait.php

Spacing +1 added lines, -1 removed lines

@@ -78,7 +78,7 @@
     /**
      * @see AttachableEntityInterface::createAttachedEntity()
      */
-    public function createAttachedEntity($entityClass, $values = [], $key=null)
+    public function createAttachedEntity($entityClass, $values = [], $key = null)
     {
         return $this->getAttachableEntityManager()->createAttachedEntity($entityClass, $values, $key);
     }

module/Core/src/Core/View/Helper/Snippet.php

Spacing +2 added lines, -2 removed lines

@@ -89,7 +89,7 @@ 
 
     private function fromEvent($name, $values)
     {
-        $event  = $this->events->getEvent($name, $this, $values);
+        $event = $this->events->getEvent($name, $this, $values);
         $results = $this->events->triggerEvent($event);
 
         $snippets = [];
@@ -138,7 +138,7 @@ 
             $content = $item['content'];
 
             foreach ($values as $key => $val) {
-                $content = str_replace('%' . $key . '%', $val, $content);
+                $content = str_replace('%'.$key.'%', $val, $content);
             }
 
             return $content;

module/Core/src/Core/Mail/TranslatorAwareMessage.php

Doc Comments +1 added lines, -1 removed lines

@@ -102,7 +102,7 @@
      * </pre>
      *
      * @param string $subject
-     * @param bool|mixed $translate
+     * @param string $translate
      *
      * @since 0.19
      * @since 0.29 Add sprintf support for translation

module/Core/src/Core/Factory/OptionsAbstractFactory.php

Doc Comments +1 added lines, -1 removed lines

@@ -176,7 +176,7 @@
      *
      * @param string $fullName
      *
-     * @return array|bool
+     * @return string
      */
     protected function getOptionsConfig($fullName)
     {

module/Applications/src/Applications/Entity/ApplicationInterface.php

Doc Comments +2 added lines, -2 removed lines

@@ -240,7 +240,7 @@ 
     /**
      * Gets all comments for the application.
      *
-     * @return ArrayCollection;
+     * @return Collection
 
      */
     public function getComments();
@@ -271,7 +271,7 @@ 
     /**
      * Gets all attributes for an application.
      *
-     * @return ArrayCollection;
+     * @return Attributes
 
      */
     public function getAttributes();

Indentation -2 removed lines

@@ -241,7 +241,6 @@ 
      * Gets all comments for the application.
      *
      * @return ArrayCollection;
-
      */
     public function getComments();
     
@@ -272,7 +271,6 @@ 
      * Gets all attributes for an application.
      *
      * @return ArrayCollection;
-
      */
     public function getAttributes();
 

module/Core/src/Core/View/Helper/Period.php

Doc Comments +1 added lines, -1 removed lines

@@ -18,7 +18,7 @@
      * returns the number of years of the education or work experience
      *
      * @param array $array
-     * @return string
+     * @return double
      */
     public function __invoke($array)
     {

Spacing +3 added lines, -3 removed lines

@@ -25,13 +25,13 @@
         // calculate EndDate - StartDate = X Years.
         // eg. 4.2 Years
         
-        $days=0;
+        $days = 0;
         foreach ($array as $obj) {
             $date1 = new \DateTime($obj->getEndDate());
             $date2 = new \DateTime($obj->getStartDate());
             $interval = $date1->diff($date2);
-            $days+=abs($interval->format('%R%a'));
+            $days += abs($interval->format('%R%a'));
         }
-        return round($days/365, 1);
+        return round($days / 365, 1);
     }
 }

module/Jobs/src/Jobs/Controller/ManageController.php

Doc Comments +3 added lines, -4 removed lines

@@ -165,7 +165,6 @@ 
      *
      * parameter are arbitrary elements for defaults or programming flow
      *
-     * @param array $parameter
      * @return null|ViewModel
      * @throws \RuntimeException
      */
@@ -388,7 +387,7 @@ 
 
     /**
      * @param  $job \Jobs\Entity\Job
-     * @return mixed
+     * @return \Jobs\Form\Job
      */
     protected function getFormular($job)
     {
@@ -411,7 +410,7 @@ 
     }
 
     /**
-     * @param $form
+     * @param \Jobs\Form\Job $form
      * @param array $params
      * @return ViewModel
      */
@@ -604,7 +603,7 @@ 
     }
 
     /**
-     * @param $script
+     * @param string $script
      * @param array $parameter
      * @return ViewModel
      */

Indentation +47 added lines, -47 removed lines

@@ -66,16 +66,16 @@ 
      */
     protected $translator;
 	
-	/**
-	 * @var FilterPluginManager
-	 */
+    /**
+     * @var FilterPluginManager
+     */
     protected $filterManager;
     
     protected $jobFormEvents;
 	
-	/**
-	 * @var
-	 */
+    /**
+     * @var
+     */
     protected $formManager;
     
     protected $options;
@@ -88,35 +88,35 @@ 
     
     protected $jobEvent;
 	
-	/**
-	 * ManageController constructor.
-	 *
-	 * @TODO: [ZF3] make this controller more thin, looks like so much things to do
-	 *
-	 * @param AuthenticationService $auth
-	 * @param RepositoryService $repositoryService
-	 * @param TranslatorInterface $translator
-	 * @param FilterPluginManager $filterManager
-	 * @param EventManagerInterface $jobFormEvents
-	 * @param $formManager
-	 * @param $options
-	 * @param HelperPluginManager $viewHelper
-	 * @param ValidatorPluginManager $validatorManager
-	 * @param EventManagerInterface $jobEvents
-	 * @param EventInterface $jobEvent
-	 */
+    /**
+     * ManageController constructor.
+     *
+     * @TODO: [ZF3] make this controller more thin, looks like so much things to do
+     *
+     * @param AuthenticationService $auth
+     * @param RepositoryService $repositoryService
+     * @param TranslatorInterface $translator
+     * @param FilterPluginManager $filterManager
+     * @param EventManagerInterface $jobFormEvents
+     * @param $formManager
+     * @param $options
+     * @param HelperPluginManager $viewHelper
+     * @param ValidatorPluginManager $validatorManager
+     * @param EventManagerInterface $jobEvents
+     * @param EventInterface $jobEvent
+     */
     public function __construct(
-    	AuthenticationService $auth,
-	    RepositoryService $repositoryService,
-	    TranslatorInterface $translator,
-		FilterPluginManager $filterManager,
-		EventManagerInterface $jobFormEvents,
-		$formManager,
-		$options,
-		HelperPluginManager $viewHelper,
-		ValidatorPluginManager $validatorManager,
-		EventManagerInterface $jobEvents,
-		EventInterface $jobEvent
+        AuthenticationService $auth,
+        RepositoryService $repositoryService,
+        TranslatorInterface $translator,
+        FilterPluginManager $filterManager,
+        EventManagerInterface $jobFormEvents,
+        $formManager,
+        $options,
+        HelperPluginManager $viewHelper,
+        ValidatorPluginManager $validatorManager,
+        EventManagerInterface $jobEvents,
+        EventInterface $jobEvent
     )
     {
         $this->auth = $auth;
@@ -157,7 +157,7 @@ 
         }
         $routeMatch = $e->getRouteMatch();
         $action = $routeMatch->getParam('action');
-	    $services = $e->getApplication()->getServiceManager();
+        $services = $e->getApplication()->getServiceManager();
         if (in_array($action, array('edit', 'approval', 'completion'))) {
             $jobEvents = $services->get('Jobs/Events');
             $mailSender = $services->get('Jobs/Listener/MailSender');
@@ -202,12 +202,12 @@ 
         $jobEntity = $this->initializeJob()->get($this->params(), true);
 
         $model = new ViewModel([
-                                   'portals' => $jobEntity->getPortals(),
-                                   'channels' => $channels,
-                                   'defaultCurrencyCode' => $options->defaultCurrencyCode,
-                                   'defaultTaxRate' =>  $options->defaultTaxRate,
-                                   'jobId' => $jobEntity->getId()
-                               ]);
+                                    'portals' => $jobEntity->getPortals(),
+                                    'channels' => $channels,
+                                    'defaultCurrencyCode' => $options->defaultCurrencyCode,
+                                    'defaultTaxRate' =>  $options->defaultTaxRate,
+                                    'jobId' => $jobEntity->getId()
+                                ]);
         $model->setTemplate('jobs/partials/channel-list')->setTerminal(true);
         return $model;
     }
@@ -225,7 +225,7 @@ 
      */
     protected function save()
     {
-		$formEvents = $this->jobFormEvents;
+        $formEvents = $this->jobFormEvents;
         $user               = $this->auth->getUser();
         if (empty($user->getInfo()->getEmail())) {
             return $this->getErrorViewModel('no-parent', array('cause' => 'noEmail'));
@@ -584,7 +584,7 @@ 
             'lang/jobs/view',
             array(),
             array('query' => $query
-                      )
+                        )
         );
 
         $approvalLink = $this->url()->fromRoute(
@@ -600,10 +600,10 @@ 
         );
 
         return array('job' => $jobEntity,
-                     'diffSnapshot' => $diff,
-                     'viewLink' => $viewLink,
-                     'approvalLink' => $approvalLink,
-                     'declineLink' => $declineLink);
+                        'diffSnapshot' => $diff,
+                        'viewLink' => $viewLink,
+                        'approvalLink' => $approvalLink,
+                        'declineLink' => $declineLink);
     }
 
     /**

Spacing +15 added lines, -15 removed lines

@@ -226,11 +226,11 @@ 
     protected function save()
     {
 		$formEvents = $this->jobFormEvents;
-        $user               = $this->auth->getUser();
+        $user = $this->auth->getUser();
         if (empty($user->getInfo()->getEmail())) {
             return $this->getErrorViewModel('no-parent', array('cause' => 'noEmail'));
         }
-        $userOrg            = $user->getOrganization();
+        $userOrg = $user->getOrganization();
         if (!$userOrg->hasAssociation() || $userOrg->getOrganization()->isDraft()) {
             return $this->getErrorViewModel('no-parent', array('cause' => 'noCompany'));
         }
@@ -260,7 +260,7 @@ 
         }
 
 
-        $viewModel          = null;
+        $viewModel = null;
         $this->acl($jobEntity, 'edit');
         if ($status = $params->fromQuery('status')) {
             $this->changeStatus($jobEntity, $status);
@@ -272,11 +272,11 @@ 
         $instanceForm       = null;
         $formErrorMessages = array();
 
-        if (isset($formIdentifier) &&  $request->isPost()) {
+        if (isset($formIdentifier) && $request->isPost()) {
             // at this point the form get instantiated and immediately accumulated
             $instanceForm = $form->getForm($formIdentifier);
             if (!isset($instanceForm)) {
-                throw new \RuntimeException('No form found for "' . $formIdentifier . '"');
+                throw new \RuntimeException('No form found for "'.$formIdentifier.'"');
             }
             // the id may be part of the postData, but it never should be altered
             $postData = $request->getPost();
@@ -330,20 +330,20 @@ 
             $jobValid = false;
             $errorMessage[] = $this->translator->translate('Accept the Terms');
         }
-        $result = $formEvents->trigger('ValidateJob', $this, [ 'form' => $form ]);
+        $result = $formEvents->trigger('ValidateJob', $this, ['form' => $form]);
         foreach ($result as $messages) {
             if (!$messages) {
                 continue;
             }
             if (!is_array($messages)) {
-                $messages = [ $messages ];
+                $messages = [$messages];
             }
 
             $errorMessage = array_merge($errorMessage, $messages);
             $jobValid = false;
         }
 
-        $errorMessage = '<br />' . implode('<br />', $errorMessage);
+        $errorMessage = '<br />'.implode('<br />', $errorMessage);
         if ($isAjax) {
             if ($instanceForm instanceof SummaryForm) {
                 $instanceForm->setRenderMode(SummaryForm::RENDER_SUMMARY);
@@ -351,7 +351,7 @@ 
             } else {
                 $viewHelper = 'form';
             }
-            $viewHelperManager  = $this->viewHelper;
+            $viewHelperManager = $this->viewHelper;
             $content = $viewHelperManager->get($viewHelper)->__invoke($instanceForm);
             $viewModel = new JsonModel(
                 array(
@@ -375,7 +375,7 @@ 
                     }
                 }
             } else {
-                $formEvents->trigger('DisableElements', $this, [ 'form' => $form, 'job'=>$jobEntity ]);
+                $formEvents->trigger('DisableElements', $this, ['form' => $form, 'job'=>$jobEntity]);
                 // Job is deployed, some changes are now disabled
                 $form->enableAll();
             }
@@ -383,7 +383,7 @@ 
 
             $completionLink = $this->url()->fromRoute(
                 'lang/jobs/completion',
-                [ 'id' => $jobEntity->getId()]
+                ['id' => $jobEntity->getId()]
             );
 
             $viewModel = $this->getViewModel($form);
@@ -449,7 +449,7 @@ 
     protected function getFormular($job)
     {
         /* @var $forms \Zend\Form\FormElementManager\FormElementManagerV3Polyfill */
-        $forms    = $this->formManager;
+        $forms = $this->formManager;
         /* @var $container \Jobs\Form\Job */
 
         $container = $forms->get(
@@ -554,11 +554,11 @@ 
         // array with differences between the last snapshot and the actual entity
         // is remains Null if there is no snapshot
         // it will be an empty array if the snapshot and the actual entity do not differ
-        $diff           = null;
+        $diff = null;
 
 
         if ($params == 'declined') {
-            if ($jobEntity instanceOf JobSnapshot)  {
+            if ($jobEntity instanceOf JobSnapshot) {
                 $jobEntity->getOriginalEntity()->changeStatus(Status::ACTIVE, sprintf(/*@translate*/ 'Changes were rejected by %s', $user->getDisplayName()));
             } else {
                 $jobEntity->changeStatus(
@@ -623,7 +623,7 @@ 
      */
     public function deactivateAction()
     {
-        $user           = $this->auth->getUser();
+        $user = $this->auth->getUser();
 
         $jobEntity = $this->initializeJob()->get($this->params());