Jobs\Factory\Controller\IndexControllerFactory

Complexity

Total Complexity

1

Size/Duplication

Total Lines	25
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	createService()	14	14	1

<?php
/**
 * YAWIK
 *
 * @filesource
 * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
 * @license       MIT
 */

namespace Jobs\Factory\Controller;

use Jobs\Controller\IndexController;
use Jobs\Repository;
use Zend\Mvc\Controller\ControllerManager;
use Zend\ServiceManager\FactoryInterface;
use Zend\ServiceManager\ServiceLocatorInterface;

class IndexControllerFactory implements FactoryInterface

This class seems to be duplicated in your project.

{

    /**
     * Injects all needed services into the IndexController
     *
     * @param ServiceLocatorInterface $serviceLocator
     *
     * @return JobboardController

Should the return type not be IndexController?

     */
    public function createService(ServiceLocatorInterface $serviceLocator)
    {
        /** @var ControllerManager $serviceLocator */
        $serviceLocator = $serviceLocator->getServiceLocator();

        $searchForm = $serviceLocator->get('forms')->get('Jobs/ListFilter', /* useAcl */ true);

        /**
         * @var $jobRepository Repository\Job
         */
        $jobRepository = $serviceLocator->get('repositories')->get('Jobs/Job');

        return new IndexController($jobRepository, $searchForm);

The call to IndexController::__construct() has too many arguments starting with $jobRepository.

    }
}