Applications\Controller\ApiApplyController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	106
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	noJobFoundModel()	0	9	1
A	noPostRequestModel()	0	9	1
A	indexAction()	0	42	3
A	__construct()	0	8	1
A	invalidApplicationDataModel()	0	10	1
A	invalidDataModel()	0	9	1

<?php

/**
 * YAWIK
 *
 * @filesource
 * @copyright 2020 CROSS Solution <https://www.cross-solution.de>
 * @license MIT
 */

declare(strict_types=1);

namespace Applications\Controller;

use Applications\Entity\Contact;
use Applications\Entity\Hydrator\ApiApplicationHydrator;
use Laminas\Json\Json;
use Laminas\Mvc\Controller\AbstractActionController;
use Laminas\View\Model\JsonModel;
use Applications\Repository\Application as ApplicationsRepository;
use Jobs\Repository\Job as JobsRepository;

/**
 * TODO: description
 *
 * @author Mathias Gelhausen <gelhausen@cross-solution.de>
 * TODO: write tests
 */
class ApiApplyController extends AbstractActionController
{
    private $appRepository;
    private $jobRepository;
    private $formContainer;

    public function __construct(
        ApplicationsRepository $appRepository,
        JobsRepository $jobRepository,
        $formContainer
    ) {
        $this->appRepository = $appRepository;
        $this->jobRepository = $jobRepository;
        $this->formContainer = $formContainer;
    }

    public function indexAction()
    {
        /** @var \Laminas\Http\PhpEnvironment\Request $request */
        $request = $this->getRequest();
        if (!$request->isPost()) {
            return $this->noPostRequestModel();
        }

        $applyId = $this->params()->fromQuery('applyId');
        $job = $this->jobRepository->findOneBy(['applyId' => $applyId]);

        if (!$job) {

$job is of type object, thus it always evaluated to true.

            return $this->noJobFoundModel($applyId);
        }

        $data = array_merge_recursive(
            $request->getPost()->toArray(),
            $request->getFiles()->toArray()
        );


        $application = $this->appRepository->create();
        $application->setJob($job);
        $user = $this->auth()->getUser();

The method auth() does not exist on Applications\Controller\ApiApplyController. Since you implemented __call, consider adding a @method annotation.

The method getUser() does not exist on Laminas\Stdlib\DispatchableInterface. It seems like you code against a sub-type of Laminas\Stdlib\DispatchableInterface such as Laminas\Mvc\Controller\AbstractController.

        $application->setUser($user);
        $application->setContact(new Contact());

        $hydrator = new ApiApplicationHydrator();
        $hydrator->hydrate($data, $application);
        //$application->getContact()->setFirstName($data['contact']['firstName']);


        $result = [
            'status' => 'OK',
            'id' => $application->getId(),
            'test' => $application->getContact()->getFirstName(),
            'test2' => $application->getJob()->getId(),
            'entity' => $hydrator->extract($application)
        ];

        $model = new JsonModel($result);
        return $model;
    }

    private function noPostRequestModel()
    {
        /** @var \Laminas\Http\PhpEnvironment\Response $response */
        $response = $this->getResponse();
        $response->setStatusCode($response::STATUS_CODE_405);

        return new JsonModel([
            'status' => 'error',
            'message' => 'Invalid request method. Only POST allowed.'
        ]);
    }

    private function invalidDataModel($e)

The method invalidDataModel() is not used, and could be removed.

    {
        /** @var \Laminas\Http\PhpEnvironment\Response $response */
        $response = $this->getResponse();
        $response->setStatusCode($response::STATUS_CODE_405);

        return new JsonModel([
            'status' => 'error',
            'message' => 'Invalid json data: ' . $e->getMessage()
        ]);
    }

    private function noJobFoundModel($applyId)
    {
        /** @var \Laminas\Http\PhpEnvironment\Response $response */
        $response = $this->getResponse();
        $response->setStatusCode($response::STATUS_CODE_400);

        return new JsonModel([
            'status' => 'error',
            'message' => 'No job found with apply id "' . $applyId . '"',
        ]);
    }

    private function invalidApplicationDataModel()

The method invalidApplicationDataModel() is not used, and could be removed.

    {
        /** @var \Laminas\Http\PhpEnvironment\Response $response */
        $response = $this->getResponse();
        $response->setStatusCode($response::STATUS_CODE_400);

        return new JsonModel([
            'status' => 'error',
            'message' => 'Invalid application data.',
            'errrors' => $this->formContainer->getMessages()
        ]);
    }
}