Auth\Controller\UsersController

Complexity

Total Complexity

18

Size/Duplication

Total Lines	164
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
B	editAction()	0	71	10
A	listAction()	0	12	1
B	switchAction()	0	42	6

<?php
/**
 * YAWIK
 *
 * @filesource
 * @copyright (c) 2013 - 2016 Cross Solution (http://cross-solution.de)
 * @license   MIT
 */

/** Auth controller */
namespace Auth\Controller;

use Zend\Mvc\Controller\AbstractActionController;
use Zend\View\Model\ViewModel;
use Zend\View\Model\JsonModel;
use Auth\Repository\User as UserRepository;
use Core\Form\SummaryFormInterface;

/**
 * List registered users
 *
 * @author Carsten Bleek <bleek@cross-solution.de>
 * @author Mathias Gelhausen <gelhausen@cross-solution.de>
 * @author Anthonius Munthi <me@itstoni.com>
 *
 * @method array|\Core\Controller\Plugin\PaginationBuilder pagination($stack = null, $returnResult = true)
 */
class UsersController extends AbstractActionController
{

    /**
     * @var UserRepository
     */
    protected $userRepository;

    protected $formManager;
    
    protected $viewHelper;
    
    /**
     * @param UserRepository $userRepository
     */
    public function __construct(UserRepository $userRepository,$formManager,$viewHelper)
    {
        $this->userRepository = $userRepository;
        $this->formManager = $formManager;
        $this->viewHelper = $viewHelper;
    }
    
    /**
     * List users
     *
     * @return array|\Zend\Http\Response|ViewModel
     */
    public function listAction()
    {
        return $this->pagination([

The expression return $this->pagination(array('paginator' => array('Auth/User', 'as' => 'users'), 'form' => array('Core/Search', array('text_name' => 'text', 'text_placeholder' => 'Type name, email address, role, or login name', 'button_element' => 'text'), 'as' => 'form'))) also could return the type Core\Controller\Plugin\PaginationBuilder which is incompatible with the documented return type Zend\Http\Response|Zend\View\Model\ViewModel|array.

            'paginator' => ['Auth/User', 'as' => 'users'],
            'form' => [
                'Core/Search',
                [
                    'text_name' => 'text',
                    'text_placeholder' => /*@translate*/ 'Type name, email address, role, or login name',
                    'button_element' => 'text',
                ],
                'as' => 'form'
            ],
        ]);
    }

    /**
     * Edit user
     *
     * @return \Zend\Http\Response|ViewModel|array
     */
    public function editAction()
    {
        /* @var $user \Auth\Entity\User */
        $user = $this->userRepository->find($this->params('id'), \Doctrine\ODM\MongoDB\LockMode::NONE, null, ['allowDeactivated' => true]);
        
        // check if user is not found
        if (!$user) {

$user is of type Auth\Entity\User, thus it always evaluated to true.

            return $this->notFoundAction();
        }
        
        $params = $this->params();
        $forms = $this->formManager;
        /* @var $infoContainer \Auth\Form\UserProfileContainer */
        $infoContainer = $forms->get('Auth/UserProfileContainer');
        $infoContainer->setEntity($user);
        $statusContainer = $forms->get('Auth/UserStatusContainer');
        $statusContainer->setEntity($user);
        
        // set selected user to image strategy
        $imageStrategy = $infoContainer->getForm('info.image')
            ->getHydrator()

The method getHydrator() does not exist on Core\Form\Container.

            ->getStrategy('image');

The method getStrategy() does not exist on Zend\Hydrator\HydratorInterface. It seems like you code against a sub-type of Zend\Hydrator\HydratorInterface such as Zend\Hydrator\AbstractHydrator.

		$fileEntity = $imageStrategy->getFileEntity();
		$fileEntity->setUser($user);
		$imageStrategy->setFileEntity($fileEntity);
        
        if ($this->request->isPost()) {

The method isPost() does not exist on Zend\Stdlib\RequestInterface. It seems like you code against a sub-type of Zend\Stdlib\RequestInterface such as Zend\Http\Request.

            $formName = $params->fromQuery('form');
            $container = $formName === 'status' ? $statusContainer : $infoContainer;
            $form = $container->getForm($formName);
        
            if ($form) {
                $postData  = $form->getOption('use_post_array') ? $params->fromPost() : [];
                $filesData = $form->getOption('use_files_array') ? $params->fromFiles() : [];
                $form->setData(array_merge($postData, $filesData));

It seems like $filesData can also be of type ArrayAccess; however, parameter $array2 of array_merge() does only seem to accept array|null, maybe add an additional type check?

        
                if (!$form->isValid()) {
                    return new JsonModel(
                        array(
                            'valid' => false,
                            'errors' => $form->getMessages(),
                        )
                    );
                }
                
                $this->userRepository->store($user);
        
                if ('file-uri' === $params->fromPost('return')) {
                    $content = $form->getHydrator()->getLastUploadedFile()->getUri();

The method getLastUploadedFile() does not exist on Zend\Hydrator\HydratorInterface. It seems like you code against a sub-type of Zend\Hydrator\HydratorInterface such as Core\Entity\Hydrator\FileCollectionUploadHydrator.

                } else {
                    if ($form instanceof SummaryFormInterface) {
                        $form->setRenderMode(SummaryFormInterface::RENDER_SUMMARY);
                        $viewHelper = 'summaryForm';
                    } else {
                        $viewHelper = 'form';
                    }
                    $content = $this->viewHelper->get($viewHelper)->__invoke($form);
                }
        
                return new JsonModel(
                    array(
                        'valid' => $form->isValid(),
                        'content' => $content,
                    )
                );
            }
        }
        
        return [
            'infoContainer' => $infoContainer,
            'statusContainer' => $statusContainer
        ];
    }

    public function switchAction()
    {
        /* @var \Auth\Controller\Plugin\UserSwitcher $switcher */
        $do = $this->params()->fromQuery('do');
        if ('clear' == $do) {
            $switcher = $this->plugin('Auth/User/Switcher');
            $ref      = $switcher();
            $result   = ['success' => true];

            if (true !== $ref && $ref) {
                $result['ref'] = $ref;
            }

            return new JsonModel($result);
        }

        $this->acl('Auth/Users', 'admin-access');

The method acl() does not exist on Auth\Controller\UsersController. Since you implemented __call, consider adding a @method annotation.

        if ('list' == $do) {
            /* @var \Auth\Entity\User $user */
            /* @var \Zend\Paginator\Paginator $paginator */
            $paginator = $this->paginator('Auth/User', ['page' => 1]);

The method paginator() does not exist on Auth\Controller\UsersController. Since you implemented __call, consider adding a @method annotation.

            $result = [];

            foreach ($paginator as $user) {
                $result[] = [
                    'id' => $user->getId(),
                    'name' => $user->getInfo()->getDisplayName(false),
                    'email' => $user->getInfo()->getEmail(),
                    'login' => $user->getLogin()
                ];
            }
            return new JsonModel([
                'items' => $result,
                'total' => $paginator->getTotalItemCount(),
            ]);
        }

        $switcher = $this->plugin('Auth/User/Switcher');
        $success  = $switcher($this->params()->fromQuery('id'), [ 'ref' => urldecode($this->params()->fromQuery('ref')) ]);

The assignment to $success is dead and can be removed.

        return new JsonModel(['success' => true]);
    }
}