Organizations\Controller\IndexController::editAction()

Complexity

Conditions	20
Paths	46

Size

Total Lines	113
Code Lines	66

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	420

Importance

Changes	1
Bugs	1	Features	0

<?php
    public function editAction()
    {
        /* @var $request \Laminas\Http\Request */
        $translator      = $this->translator;
        $return          = null;
        $request         = $this->getRequest();
        $params          = $this->params();
        $formIdentifier  = $params->fromQuery('form');

        try {
            /* @var $handler \Organizations\Controller\Plugin\GetOrganizationHandler */
            $handler = $this->plugin('Organizations/GetOrganizationHandler');
            $org  = $handler->process($this->params(), true);
        } catch (MissingParentOrganizationException $e) {
            return $this->getErrorViewModel('no-parent');
        } catch (NotFoundException $e) {
            $this->getResponse()->setStatusCode(Response::STATUS_CODE_404);

The method setStatusCode() does not exist on Laminas\Stdlib\ResponseInterface. It seems like you code against a sub-type of Laminas\Stdlib\ResponseInterface such as Laminas\Http\Response.

            return [
                'message' => sprintf($translator->translate('Organization with id "%s" not found'), $e->getId()),
                'exception' => $e
            ];
        }

        $container       = $this->getFormular($org);

        if (isset($formIdentifier) && $request->isPost()) {

The method isPost() does not exist on Laminas\Stdlib\RequestInterface. It seems like you code against a sub-type of Laminas\Stdlib\RequestInterface such as Laminas\Http\Request.

            /* @var $form \Laminas\Form\FormInterface */
            $postData = $this->params()->fromPost();
            $filesData = $this->params()->fromFiles();
            /* due to issues in ZF2 we need to clear the employees collection in the entity,
             * prior to binding. Otherwise it is not possible to REMOVE an employee, as the
             * MultiCheckbox Validation will FAIL on empty values!
             */
            if ("employeesManagement" == $formIdentifier) {
                $markedEmps = array();
                // Check if no permissions are set, and set one, mark this employee and restore it afterwards.
                foreach ($postData['employees']['employees'] as &$empData) {
                    if (!isset($empData['permissions'])) {
                        $empData['permissions'][] = 16;
                        $markedEmps[] = $empData['user'];
                    }
                }
                $org->setEmployees(new ArrayCollection());
            }

            $organization = $container->getEntity();
            $form = $container->get($formIdentifier);
            $form->setData(array_merge($postData, $filesData));

The method setData() does not exist on Laminas\Form\ElementInterface. It seems like you code against a sub-type of Laminas\Form\ElementInterface such as Laminas\Form\FormInterface or Laminas\Form\Form or Core\Form\Container or Laminas\Form\Form.

It seems like $filesData can also be of type ArrayAccess and null; however, parameter $arrays of array_merge() does only seem to accept array, maybe add an additional type check?

            if (!isset($form)) {
                throw new \RuntimeException('No form found for "' . $formIdentifier . '"');
            }

            if('organizationLogo' == $formIdentifier){
                return $this->handleLogoUpload($form, $filesData);

It seems like $filesData can also be of type ArrayAccess and null; however, parameter $filesData of Organizations\Controller\IndexController::handleLogoUpload() does only seem to accept array, maybe add an additional type check?

            }

            $isValid = $form->isValid();

The method isValid() does not exist on Laminas\Form\ElementInterface. It seems like you code against a sub-type of Laminas\Form\ElementInterface such as Laminas\Form\FormInterface or Laminas\Form\Form or Core\Form\Container or Laminas\Form\Form.

            if ("employeesManagement" == $formIdentifier) {
                // remove permissions from marked employees
                foreach ($org->getEmployees() as $emp) {
                    $empId = $emp->getUser()->getId();
                    if (in_array($empId, $markedEmps)) {

The variable $markedEmps does not seem to be defined for all execution paths leading up to this point.

                        $emp->getPermissions()->revokeAll();
                    }
                }
            }

            if ($isValid) {
                $orgName = $org->getOrganizationName();
                if ($orgName && '' !== (string) $orgName->getName()) {
                    $org->setIsDraft(false);
                }
                $this->repository->store($org);
            }


            $this->repository->store($organization);

            if ('file-uri' === $this->params()->fromPost('return')) {
                /* @var $hydrator \Core\Entity\Hydrator\FileCollectionUploadHydrator
                 * @var $file     \Organizations\Entity\OrganizationImage */
                $basepath = $this->viewHelper->get('basepath');
                $hydrator = $form->getHydrator();

The method getHydrator() does not exist on Laminas\Form\ElementInterface. It seems like you code against a sub-type of Laminas\Form\ElementInterface such as Laminas\Form\FieldsetInterface or Laminas\Form\Fieldset.

                $file     = $hydrator->getLastUploadedFile();
                $content = $basepath($file->getUri());
            } else {
                if ($form instanceof SummaryForm) {
                    /* @var $form \Core\Form\SummaryForm */
                    $form->setRenderMode($isValid ? SummaryForm::RENDER_SUMMARY : SummaryForm::RENDER_FORM);
                    $viewHelper = 'summaryForm';
                } else {
                    $viewHelper = 'form';
                }

                $content = $this->viewHelper->get($viewHelper)->__invoke($form);
            }

            return new JsonModel(
                array(
                'valid' => $isValid,
                'errors' => $form->getMessages(),
                'content' => $content,
                )
            );
        }

        if (!isset($return)) {
            $return = array(
                'form' => $container
            );
        }
        return $return;
    }