cross-solution /
YAWIK
| Conditions | 23 |
| Paths | 1920 |
| Total Lines | 80 |
| Code Lines | 39 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 552 |
| Changes | 3 | ||
| Bugs | 1 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 71 | public function createQuery($params, $queryBuilder) |
||
| 72 | { |
||
| 73 | $this->value = $params; |
||
| 74 | |||
| 75 | if (isset($params['q'])) { |
||
| 76 | $params['search'] = $params['q']; |
||
| 77 | } |
||
| 78 | |||
| 79 | /* |
||
| 80 | * search jobs by keywords |
||
| 81 | */ |
||
| 82 | if (isset($params['search']) && !empty($params['search'])) { |
||
| 83 | $search = strtolower($params['search']); |
||
| 84 | //$expression = $queryBuilder->expr()->operator('$text', ['$search' => $search]); |
||
| 85 | //$queryBuilder->field(null)->equals($expression->getQuery()); |
||
| 86 | $queryBuilder->text($search); |
||
| 87 | } |
||
| 88 | if (isset($params['o']) && !empty($params['o'])) { |
||
| 89 | $queryBuilder->field('organization')->equals(new ObjectId($params['o'])); |
||
| 90 | // $queryBuilder->field('metaData.companyName')->equals(new \MongoRegex('/' . $params['o'] . '/i')); |
||
| 91 | } |
||
| 92 | |||
| 93 | if (isset($params['l'])) { |
||
| 94 | $coords = $params['l']->getCoordinates()->getCoordinates(); |
||
| 95 | $queryBuilder->field('locations.coordinates')->geoWithinCenter((float) $coords[0], (float) $coords[1], (float) $this->value['d']/100); |
||
| 96 | } |
||
| 97 | |||
| 98 | if (isset($params['channel']) && !empty($params['channel']) && $params['channel']!="default") { |
||
| 99 | $queryBuilder->field('portals')->equals($params['channel']); |
||
| 100 | } |
||
| 101 | |||
| 102 | $this->user = $this->auth->getUser(); |
||
|
introduced
by
|
|||
| 103 | $isRecruiter = $this->user->getRole() == User::ROLE_RECRUITER || $this->acl->inheritsRole($this->user, User::ROLE_RECRUITER); |
||
| 104 | |||
| 105 | if ($isRecruiter && (!isset($this->value['by']) || $this->value['by'] != 'guest')) { |
||
| 106 | /* |
||
| 107 | * a recruiter can see his jobs and jobs from users who gave permissions to do so |
||
| 108 | */ |
||
| 109 | if (isset($params['by']) && 'me' == $params['by']) { |
||
| 110 | $queryBuilder->addAnd( |
||
| 111 | $queryBuilder->expr() |
||
| 112 | ->addOr($queryBuilder->expr()->field('user')->equals($this->user->getId())) |
||
| 113 | ->addOr($queryBuilder->expr()->field('metaData.organizations:managers.id')->equals($this->user->getId())) |
||
| 114 | ); |
||
| 115 | } else { |
||
| 116 | $queryBuilder->field('permissions.view')->equals($this->user->getId()); |
||
| 117 | } |
||
| 118 | if ( |
||
| 119 | isset($params['status']) && |
||
| 120 | !empty($params['status']) && |
||
| 121 | $params['status'] != 'all' |
||
| 122 | ) { |
||
| 123 | $queryBuilder->field('status.name')->equals((string) $params['status']); |
||
| 124 | } |
||
| 125 | } else { |
||
| 126 | /* |
||
| 127 | * an applicants or guests can see all active jobs |
||
| 128 | * Active jobs are also jobs which are WAITING_FOR_APPROVAL, because the actual change is |
||
| 129 | * only in the snapshot. |
||
| 130 | */ |
||
| 131 | $queryBuilder->field('status.name')->in([Status::ACTIVE, Status::WAITING_FOR_APPROVAL]); |
||
| 132 | } |
||
| 133 | |||
| 134 | if (isset($params['publishedSince'])) { |
||
| 135 | $publishedSince = $params['publishedSince']; |
||
| 136 | |||
| 137 | if (!$publishedSince instanceof DateTime) { |
||
| 138 | $publishedSince = new DateTime($publishedSince); |
||
| 139 | } |
||
| 140 | |||
| 141 | $queryBuilder->field('datePublishStart.date')->gte($publishedSince); |
||
| 142 | } |
||
| 143 | |||
| 144 | if (isset($this->value['sort'])) { |
||
| 145 | foreach (explode(",", $this->value['sort']) as $sort) { |
||
| 146 | $queryBuilder->sort($this->filterSort($sort)); |
||
| 147 | } |
||
| 148 | } |
||
| 149 | |||
| 150 | return $queryBuilder; |
||
| 151 | } |
||
| 179 |
Loading history...