Jobs\Controller\ManageController::save()

Complexity

Conditions	24
Paths	5383

Size

Total Lines	179
Code Lines	110

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	600

Importance

Changes

0

<?php
    protected function save()
    {
		$formEvents = $this->jobFormEvents;
        $user               = $this->auth->getUser();
        if (empty($user->getInfo()->getEmail())) {
            return $this->getErrorViewModel('no-parent', array('cause' => 'noEmail'));
        }
        $userOrg            = $user->getOrganization();
        if (!$userOrg->hasAssociation() || $userOrg->getOrganization()->isDraft()) {

The method isDraft() does not exist on Organizations\Entity\OrganizationInterface. It seems like you code against a sub-type of Organizations\Entity\OrganizationInterface such as Organizations\Entity\Organization.

            return $this->getErrorViewModel('no-parent', array('cause' => 'noCompany'));
        }

        try {
            $jobEntity = $this->initializeJob()->get($this->params(), true, true);
        } catch (NotFoundException $e) {
            $this->getResponse()->setStatusCode(Response::STATUS_CODE_404);

The method setStatusCode() does not exist on Laminas\Stdlib\ResponseInterface. It seems like you code against a sub-type of Laminas\Stdlib\ResponseInterface such as Laminas\Http\Response.

            return [

The expression return array('message' => sprintf($this->translator->translate('Job with id "%s" not found'), $e->getId()), 'exception' => $e) returns the type array<string,Core\Entity\Exception\NotFoundException|string> which is incompatible with the documented return type Laminas\View\Model\ViewModel|null.

                'message' => sprintf($this->translator->translate('Job with id "%s" not found'), $e->getId()),
                'exception' => $e
            ];
        }


        /** @var \Laminas\Http\Request $request */
        $request            = $this->getRequest();
        $isAjax             = $request->isXmlHttpRequest();

        $params             = $this->params();
        $formIdentifier     = $params->fromQuery('form');

        if ('1' == $params->fromQuery('admin')) {
            /* @var \Auth\Controller\Plugin\UserSwitcher $switcher */
            $switcher = $this->plugin('Auth/User/Switcher');
            $switcher($jobEntity->getUser(), ['ref' => urldecode($params->fromQuery('return'))]);
        }


        $viewModel          = null;
        $this->acl($jobEntity, 'edit');

The call to Jobs\Controller\ManageController::acl() has too many arguments starting with $jobEntity.

        if ($status = $params->fromQuery('status')) {
            $this->changeStatus($jobEntity, $status);
        }

        $form               = $this->getFormular($jobEntity);

        $valid              = true;
        $instanceForm       = null;
        $formErrorMessages = array();

        if (isset($formIdentifier) &&  $request->isPost()) {
            // at this point the form get instantiated and immediately accumulated
            $instanceForm = $form->getForm($formIdentifier);
            if (!isset($instanceForm)) {
                throw new \RuntimeException('No form found for "' . $formIdentifier . '"');
            }
            // the id may be part of the postData, but it never should be altered
            $postData = $request->getPost();
            if (isset($postData['id'])) {
                unset($postData['id']);
            }
            unset($postData['applyId']);
            $instanceForm->setData($postData);
            $valid = $instanceForm->isValid();
            $formErrorMessages = ArrayUtils::merge($formErrorMessages, $instanceForm->getMessages());

It seems like $instanceForm->getMessages() can also be of type Traversable; however, parameter $b of Laminas\Stdlib\ArrayUtils::merge() does only seem to accept array, maybe add an additional type check?

            if ($valid) {
                /*
                 * @todo This is a workaround for GeoJSON data insertion
                 * until we figured out, what we really want it to be.
                 */
//                if ('general.locationForm' == $formIdentifier) {
//                    $locElem = $instanceForm->getBaseFieldset()->get('geo-location');
//                    if ($locElem instanceof \Geo\Form\GeoText) {
//                        $loc = $locElem->getValue('entity');
//                        $locations = $jobEntity->getLocations();
//                        if (count($locations)) {
//                            $locations->clear();
//                        }
//                        $locations->add($loc);
//                        $jobEntity->setLocation($locElem->getValue());
//                    }
//                }

                $title = $jobEntity->getTitle();
                $templateTitle = $jobEntity->getTemplateValues()->getTitle();

                if (empty($templateTitle)) {
                    $jobEntity->getTemplateValues()->setTitle($title);
                }
                $this->repositoryService->store($jobEntity);
            }
        }

        // validation
        $jobValid = true;
        $errorMessage = array();
        if (empty($jobEntity->getTitle())) {
            $jobValid = false;
            $errorMessage[] = $this->translator->translate('No Title');
        }
        if (!$jobEntity->getLocations()->count()) {
            $jobValid = false;
            $errorMessage[] = $this->translator->translate('No Location');
        }
        if (empty($jobEntity->getTermsAccepted())) {
            $jobValid = false;
            $errorMessage[] = $this->translator->translate('Accept the Terms');
        }
        $result = $formEvents->trigger('ValidateJob', $this, [ 'form' => $form ]);
        foreach ($result as $messages) {
            if (!$messages) {
                continue;
            }
            if (!is_array($messages)) {
                $messages = [ $messages ];
            }

            $errorMessage = array_merge($errorMessage, $messages);
            $jobValid = false;
        }

        $errorMessage = '<br />' . implode('<br />', $errorMessage);
        if ($isAjax) {
            if ($instanceForm instanceof SummaryForm) {
                $instanceForm->setRenderMode(SummaryForm::RENDER_SUMMARY);
                $viewHelper = 'summaryForm';
            } else {
                $viewHelper = 'form';
            }
            $viewHelperManager  = $this->viewHelper;
            $content = $viewHelperManager->get($viewHelper)->__invoke($instanceForm);
            $viewModel = new JsonModel(
                array(
                'content' => $content,
                'valid' => $valid,
                'jobvalid' => $jobValid,
                'errors' => $formErrorMessages,
                'errorMessage' => $errorMessage,
                'displayMode' => $this->params()->fromQuery('displayMode', 'summary'))
            );
        } else {
            if ($jobEntity->isDraft()) {
                $form->getForm('general.nameForm')->setDisplayMode(SummaryFormInterface::DISPLAY_FORM);

The method setDisplayMode() does not exist on Core\Form\Container.

The method setDisplayMode() does not exist on Laminas\Form\FormInterface. It seems like you code against a sub-type of Laminas\Form\FormInterface such as Core\Form\SummaryFormInterface or Core\Form\SummaryForm.

                $form->getForm('general.portalForm')->setDisplayMode(SummaryFormInterface::DISPLAY_FORM);
                $locElem = $form->getForm('general.locationForm')->setDisplayMode(SummaryFormInterface::DISPLAY_FORM)
                                ->getBaseFieldset()->get('geoLocation');
                if ($locElem instanceof \Geo\Form\GeoText) {

The type Geo\Form\GeoText was not found. Maybe you did not declare it correctly or list all dependencies?

                    $loc = $jobEntity->getLocations();
                    if (count($loc)) {
                        $locElem->setValue($loc->first());
                    }
                }
            } else {
                $formEvents->trigger('DisableElements', $this, [ 'form' => $form, 'job'=>$jobEntity ]);
                // Job is deployed, some changes are now disabled
                $form->enableAll();
            }


            $completionLink = $this->url()->fromRoute(
                'lang/jobs/completion',
                [ 'id' => $jobEntity->getId()]
            );

            $viewModel = $this->getViewModel($form);

            $viewModel->setVariables(
                array(
                'completionLink' => $completionLink,
                'title' => $jobEntity->getTitle(),
                'job' => $jobEntity,
                'summary' => 'this is what we charge you for your offer...',
                'valid' => $valid,
                'jobvalid' => $jobValid,
                'errorMessage' => $errorMessage,
                'isDraft' => $jobEntity->isDraft()
                )
            );
        }
        return $viewModel;
    }