cross-solution /
YAWIK
| Conditions | 22 |
| Paths | 1845 |
| Total Lines | 105 |
| Code Lines | 65 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 0 |
| CRAP Score | 506 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 25 | public function render(ElementInterface $element, $labelPosition = null) |
||
| 26 | { |
||
| 27 | $escapeHtmlHelper = $this->getEscapeHtmlHelper(); |
||
| 28 | $labelHelper = $this->getLabelHelper(); |
||
| 29 | $elementHelper = $this->getElementHelper(); |
||
| 30 | $elementErrorsHelper = $this->getElementErrorsHelper(); |
||
| 31 | |||
| 32 | $label = $element->getLabel(); |
||
| 33 | $inputErrorClass = $this->getInputErrorClass(); |
||
| 34 | |||
| 35 | if (isset($label) && '' !== $label) { |
||
| 36 | // Translate the label |
||
| 37 | if (null !== ($translator = $this->getTranslator())) { |
||
| 38 | $label = $translator->translate( |
||
| 39 | $label, |
||
| 40 | $this->getTranslatorTextDomain() |
||
| 41 | ); |
||
| 42 | } |
||
| 43 | } |
||
| 44 | |||
| 45 | // Does this element have errors ? |
||
| 46 | if (count($element->getMessages()) > 0 && !empty($inputErrorClass)) { |
||
|
Bug
introduced
by
|
|||
| 47 | $classAttributes = ($element->hasAttribute('class') ? $element->getAttribute('class') . ' ' : ''); |
||
| 48 | $classAttributes = $classAttributes . $inputErrorClass; |
||
| 49 | |||
| 50 | $element->setAttribute('class', $classAttributes); |
||
| 51 | } |
||
| 52 | |||
| 53 | if ($this->partial) { |
||
| 54 | $vars = array( |
||
| 55 | 'element' => $element, |
||
| 56 | 'label' => $label, |
||
| 57 | 'labelAttributes' => $this->labelAttributes, |
||
| 58 | 'labelPosition' => $this->labelPosition, |
||
| 59 | 'renderErrors' => $this->renderErrors, |
||
| 60 | ); |
||
| 61 | |||
| 62 | return $this->view->render($this->partial, $vars); |
||
| 63 | } |
||
| 64 | |||
| 65 | if ($this->renderErrors) { |
||
| 66 | $elementErrors = $elementErrorsHelper->render($element); |
||
| 67 | } |
||
| 68 | |||
| 69 | $elementString = $elementHelper->render($element); |
||
| 70 | |||
| 71 | if (isset($label) && '' !== $label) { |
||
| 72 | $label = $escapeHtmlHelper($label); |
||
| 73 | $labelAttributes = $element->getLabelAttributes(); |
||
| 74 | |||
| 75 | if (empty($labelAttributes)) { |
||
| 76 | $labelAttributes = $this->labelAttributes; |
||
| 77 | } |
||
| 78 | |||
| 79 | // Multicheckbox elements have to be handled differently as the HTML standard does not allow nested |
||
| 80 | // labels. The semantic way is to group them inside a fieldset |
||
| 81 | $type = $element->getAttribute('type'); |
||
| 82 | if ($type === 'multi_checkbox' || $type === 'radio') { |
||
| 83 | $markup = sprintf( |
||
| 84 | '<fieldset><legend>%s</legend>%s</fieldset>', |
||
| 85 | $label, |
||
| 86 | $elementString |
||
| 87 | ); |
||
| 88 | } else { |
||
| 89 | if ($element->hasAttribute('id')) { |
||
| 90 | $labelOpen = ''; |
||
| 91 | $labelClose = ''; |
||
| 92 | $label = $labelHelper($element); |
||
| 93 | } else { |
||
| 94 | $labelOpen = $labelHelper->openTag($labelAttributes); |
||
| 95 | $labelClose = $labelHelper->closeTag(); |
||
| 96 | } |
||
| 97 | |||
| 98 | if ($label !== '' && !$element->hasAttribute('id')) { |
||
| 99 | $label = '<span>' . $label . '</span>'; |
||
| 100 | } |
||
| 101 | |||
| 102 | // Button element is a special case, because label is always rendered inside it |
||
| 103 | if ($element instanceof Button) { |
||
| 104 | $labelOpen = $labelClose = $label = ''; |
||
| 105 | } |
||
| 106 | |||
| 107 | switch ($this->labelPosition) { |
||
| 108 | case self::LABEL_PREPEND: |
||
| 109 | $markup = $labelOpen . $label . $elementString . $labelClose; |
||
| 110 | break; |
||
| 111 | case self::LABEL_APPEND: |
||
| 112 | default: |
||
| 113 | $markup = $labelOpen . $elementString . $label . $labelClose; |
||
| 114 | break; |
||
| 115 | } |
||
| 116 | } |
||
| 117 | |||
| 118 | if ($this->renderErrors) { |
||
| 119 | $markup .= $elementErrors; |
||
| 120 | } |
||
| 121 | } else { |
||
| 122 | if (!empty($this->renderErrors)) { |
||
| 123 | $markup = $elementString . $elementErrors; |
||
| 124 | } else { |
||
| 125 | $markup = $elementString; |
||
| 126 | } |
||
| 127 | } |
||
| 128 | |||
| 129 | return $markup; |
||
| 130 | } |
||
| 152 |
Loading history...