cross-solution /
YAWIK
| Conditions | 26 |
| Paths | 1673 |
| Total Lines | 158 |
| Code Lines | 98 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 56 |
| CRAP Score | 56.5769 |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 44 | 4 | public function render(ElementInterface $element, $useViewPartial = false) |
|
| 45 | { |
||
| 46 | /* @var $renderer \Laminas\View\Renderer\PhpRenderer */ |
||
| 47 | 4 | $renderer = $this->getView(); |
|
| 48 | 4 | if (!method_exists($renderer, 'plugin')) { |
|
| 49 | // Bail early if renderer is not pluggable |
||
| 50 | return ''; |
||
| 51 | } |
||
| 52 | |||
| 53 | /* @var $elementHelper \Laminas\Form\View\Helper\FormRow */ |
||
| 54 | 4 | $markup = ''; |
|
| 55 | 4 | $templateMarkup = ''; |
|
| 56 | 4 | $escapeHtmlHelper = $this->getEscapeHtmlHelper(); |
|
| 57 | 4 | $elementHelper = $this->getElementHelper(); |
|
| 58 | 4 | $fieldsetHelper = $this->getFieldsetHelper(); |
|
| 59 | |||
| 60 | 4 | $isCollectionElement = $element instanceof CollectionElement; |
|
| 61 | /* @var $element ElementInterface|CollectionElement */ |
||
| 62 | 4 | if ($isCollectionElement && $element->shouldCreateTemplate()) { |
|
| 63 | $this->isWithinCollection = true; |
||
| 64 | $templateMarkup = $this->renderTemplate($element); |
||
| 65 | $this->isWithinCollection = false; |
||
| 66 | } |
||
| 67 | |||
| 68 | 4 | $elementId = $element->getAttribute('id'); |
|
| 69 | 4 | if (!$elementId) { |
|
| 70 | $elementId = preg_replace( |
||
| 71 | array('~[^A-Za-z0-9_-]~', '~--+~', '~^-|-$~'), |
||
| 72 | array('-' , '-' , '' ), |
||
| 73 | $element->getName() |
||
| 74 | ); |
||
| 75 | } |
||
| 76 | 4 | if ($formId = $element->getOption('__form_id__')) { |
|
| 77 | 4 | $elementId = "$formId-$elementId"; |
|
| 78 | } |
||
| 79 | |||
| 80 | 4 | $element->setAttribute('id', $elementId); |
|
| 81 | |||
| 82 | /* |
||
| 83 | * We had the problem, that collection templates were not rendered using the viewPartial due to the call |
||
| 84 | * to this function from the parent class, which does not provide the $useViewPartial variable. |
||
| 85 | * Currently this is fixed by always using the view partial if $this->isWithinCollection is true. |
||
| 86 | * |
||
| 87 | * We should consider using a new property $this->useViewPartial, for cover the case, where the |
||
| 88 | * template should NOT be rendered using the view partial. |
||
| 89 | * |
||
| 90 | */ |
||
| 91 | 4 | if ($element instanceof ViewPartialProviderInterface && ($this->isWithinCollection || $useViewPartial)) { |
|
| 92 | /* @var $partial \Laminas\View\Helper\Partial */ |
||
| 93 | $partial = $renderer->plugin('partial'); |
||
| 94 | return $partial( |
||
| 95 | $element->getViewPartial(), |
||
| 96 | array('element' => $element) |
||
| 97 | ); |
||
| 98 | } |
||
| 99 | |||
| 100 | 4 | foreach ($element->getIterator() as $elementOrFieldset) { |
|
|
Bug
introduced
by
|
|||
| 101 | /* @var $elementOrFieldset ElementInterface|ViewPartialProviderInterface|ViewHelperProviderInterface */ |
||
| 102 | 4 | if ($elementOrFieldset instanceof ViewPartialProviderInterface) { |
|
| 103 | 1 | $elementOrFieldsetId = $elementOrFieldset->getAttribute('id'); |
|
| 104 | 1 | if (!$elementOrFieldsetId) { |
|
| 105 | 1 | $elementOrFieldsetId = preg_replace( |
|
| 106 | 1 | array('~[^A-Za-z0-9_-]~', '~--+~', '~^-|-$~'), |
|
| 107 | 1 | array('-' , '-' , '' ), |
|
| 108 | 1 | $elementOrFieldset->getName() |
|
| 109 | ); |
||
| 110 | } |
||
| 111 | 1 | if ($formId) { |
|
| 112 | 1 | $elementOrFieldsetId = "$formId-$elementOrFieldsetId"; |
|
| 113 | } |
||
| 114 | 1 | $elementOrFieldset->setAttribute('id', $elementOrFieldsetId); |
|
| 115 | /* @var $partial \Laminas\View\Helper\Partial */ |
||
| 116 | 1 | $partial = $renderer->plugin('partial'); |
|
| 117 | 1 | $markup .= $partial( |
|
| 118 | 1 | $elementOrFieldset->getViewPartial(), |
|
| 119 | 1 | array('element' => $elementOrFieldset) |
|
| 120 | ); |
||
| 121 | 3 | } elseif ($elementOrFieldset instanceof FieldsetInterface) { |
|
| 122 | if ($isCollectionElement) { |
||
| 123 | $this->isWithinCollection = true; |
||
| 124 | } |
||
| 125 | if ($elementOrFieldset instanceof ViewHelperProviderInterface) { |
||
| 126 | $helper = $elementOrFieldset->getViewHelper(); |
||
| 127 | if (is_string($helper)) { |
||
| 128 | $helper = $renderer->plugin($helper); |
||
| 129 | } |
||
| 130 | $markup .= $helper($element); |
||
| 131 | } else { |
||
| 132 | $markup .= $fieldsetHelper($elementOrFieldset); |
||
| 133 | } |
||
| 134 | $this->isWithinCollection = false; |
||
| 135 | 3 | } elseif (false !== $elementOrFieldset->getOption('use_formrow_helper')) { |
|
| 136 | 3 | $markup .= $elementHelper($elementOrFieldset, null, null, $this->layout); |
|
| 137 | } else { |
||
| 138 | /* @var $formElement \Laminas\Form\View\Helper\FormElement */ |
||
| 139 | $formElement = $renderer->plugin('formelement'); |
||
| 140 | $formElement->render($elementOrFieldset); |
||
| 141 | } |
||
| 142 | } |
||
| 143 | |||
| 144 | // If $templateMarkup is not empty, use it for simplify adding new element in JavaScript |
||
| 145 | 4 | if (!empty($templateMarkup)) { |
|
| 146 | $markup .= $templateMarkup; |
||
| 147 | } |
||
| 148 | |||
| 149 | |||
| 150 | // Every collection is wrapped by a fieldset if needed |
||
| 151 | 4 | if ($this->shouldWrap) { |
|
| 152 | 4 | if ($this->isWithinCollection) { |
|
| 153 | $attrStr = $this->createAttributesString($element->getAttributes()); |
||
| 154 | $markup = sprintf('<fieldset %s><a class="remove-item yk-form-remove"><i class="yk-icon yk-icon-minus"></i></a>%s</fieldset>', $attrStr, $markup); |
||
| 155 | } else { |
||
| 156 | 4 | $label = $element->getLabel(); |
|
| 157 | |||
| 158 | 4 | if (empty($label) && $element->getOption('renderFieldset')) { |
|
| 159 | 3 | $attrStr = $this->createAttributesString($element->getAttributes()); |
|
| 160 | 3 | $markup = sprintf( |
|
| 161 | 3 | '<fieldset %s><div class="fieldset-content">%s</div></fieldset>', |
|
| 162 | $attrStr, |
||
| 163 | $markup |
||
| 164 | ); |
||
| 165 | 1 | } elseif (!empty($label)) { |
|
| 166 | 1 | if (null !== ($translator = $this->getTranslator())) { |
|
| 167 | 1 | $label = $translator->translate( |
|
| 168 | 1 | $label, |
|
| 169 | 1 | $this->getTranslatorTextDomain() |
|
| 170 | ); |
||
| 171 | } |
||
| 172 | |||
| 173 | 1 | $label = $escapeHtmlHelper($label); |
|
| 174 | |||
| 175 | 1 | if ($isCollectionElement) { |
|
| 176 | $extraLegend = '<a href="#" class="add-item yk-form-add"><i class="yk-icon yk-icon-plus"></i></a>'; |
||
| 177 | $class = $element->getAttribute('class'); |
||
| 178 | $class .= " form-collection"; |
||
| 179 | $element->setAttribute('class', $class); |
||
| 180 | $divWrapperOpen = $divWrapperClose = ''; |
||
| 181 | } else { |
||
| 182 | 1 | $extraLegend = $class = ''; |
|
| 183 | 1 | $divWrapperOpen = '<div class="fieldset-content">'; |
|
| 184 | 1 | $divWrapperClose = '</div>'; |
|
| 185 | } |
||
| 186 | 1 | $attrStr = $this->createAttributesString($element->getAttributes()); |
|
| 187 | |||
| 188 | 1 | $markup = sprintf( |
|
| 189 | 1 | '<fieldset %s><legend>%s%s</legend>%s%s%s</fieldset>', |
|
| 190 | $attrStr, |
||
| 191 | $label, |
||
| 192 | $extraLegend, |
||
| 193 | $divWrapperOpen, |
||
| 194 | $markup, |
||
| 195 | $divWrapperClose |
||
| 196 | ); |
||
| 197 | } |
||
| 198 | } |
||
| 199 | } |
||
| 200 | |||
| 201 | 4 | return $markup; |
|
| 202 | } |
||
| 204 |
Loading history...