Cronfig\Sysinfo\System

Complexity

Total Complexity

6

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	registerOs()	0	10	3
A	getOs()	0	3	1
A	__construct()	0	11	2

<?php
/**
 * @package     Cronfig Sysinfo Library
 * @link        https://github.com/cronfig/sysinfo
 * @license     http://opensource.org/licenses/MIT
 */

namespace Cronfig\Sysinfo;

use Cronfig\Sysinfo\Linux;
use Cronfig\Sysinfo\Mac;

/**
 * Class System
 */
class System
{
    public function __construct($customs = [])
    {
        $defaults = [
            Linux::class,
            Mac::class,
        ];

        $osToRegister = array_merge($defaults, $customs);

        foreach ($osToRegister as $os) {
            $this->registerOs($os);
        }
    }

    public function registerOs(array $classNames)
    {
        foreach ($classNames as $className) {
            $os = new $className;

            if ($os->inUse()) {
                $this->os = $os;

The property os does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

                // The OS has been found, no need to iterate anymore
                break;
            }
        }
    }

    public function getOs()
    {
        return $this->os;
    }
}