PhpColConfig::addProperties() - Code Metrics - Inspection of "clean up" - crocodic-studio/crudbooster - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( a5762d...03970c )

by Iman

created 2018-04-13 17:08 UTC

PhpColConfig::addProperties() B

↳ Parent: PhpColConfig

Complexity

Conditions	5
Paths	16

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
eloc	9
nc	16
nop	5
dl	0
loc	16
rs	8.8571
c	0
b	0
f	0

<?php

namespace crocodicstudio\crudbooster\Modules\ModuleGenerator;

class PhpColConfig
{
    /**
     * @return array
     */
    public static function makeColumnPhpCode()
    {
        $labels = request('column');
        $name = request('name');
        $isImage = request('is_image');
        $isDownload = request('is_download');
        $callback = request('callback');
        $width = request('width');

        $indent = str_repeat(' ', 8);

        $columnScript = [];
        $columnScript[] = $indent.'$this->col[] = [];';
        foreach ($labels as $i => $label) {

            if (! $name[$i]) {
                continue;
            }

            $colProperties = ["'label' => '$label'", "'name' => '{$name[$i]}'"];
            $colProperties = self::addProperties($colProperties, $isImage[$i], $isDownload[$i], $callback[$i], $width[$i]);

            $columnScript[] = $indent.'$this->col[] = ['.implode(", ", $colProperties).'];';
        }
        return implode("\n", $columnScript);

    }

    /**
     * @param $colProperties
     * @param $isImage
     * @param $isDownload
     * @param $callback
     * @param $width
     * @return array
     */
    private static function addProperties($colProperties, $isImage, $isDownload, $callback, $width)
    {
        if ($isImage) {
            $colProperties[] = '"image" => true ';
        }
        if ($isDownload) {
            $colProperties[] = '"download" => true';
        }
        if ($callback) {
            $colProperties[] = '"callback" => function($row) {'.$callback.'}';
        }
        if ($width) {
            $colProperties[] = "'width' => '$width'";
        }

        return $colProperties;
    }
}

1			<?php
2
3			namespace crocodicstudio\crudbooster\Modules\ModuleGenerator;
4
5			class PhpColConfig
6			{
7			/**
8			* @return array
9			*/
10			public static function makeColumnPhpCode()
11			{
12			$labels = request('column');
13			$name = request('name');
14			$isImage = request('is_image');
15			$isDownload = request('is_download');
16			$callback = request('callback');
17			$width = request('width');
18
19			$indent = str_repeat(' ', 8);
20
21			$columnScript = [];
22			$columnScript[] = $indent.'$this->col[] = [];';
23			foreach ($labels as $i => $label) {
24
25			if (! $name[$i]) {
26			continue;
27			}
28
29			$colProperties = ["'label' => '$label'", "'name' => '{$name[$i]}'"];
30			$colProperties = self::addProperties($colProperties, $isImage[$i], $isDownload[$i], $callback[$i], $width[$i]);
31
32			$columnScript[] = $indent.'$this->col[] = ['.implode(", ", $colProperties).'];';
33			}
34			return implode("\n", $columnScript);
			0 ignored issues – show Bug Best Practice introduced 2018-03-25 16:05 UTC by Report Bug Copy Issue Report The expression `return implode(' ', $columnScript)` returns the type `string` which is incompatible with the documented return type `array`. Loading history...
35			}
36
37			/**
38			* @param $colProperties
39			* @param $isImage
40			* @param $isDownload
41			* @param $callback
42			* @param $width
43			* @return array
44			*/
45			private static function addProperties($colProperties, $isImage, $isDownload, $callback, $width)
46			{
47			if ($isImage) {
48			$colProperties[] = '"image" => true ';
49			}
50			if ($isDownload) {
51			$colProperties[] = '"download" => true';
52			}
53			if ($callback) {
54			$colProperties[] = '"callback" => function($row) {'.$callback.'}';
55			}
56			if ($width) {
57			$colProperties[] = "'width' => '$width'";
58			}
59
60			return $colProperties;
61			}
62			}

crocodic-studio / crudbooster

Push — master ( a5762d...03970c )

PhpColConfig::addProperties() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like