crocodicstudio\crudbooster\CBCoreModule\Index\Order

Complexity

Total Complexity

9

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	normalizeOrderBy()	0	9	2
A	__construct()	0	3	1
A	orderRows()	0	7	3
A	handle()	0	12	3

<?php

namespace crocodicstudio\crudbooster\CBCoreModule\Index;

class Order
{
    /**
     * Order constructor.
     *
     * @param $ctrl
     */
    public function __construct($ctrl)
    {
        $this->ctrl = $ctrl;

The property ctrl does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * @param $result
     * @param $table
     * @param $index
     */
    function handle($result, $table)

It is generally recommended to explicitly declare the visibility for methods.

    {
        $orderby = $this->ctrl->orderby;
        if (! $orderby) {
            $result->orderby($table.'.'.$this->ctrl->primary_key, 'desc');
            return;
        }
        if (is_string($orderby)) {
            $orderby = $this->normalizeOrderBy($orderby);
        }

        $this->orderRows($result, $table, $orderby);
    }

    /**
     * @param $result
     * @param $table
     * @param $orderby
     */
    private function orderRows($result, $table, $orderby)
    {
        foreach ($orderby as $key => $value) {
            if (strpos($key, '.')) {
                $table = explode(".", $key)[0];
            }
            $result->orderby($table.'.'.$key, $value);
        }
    }

    /**
     * @param $orderby
     * @return array
     */
    private function normalizeOrderBy($orderby)
    {
        $x = [];
        foreach (explode(";", $orderby) as $by) {
            $by = explode(",", $by);
            $x[$by[0]] = $by[1];
        }

        return $x;
    }
}