crocodicstudio\crudbooster\Modules\AuthModule\AuthController

Complexity

Total Complexity

11

Size/Duplication

Total Lines	77
Duplicated Lines	0 %

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	table()	0	4	2
A	__construct()	0	3	1
A	getForgot()	0	7	2
A	getLogin()	0	7	2
A	postForgot()	0	15	1
A	validateForgotPass()	0	7	2
A	getLogout()	0	6	1

<?php

namespace crocodicstudio\crudbooster\Modules\AuthModule;

use crocodicstudio\crudbooster\CBCoreModule\CbUsersRepo;
use crocodicstudio\crudbooster\controllers\Controller;
use crocodicstudio\crudbooster\helpers\Mailer;
use Illuminate\Support\Facades\Request;
use Illuminate\Support\Facades\Session;
use Illuminate\Support\Facades\Validator;
use crocodicstudio\crudbooster\helpers\CRUDBooster, CB;

The type CB was not found. Maybe you did not declare it correctly or list all dependencies?

class AuthController extends Controller
{
    /**
     * @var \crocodicstudio\crudbooster\CBCoreModule\CbUsersRepo
     */
    private $usersRepo;

    /**
     * AuthController constructor.
     *
     * @param \crocodicstudio\crudbooster\CBCoreModule\CbUsersRepo $usersRepo
     */
    public function __construct(CbUsersRepo $usersRepo)
    {
        $this->usersRepo = $usersRepo;
    }

    /**
     * @param string $tableName
     * @return mixed
     */
    public function table($tableName = null)
    {
        $tableName = $tableName ?: $this->table;

The property table does not exist on crocodicstudio\crudbooster\Modules\AuthModule\AuthController. Did you maybe forget to declare it?

        return \DB::table($tableName);
    }

    public function getLogin()
    {
        if (auth('cbAdmin')->id()) {

The expression auth('cbAdmin')->id() of type null|integer is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

            return redirect(cbAdminPath());
        }

        return view('CbAuth::login');
    }

    public function getForgot()
    {
        if (auth('cbAdmin')->id()) {

The expression auth('cbAdmin')->id() of type null|integer is loosely compared to true; this is ambiguous if the integer can be 0. You might want to explicitly use !== null instead.

            return redirect()->route('CbDashboard');
        }

        return view('CbAuth::forgot');
    }

    public function postForgot()
    {
        $this->validateForgotPass();

        $randString = str_random(5);
        $this->usersRepo->updateByMail(request('email'), ['password' => \Hash::make($randString)]);

        //$appname = cbGetsetting('appname');
        $user = $this->usersRepo->findByMail(request('email'));
        $user->password = $randString;
        (new Mailer())->send(['to' => $user->email, 'data' => $user, 'template' => 'forgot_password_backend']);

        CRUDBooster::insertLog(trans('crudbooster_logging.log_forgot', ['email' => request('email'), 'ip' => Request::server('REMOTE_ADDR')]));

        return redirect()->route('getLogin')->with('message', cbTrans('message_forgot_password'));
    }

    public function getLogout()
    {
        CRUDBooster::insertLog(trans('crudbooster_logging.log_logout', ['email' => auth('cbAdmin')->user()->email]));

Accessing email on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        auth('cbAdmin')->logout();

        return redirect()->route('getLogin')->with('message', cbTrans('message_after_logout'));
    }

    private function validateForgotPass()
    {
        $validator = Validator::make(request()->all(), ['email' => 'required|email|exists:cms_users',]);

        if ($validator->fails()) {
            $message = $validator->errors()->all();
            backWithMsg(implode(', ', $message), 'danger');
        }
    }
}