Crocodicstudio\Crudbooster\controllers\CBController\ImportData

Complexity

Total Complexity

9

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	getImportData()	0	34	6
A	postDoImportChunk()	0	13	3

<?php

namespace Crocodicstudio\Crudbooster\controllers\CBController;

use Crocodicstudio\Crudbooster\controllers\Helpers\IndexImport;
use Illuminate\Support\Facades\DB;
use Maatwebsite\Excel\Facades\Excel;
use Illuminate\Support\Facades\Route;

trait ImportData
{
    public function getImportData()
    {
        $this->genericLoader();

It seems like genericLoader() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $data = [];
        $data['page_menu'] = Route::getCurrentRoute()->getActionName();
        $data['page_title'] = 'Import Data '.CRUDBooster::getCurrentModule()->name;

The type Crocodicstudio\Crudbooster\controllers\CBController\CRUDBooster was not found. Maybe you did not declare it correctly or list all dependencies?

        if (! request('file') || request('import')) {
            return $this->cbView('crudbooster::import', $data);

It seems like cbView() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        }

        $file = 'storage'.DIRECTORY_SEPARATOR.'app'.DIRECTORY_SEPARATOR.base64_decode(request('file'));

It seems like request('file') can also be of type array; however, parameter $data of base64_decode() does only seem to accept string, maybe add an additional type check?

        $rows = Excel::load($file, function ($reader) {

The parameter $reader is not used and could be removed.

        })->get();

        session()->put('total_data_import', count($rows));

        $import_column = [];
        foreach ($rows as $value) {
            $a = [];
            foreach ($value as $k => $v) {
                $a[] = $k;
            }
            if (count($a)) {
                $import_column = $a;
            }
            break;
        }

        $data['table_columns'] = DB::getSchemaBuilder()->getColumnListing($this->table);
        $data['data_import_column'] = $import_column;

        return $this->cbView('crudbooster::import', $data);
    }

    public function postDoImportChunk()
    {
        $import = app(IndexImport::class);
        $this->genericLoader();
        $fileMD5 = md5(request('file'));

It seems like request('file') can also be of type array; however, parameter $str of md5() does only seem to accept string, maybe add an additional type check?

        if (request('file') && request('resume') == 1) {
            return $import->handleImportProgress($fileMD5);

Are you sure the usage of $import->handleImportProgress($fileMD5) targeting Crocodicstudio\Crudbooster\controllers\Helpers\IndexImport::handleImportProgress() seems to always return null.

        }

        $import->InsertToDB($fileMD5, $this->table, $this->titleField);

        return response()->json(['status' => true]);

The method json() does not exist on Symfony\Component\HttpFoundation\Response. It seems like you code against a sub-type of Symfony\Component\HttpFoundation\Response such as Illuminate\Http\Response or Illuminate\Http\JsonResponse or Illuminate\Http\RedirectResponse.

Are you sure the usage of response()->json(array('status' => true)) targeting ImanGhafoori\Terminator\Responder::json() seems to always return null.

    }


}