Crocodicstudio\Crudbooster\controllers\CBController\Deleter

Complexity

Total Complexity

10

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	_redirectBackWithMsg()	0	12	4
A	getDeleteImage()	0	16	1
A	postActionSelected()	0	14	3
A	getDelete()	0	6	2

<?php

namespace Crocodicstudio\Crudbooster\controllers\CBController;

use Crocodicstudio\Crudbooster\CBCoreModule\DataRemover;
use Illuminate\Support\Facades\Request;
use Illuminate\Support\Facades\Storage;
use Crocodicstudio\Crudbooster\helpers\CRUDBooster;

trait Deleter
{
    public function getDelete($id)
    {
        $this->genericLoader();

It seems like genericLoader() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        (new DataRemover($this))->doDeleteWithHook([$id]);
        $url = request('return_url') ?: Request::server('HTTP_REFERER');
        CRUDBooster::redirect($url, cbTrans('alert_delete_data_success'), 'success');
    }

    public function postActionSelected()
    {
        $this->genericLoader();
        $selectedIds = request('checkbox');
        $btnName = request('button_name');
        if (! $selectedIds) {
            backWithMsg(cbTrans('at_least_one_row'), 'warning');
        }
        if ($btnName == 'delete') {
            (new DataRemover($this))->doDeleteWithHook($selectedIds);
            backWithMsg(cbTrans('alert_delete_selected_success'));
        }

        return $this->_redirectBackWithMsg($btnName, $selectedIds);

Are you sure the usage of $this->_redirectBackWithMsg($btnName, $selectedIds) targeting Crocodicstudio\Crudbooster\controllers\CBController\Deleter::_redirectBackWithMsg() seems to always return null.

    }

    /**
     * @param $button_name
     * @param $id_selected
     * @return null
     */
    private function _redirectBackWithMsg($button_name, $id_selected)
    {
        $action = ucwords(str_replace(['-', '_'], ' ', $button_name));
        $type = 'success';
        $message = cbTrans('alert_action', ['action' => $action]);

        if ($this->actionButtonSelected($id_selected, $button_name) === false) {

It seems like actionButtonSelected() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $message = ! empty($this->alert['message']) ? $this->alert['message'] : 'Error';
            $type = ! empty($this->alert['type']) ? $this->alert['type'] : 'danger';
        }

        backWithMsg($message, $type);
    }

    public function getDeleteImage()
    {
        $this->genericLoader();
        $id = (int) request('id');
        $column = request('column');

        $row = $this->findRow($id)->first();

It seems like findRow() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $file = $row->{$column};

        Storage::delete($file);

        $this->findRow($id)->update([$column => null]);

        event('cb.imageDeleted', [$this->table, compact('id', 'column', 'file'), YmdHis(), cbUser()]);

        backWithMsg(cbTrans('alert_delete_data_success'));
    }
}