crocodicstudio\crudbooster\controllers\SubModuleController::getSubModule()

Complexity

Conditions	5
Paths	4

Size

Total Lines	21
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function getSubModule($subModuleKey) {
        if(!module()->canBrowse()) return cb()->redirect(cb()->getAdminUrl(),cbLang("you_dont_have_privilege_to_this_area"));
        if(!verifyReferalUrl()) return cb()->redirect(module()->url(),"It looks like your url is incorrect");

        if($subModule = Cache::get("subModule".$subModuleKey)) {
            $foreignKey = $subModule['foreignKey'];
            $foreignValue = $subModule['foreignValue'];

            $query = $this->repository();

It seems like repository() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $query->where($foreignKey, $foreignValue);
            $result = $query->paginate( request("limit")?:cbConfig("LIMIT_TABLE_DATA") );
            $data['result'] = $result;

$data was never initialized. Although not strictly required by PHP, it is generally a good practice to add $data = array(); before regardless.

            $data['additionalHeaderTitle'] = $subModule['parentTitle'];
            $data['additionalHeaderContent'] = $subModule['info'];
            $data['subModuleKey'] = $subModuleKey;

            return view("crudbooster::module.index.index", array_merge($data, $this->data));
        }

        return cb()->redirect(module()->url(),"It looks like your url is incorrect");
    }
}