crocodicstudio\crudbooster\controllers\traits\ColumnIntervention

Complexity

Total Complexity

4

Size/Duplication

Total Lines	17
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	columnIntervention()	0	11	4

<?php
/**
 * Created by PhpStorm.
 * User: User
 * Date: 8/15/2019
 * Time: 11:48 PM
 */

namespace crocodicstudio\crudbooster\controllers\traits;

use Illuminate\Support\Facades\Cache;

trait ColumnIntervention
{
    /**
     * ColumnIntervention method is to make additional custom column.
     * We can change the user column after cbInit() called.
     */
    public function columnIntervention()
    {
        if(request("sub_module") && Cache::has("subModule".request("sub_module")) && cb()->getCurrentMethod() != "getDetail") {

Are you sure request('sub_module') of type Illuminate\Http\Request|array|string can be used in concatenation?

            /*
             * If there is sub module, the column that has same name with foreign key should be remove
             * And change to hidden. So we can save the foreign Key id from the parent module.
             */
            $subModule = Cache::get("subModule".request("sub_module"));
            $this->removeColumn($subModule["foreignKey"])

It seems like removeColumn() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                ->addHidden($subModule["foreignKey"],$subModule['foreignKey'])
                ->defaultValue($subModule['foreignValue']);
        }
    }

}