crocodicstudio\crudbooster\controllers\DeveloperModulesController::postEditSave()

Complexity

Conditions	2
Paths	4

Size

Total Lines	10
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	DeveloperModulesController::getDeleteSoft()	0	5	1

<?php
/**
 * Created by PhpStorm.
 * User: User
 * Date: 4/25/2019
 * Time: 9:28 PM
 */

namespace crocodicstudio\crudbooster\controllers;

use crocodicstudio\crudbooster\exceptions\CBValidationException;
use crocodicstudio\crudbooster\helpers\ModuleGenerator;
use Illuminate\Support\Facades\Artisan;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Schema;
use Illuminate\Support\Str;
use Illuminate\Support\Facades\Cache;
use Symfony\Component\Process\Process;

class DeveloperModulesController extends Controller
{

    private $view = "crudbooster::dev_layouts.modules.modules";

    public function __construct()
    {
        view()->share(['page_title'=>'Module Manager']);
    }


    public function getIndex() {
        $data = [];
        $data['result'] = DB::table("cb_modules")->get();
        return view($this->view.'.index',$data);
    }

    public function getAdd() {
        $data = [];
        $data['tables'] = cb()->listAllTable();
        $data['module'] = (request('modules_id'))?cb()->find("cb_modules", request("modules_id")):null;
        return view($this->view.'.add', $data);
    }

    public function getTables()
    {
        return response()->json(cb()->listAllTable());
    }

    public function getAllColumn($table) {
        $data = cb()->listAllColumns($table);
        $pk = cb()->findPrimaryKey($table);
        $result = [];
        foreach($data as $item) {

            if(Str::contains(strtolower($item),["title","name","label"])) {
                $display = true;
            }else{
                $display = false;
            }

            $result[] = [
                "column"=>$item,
                "primary_key"=>($pk==$item)?true:false,
                "display"=>$display
            ];
        }
        return response()->json($result);
    }

    public function getColumns($table)
    {
        if(request("modules_id")) {
            $module = cb()->find("cb_modules",request("modules_id"));
            if($module->last_column_build) {
                return response()->json(json_decode($module->last_column_build));
            }
        }

        $columns = cb()->listAllColumns($table);
        $pk = cb()->findPrimaryKey($table);
        $result = [];
        foreach($columns as $column) {
            if($column != $pk) {

                // Skip Column
                if($column == 'deleted_at') continue;

                // Check if any relation table candidate
                $optionTable = "";
                if(Str::substr(strtolower($column),-3,3) == "_id") {
                    $relationTable = Str::substr($column,0,-3);
                    if(Schema::hasTable($relationTable)) {
                        $optionTable = $relationTable;
                    }
                }elseif (Str::substr(strtolower($column),0,3) == "id_") {
                    $relationTable = Str::substr($column,3);
                    if(Schema::hasTable($relationTable)) {
                        $optionTable = $relationTable;
                    }
                }

                $label = trim(Str::title(str_replace(["id_","_id","_"]," ",$column)));
                $label = Str::singular($label);
                $type = "text";

                if(Str::contains(strtolower($label),["photo","image","picture","gambar"])) {
                    $type = "image";
                }elseif (Str::contains(strtolower($label),["email","mail"])) {
                    $type = "email";
                }elseif (Str::contains(strtolower($label),["description","content","detail"])) {
                    $type =  "wysiwyg";
                }elseif (Str::contains(strtolower($label),["price","money","grand_total","tax"])) {
                    $type = "money";
                }elseif (Str::contains(strtolower($label),["quantity","qty","total","phone","telp"])) {
                    $type = "number";
                }elseif (Str::contains(strtolower($label),["date"])) {
                    $type = "date";
                }

                if (Str::substr(strtolower($column),-3,3) == "_id") {
                    $type = "select_table";
                } elseif (Str::substr($column, -3, 3) == "_at") {
                    $type = "datetime";
                } elseif (Str::substr($column,0, 3) == "id_") {
                    $type = "select_table";
                }

                $columnAdd = "on";
                $columnEdit = "on";
                $columnMandatory = "on";
                if(in_array($column,['created_at','updated_at'])) {
                    $columnAdd = "";
                    $columnEdit = "";
                    $columnMandatory = "";
                }

                $result[] = [
                    'column_label'=>$label,
                    'column_field'=> $column,
                    'column_type'=>$type,
                    'column_file_encrypt'=>"on",
                    'column_image_width'=>'',
                    'column_image_height'=>'',
                    'column_option_table'=>$optionTable,
                    'column_date_format'=>'',
                    'column_text_display_limit'=>150,
                    'column_text_max'=>255,
                    'column_text_min'=>0,
                    'column_money_prefix'=>'',
                    'column_money_precision'=>'',
                    'column_money_thousand_separator'=>'',
                    'column_money_decimal_separator'=>'',
                    'column_option_value'=> "",
                    'column_option_display'=> "",
                    'column_option_sql_condition'=> "",
                    'column_options'=> [],
                    'column_sql_query'=> "",
                    'column_help'=> "",
                    'column_mandatory'=> $columnMandatory,
                    'column_browse'=> "on",
                    'column_detail'=> "on",
                    'column_edit'=> $columnEdit,
                    'column_add'=> $columnAdd,
                    'listTableColumns'=> []
                ];
            }
        }
        return response()->json($result);
    }

    private function findComposer()
    {
        if (file_exists(getcwd().'/composer.phar')) {
            return '"'.PHP_BINARY.'" '.getcwd().'/composer.phar';
        }

        return 'composer';
    }

    private function composingAutoLoad()
    {
        $composer = $this->findComposer();
        $process = new Process($composer.' dump-autoload');

$composer . ' dump-autoload' of type string is incompatible with the type array expected by parameter $command of Symfony\Component\Process\Process::__construct().

        $process->setWorkingDirectory(base_path())->run();
    }

    public function postCreateMigration()
    {
        try {
            cb()->validation(['table_name','structures']);

            $tableName = request("table_name");

            if(!Schema::hasTable($tableName)) {

It seems like $tableName can also be of type array; however, parameter $table of Illuminate\Database\Schema\Builder::hasTable() does only seem to accept string, maybe add an additional type check?

                $filenameMigration = date("Y_m_d_His")."_".$tableName.".php";

Are you sure $tableName of type Illuminate\Http\Request|array|string can be used in concatenation?

                $createTemplate = file_get_contents(base_path("vendor/laravel/framework/src/Illuminate/Database/Migrations/stubs/create.stub"));
                $className = Str::studly($tableName);

It seems like $tableName can also be of type array; however, parameter $value of Illuminate\Support\Str::studly() does only seem to accept string, maybe add an additional type check?

                $createTemplate = str_replace("DummyClass", $className, $createTemplate);
                $createTemplate = str_replace("DummyTable", $tableName, $createTemplate);
                $createTemplate = str_replace("\$table->increments('id');","",$createTemplate);

                $structureItems = "";

                if(request("timestamp")) {
                    $structureItems .= "\$table->timestamps();\n\t\t\t";
                }

                if(request("soft_deletes")) {
                    $structureItems .= "\$table->softDeletes();\n\t\t\t";
                }

                foreach(request("structures") as $item) {

                    $nullable = "";

                    if(!in_array($item['type_data'],["bigIncrements","increments","mediumIncrements","smallIncrements"])) {
                        $nullable = "->nullable()";
                    }

                    if($item['length']) {
                        $structureItems .= "\$table->".$item['type_data']."('".$item['field_name']."', ".$item['length'].")$nullable;\n\t\t\t";
                    }else{
                        $structureItems .= "\$table->".$item['type_data']."('".$item['field_name']."')$nullable;\n\t\t\t";
                    }
                }
                $createTemplate = str_replace("\$table->timestamps();", $structureItems, $createTemplate);

                // Put File onto the migration folders
                file_put_contents(database_path("migrations/".$filenameMigration), $createTemplate);

                // Composing
                $this->composingAutoLoad();

                // Migrate
                Artisan::call("migrate");
            } else {
                throw new \Exception("The table $tableName has already exists!");
            }

        } catch (CBValidationException $e) {
            return response()->json(['status'=>false,'message'=>$e->getMessage()]);
        } catch (\Exception $e) {
            return response()->json(['status'=>false,'message'=>$e->getMessage()]);
        }

        return response()->json(['status'=>true,'message'=>'Migration successfully!']);
    }

    public function postCheckExistModule()
    {
        try {
            cb()->validation(['name', 'table']);

            if(DB::table("cb_modules")->where("table_name",request("table"))->where("name",request("name"))->count()) {
                return response()->json(['status'=>true]);
            }

        } catch (CBValidationException $e) {
            return response()->json(['status'=>false,'message'=>$e->getMessage()]);
        }

        return response()->json(['status'=>false]);
    }

    public function postAddSave() {

        try {
            cb()->validation(['name', 'table','icon','columns']);

            $module = (new ModuleGenerator(request('table'), request('name'), request('icon'), request("columns"), request("rebuild")))->make();

        } catch (CBValidationException $e) {
            return response()->json(['status'=>false,'message'=>$e->getMessage()]);
        }

        return response()->json(['status'=>true, 'message'=>'Please remember that you can still modify the structure by edit the controller file '.$module['controller'].' :)']);
    }

    public function getDelete($id) {
        $module = cb()->find("cb_modules",$id);
        @unlink(app_path("Http/Controllers/".$module->controller.".php"));

It seems like you do not handle an error condition for unlink(). This can introduce security issues, and is generally not recommended.

        DB::table("cb_modules")->where("id", $id)->delete();
        DB::table("cb_menus")->where("cb_modules_id", $id)->delete();
        return cb()->redirectBack("The module has been deleted!","success");
    }

    public function getDeleteSoft($id) {
        $module = cb()->find("cb_modules",$id);

The assignment to $module is dead and can be removed.

        DB::table("cb_modules")->where("id", $id)->delete();
        DB::table("cb_menus")->where("cb_modules_id", $id)->delete();
        return cb()->redirectBack("The module has been deleted!","success");
    }

}