crocodicstudio\crudbooster\Modules\ModuleGenerator\ScaffoldingParser

Complexity

Total Complexity

21

Size/Duplication

Total Lines	117
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	formOptions()	0	11	4
D	parse()	0	36	9
A	parseCallback()	0	7	1
A	prepareFields()	0	16	4
A	extractLines()	0	17	3

<?php

namespace crocodicstudio\crudbooster\Modules\ModuleGenerator;

class ScaffoldingParser
{
    static function parse($code, $type = 'form')

It is generally recommended to explicitly declare the visibility for methods.

    {
        $colsItem = self::extractLines($code, $type);

        foreach ($colsItem as &$item) {
            $item = str_replace(' ','', $item);
            $item = str_replace('\',]',']', $item);
            $item = trim($item);
            $item = trim($item, '[');
            $item = trim($item, '];');
            $item = trim($item);
            $item = trim(preg_replace("/[\n\r\t]/", "", $item));
            $strSplit = str_split($item);
            $innerCount = 0;
            foreach ($strSplit as $index => $s) {
                if ($s == '[') {
                    $innerCount++;
                }
                if ($s == ']') {
                    $innerCount--;
                }
                if ($innerCount == 0 && $s == ',' && $strSplit[$index + 1] == "'") {
                    $strSplit[$index] = "|SPLIT|";
                }
            }
            $item = implode("", $strSplit);
        }

        foreach ($colsItem as &$col) {
            $colInnerItem = self::prepareFields(explode('|SPLIT|', $col));
            $col = $colInnerItem;
        }

        self::formOptions($type, $colsItem);

        return $colsItem;
    }

    /**
     * @param $code
     * @param $type
     * @return array
     */
    private static function extractLines($code, $type)
    {
        if ($type == 'form') {
            $cols = extract_unit($code, "# START FORM DO NOT REMOVE THIS LINE", "# END FORM DO NOT REMOVE THIS LINE");
            $cols = str_replace('"', "'", $cols);
            $cols = trim(str_replace('$this->form = [];', '', $cols));
            $colsItem = explode('$this->form[] = ', $cols);
        } elseif ($type == 'col') {
            $cols = extract_unit($code, "# START COLUMNS DO NOT REMOVE THIS LINE", "# END COLUMNS DO NOT REMOVE THIS LINE");
            $cols = str_replace('"', "'", $cols);
            $cols = trim(str_replace('$this->col = [];', '', $cols));
            $colsItem = explode('$this->col[] = ', $cols);
        }

        $colsItem = array_filter($colsItem);

The variable $colsItem does not seem to be defined for all execution paths leading up to this point.

        return $colsItem;
    }

    /**
     * @param $type
     * @param $colsItem
     * @return mixed
     */
    private static function formOptions($type, $colsItem)
    {
        foreach ($colsItem as &$form) {
            if ($type !== 'form') {
                continue;
            }
            if ($form['options']) {
                @eval("\$options = $form[options];");

The use of eval() is discouraged.

                @$form['options'] = $options;

The variable $options seems to be never defined.

            } else {
                $form['options'] = [];
            }
        }
    }

    /**
     * @param $s
     * @return array
     */
    private static function parseCallback($s)
    {
        $s = str_replace("return", "return ", $s);
        $val = trim(str_replace(["'callback'=>function(\$row) {", "'callback'=>function(\$row){"], "", $s));
        $val = substr($val, 0, -1);

        return $val; //to remove last }

The expression return $val returns the type string which is incompatible with the documented return type array.

    }

    /**
     * @param $split
     * @return array
     */
    private static function prepareFields($split)
    {
        $colInnerItem = [];
        foreach ($split as $s) {
            if (strpos($s, 'options') !== false) {
                $colInnerItem['options'] = trim(str_replace("'options'=>", "", $s));
            } elseif (strpos($s, 'callback') !== false) {
                $colInnerItem['callback'] = self::parseCallback($s);
            } else {
                $s = trim($s, "'");
                $sSplit = explode('=>', $s);
                $colInnerItem[$sSplit[0]] = $sSplit[1];
            }
        }

        return $colInnerItem;
    }
}