creocoder\flysystem\SftpFilesystem

Complexity

Total Complexity

9

Size/Duplication

Total Lines	89
Duplicated Lines	24.72 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	init()	0	20	6
A	prepareAdapter()	22	22	3

<?php
/**
 * @link https://github.com/creocoder/yii2-flysystem
 * @copyright Copyright (c) 2015 Alexander Kochetov
 * @license http://opensource.org/licenses/BSD-3-Clause
 */

namespace creocoder\flysystem;

use League\Flysystem\Sftp\SftpAdapter;
use Yii;
use yii\base\InvalidConfigException;

/**
 * SftpFilesystem
 *
 * @author Alexander Kochetov <creocoder@gmail.com>
 */
class SftpFilesystem extends Filesystem
{
    /**
     * @var string
     */
    public $host;
    /**
     * @var string
     */
    public $port;
    /**
     * @var string
     */
    public $username;
    /**
     * @var string
     */
    public $password;
    /**
     * @var integer
     */
    public $timeout;
    /**
     * @var string
     */
    public $root;
    /**
     * @var string
     */
    public $privateKey;
    /**
     * @var integer
     */
    public $permPrivate;
    /**
     * @var integer
     */
    public $permPublic;

    /**
     * @inheritdoc
     */
    public function init()
    {
        if ($this->host === null) {
            throw new InvalidConfigException('The "host" property must be set.');
        }

        if ($this->username === null) {
            throw new InvalidConfigException('The "username" property must be set.');
        }

        if ($this->password === null && $this->privateKey === null) {
            throw new InvalidConfigException('Either "password" or "privateKey" property must be set.');
        }

        if ($this->root !== null) {
            $this->root = Yii::getAlias($this->root);

It seems like \Yii::getAlias($this->root) can also be of type boolean. However, the property $root is declared as type string. Maybe add an additional type check?

        }

        parent::init();
    }

    /**
     * @return SftpAdapter
     */
    protected function prepareAdapter()

This method seems to be duplicated in your project.

    {
        $config = [];

        foreach ([
            'host',
            'port',
            'username',
            'password',
            'timeout',
            'root',
            'privateKey',
            'permPrivate',
            'permPublic',
        ] as $name) {
            if ($this->$name !== null) {
                $config[$name] = $this->$name;
            }
        }

        return new SftpAdapter($config);
    }
}