FtpFilesystem - Code Metrics - creocoder/yii2-flysystem - Measure and Improve Code Quality continuously with Scrutinizer

FtpFilesystem A
last analyzed 2017-02-08 10:29 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	91
Duplicated Lines	26.37 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
wmc	6
c	0
b	0
f	0
lcom	1
cbo	4
dl	24
loc	91
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	0	12	3
B	prepareAdapter()	24	24	3

How to fix Duplicated Code

<?php
/**
 * @link https://github.com/creocoder/yii2-flysystem
 * @copyright Copyright (c) 2015 Alexander Kochetov
 * @license http://opensource.org/licenses/BSD-3-Clause
 */

namespace creocoder\flysystem;

use League\Flysystem\Adapter\Ftp;
use Yii;
use yii\base\InvalidConfigException;

/**
 * FtpFilesystem
 *
 * @author Alexander Kochetov <[email protected]>
 */
class FtpFilesystem extends Filesystem
{
    /**
     * @var string
     */
    public $host;
    /**
     * @var integer
     */
    public $port;
    /**
     * @var string
     */
    public $username;
    /**
     * @var string
     */
    public $password;
    /**
     * @var boolean
     */
    public $ssl;
    /**
     * @var integer
     */
    public $timeout;
    /**
     * @var string
     */
    public $root;
    /**
     * @var integer
     */
    public $permPrivate;
    /**
     * @var integer
     */
    public $permPublic;
    /**
     * @var boolean
     */
    public $passive;
    /**
     * @var integer
     */
    public $transferMode;

    /**
     * @inheritdoc
     */
    public function init()
    {
        if ($this->host === null) {
            throw new InvalidConfigException('The "host" property must be set.');
        }

        if ($this->root !== null) {
            $this->root = Yii::getAlias($this->root);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        }

        parent::init();
    }

    /**
     * @return Ftp
     */
    protected function prepareAdapter()

    {
        $config = [];

        foreach ([
            'host',
            'port',
            'username',
            'password',
            'ssl',
            'timeout',
            'root',
            'permPrivate',
            'permPublic',
            'passive',
            'transferMode',
        ] as $name) {
            if ($this->$name !== null) {
                $config[$name] = $this->$name;
            }
        }

        return new Ftp($config);
    }
}


1		<?php
2		/**
3		* @link https://github.com/creocoder/yii2-flysystem
4		* @copyright Copyright (c) 2015 Alexander Kochetov
5		* @license http://opensource.org/licenses/BSD-3-Clause
6		*/
7
8		namespace creocoder\flysystem;
9
10		use League\Flysystem\Adapter\Ftp;
11		use Yii;
12		use yii\base\InvalidConfigException;
13
14		/**
15		* FtpFilesystem
16		*
17		* @author Alexander Kochetov <[email protected]>
18		*/
19		class FtpFilesystem extends Filesystem
20		{
21		/**
22		* @var string
23		*/
24		public $host;
25		/**
26		* @var integer
27		*/
28		public $port;
29		/**
30		* @var string
31		*/
32		public $username;
33		/**
34		* @var string
35		*/
36		public $password;
37		/**
38		* @var boolean
39		*/
40		public $ssl;
41		/**
42		* @var integer
43		*/
44		public $timeout;
45		/**
46		* @var string
47		*/
48		public $root;
49		/**
50		* @var integer
51		*/
52		public $permPrivate;
53		/**
54		* @var integer
55		*/
56		public $permPublic;
57		/**
58		* @var boolean
59		*/
60		public $passive;
61		/**
62		* @var integer
63		*/
64		public $transferMode;
65
66		/**
67		* @inheritdoc
68		*/
69		public function init()
70		{
71		if ($this->host === null) {
72		throw new InvalidConfigException('The "host" property must be set.');
73		}
74
75		if ($this->root !== null) {
76		$this->root = Yii::getAlias($this->root);
		0 ignored issues – show Documentation Bug introduced 2016-02-17 00:16 UTC by Report Bug Copy Issue Report It seems like `\Yii::getAlias($this->root)` can also be of type `boolean`. However, the property `$root` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
77		}
78
79		parent::init();
80		}
81
82		/**
83		* @return Ftp
84		*/
85	View Code Duplication	protected function prepareAdapter()
		0 ignored issues – show Duplication introduced 2016-02-17 00:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
86		{
87		$config = [];
88
89		foreach ([
90		'host',
91		'port',
92		'username',
93		'password',
94		'ssl',
95		'timeout',
96		'root',
97		'permPrivate',
98		'permPublic',
99		'passive',
100		'transferMode',
101		] as $name) {
102		if ($this->$name !== null) {
103		$config[$name] = $this->$name;
104		}
105		}
106
107		return new Ftp($config);
108		}
109		}
110

creocoder / yii2-flysystem

GitHub Access Token became invalid

FtpFilesystem A last analyzed 2017-02-08 10:29 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

FtpFilesystem A
last analyzed 2017-02-08 10:29 UTC