| Conditions | 1 |
| Paths | 1 |
| Total Lines | 84 |
| Code Lines | 61 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 15 | public function ticketProvider() |
||
| 16 | { |
||
| 17 | return array( |
||
| 18 | array( |
||
| 19 | 'SELECT * FROM ddc1372_foobar f WHERE f.foo = :foo AND f.bar IN (:bar) ORDER BY f.id', |
||
| 20 | array('foo'=>1,'bar'=> array(1, 2, 3)), |
||
| 21 | array('foo'=>PDO::PARAM_INT,'bar'=> Connection::PARAM_INT_ARRAY,), |
||
| 22 | array( |
||
| 23 | array('id'=>1,'foo'=>1,'bar'=>1), |
||
| 24 | array('id'=>2,'foo'=>1,'bar'=>2), |
||
| 25 | array('id'=>3,'foo'=>1,'bar'=>3), |
||
| 26 | ) |
||
| 27 | ), |
||
| 28 | |||
| 29 | array( |
||
| 30 | 'SELECT * FROM ddc1372_foobar f WHERE f.foo = :foo AND f.bar IN (:bar) ORDER BY f.id', |
||
| 31 | array('foo'=>1,'bar'=> array(1, 2, 3)), |
||
| 32 | array('bar'=> Connection::PARAM_INT_ARRAY,'foo'=>PDO::PARAM_INT), |
||
| 33 | array( |
||
| 34 | array('id'=>1,'foo'=>1,'bar'=>1), |
||
| 35 | array('id'=>2,'foo'=>1,'bar'=>2), |
||
| 36 | array('id'=>3,'foo'=>1,'bar'=>3), |
||
| 37 | ) |
||
| 38 | ), |
||
| 39 | |||
| 40 | array( |
||
| 41 | 'SELECT * FROM ddc1372_foobar f WHERE f.bar IN (:bar) AND f.foo = :foo ORDER BY f.id', |
||
| 42 | array('foo'=>1,'bar'=> array(1, 2, 3)), |
||
| 43 | array('bar'=> Connection::PARAM_INT_ARRAY,'foo'=>PDO::PARAM_INT), |
||
| 44 | array( |
||
| 45 | array('id'=>1,'foo'=>1,'bar'=>1), |
||
| 46 | array('id'=>2,'foo'=>1,'bar'=>2), |
||
| 47 | array('id'=>3,'foo'=>1,'bar'=>3), |
||
| 48 | ) |
||
| 49 | ), |
||
| 50 | |||
| 51 | array( |
||
| 52 | 'SELECT * FROM ddc1372_foobar f WHERE f.bar IN (:bar) AND f.foo = :foo ORDER BY f.id', |
||
| 53 | array('foo'=>1,'bar'=> array('1', '2', '3')), |
||
| 54 | array('bar'=> Connection::PARAM_STR_ARRAY,'foo'=>PDO::PARAM_INT), |
||
| 55 | array( |
||
| 56 | array('id'=>1,'foo'=>1,'bar'=>1), |
||
| 57 | array('id'=>2,'foo'=>1,'bar'=>2), |
||
| 58 | array('id'=>3,'foo'=>1,'bar'=>3), |
||
| 59 | ) |
||
| 60 | ), |
||
| 61 | |||
| 62 | array( |
||
| 63 | 'SELECT * FROM ddc1372_foobar f WHERE f.bar IN (:bar) AND f.foo IN (:foo) ORDER BY f.id', |
||
| 64 | array('foo'=>array('1'),'bar'=> array(1, 2, 3,4)), |
||
| 65 | array('bar'=> Connection::PARAM_STR_ARRAY,'foo'=>Connection::PARAM_INT_ARRAY), |
||
| 66 | array( |
||
| 67 | array('id'=>1,'foo'=>1,'bar'=>1), |
||
| 68 | array('id'=>2,'foo'=>1,'bar'=>2), |
||
| 69 | array('id'=>3,'foo'=>1,'bar'=>3), |
||
| 70 | array('id'=>4,'foo'=>1,'bar'=>4), |
||
| 71 | ) |
||
| 72 | ), |
||
| 73 | |||
| 74 | array( |
||
| 75 | 'SELECT * FROM ddc1372_foobar f WHERE f.bar IN (:bar) AND f.foo IN (:foo) ORDER BY f.id', |
||
| 76 | array('foo'=>1,'bar'=> 2), |
||
| 77 | array('bar'=>PDO::PARAM_INT,'foo'=>PDO::PARAM_INT), |
||
| 78 | array( |
||
| 79 | array('id'=>2,'foo'=>1,'bar'=>2), |
||
| 80 | ) |
||
| 81 | ), |
||
| 82 | |||
| 83 | array( |
||
| 84 | 'SELECT * FROM ddc1372_foobar f WHERE f.bar = :arg AND f.foo <> :arg ORDER BY f.id', |
||
| 85 | array('arg'=>'1'), |
||
| 86 | array('arg'=>PDO::PARAM_STR), |
||
| 87 | array( |
||
| 88 | array('id'=>5,'foo'=>2,'bar'=>1), |
||
| 89 | ) |
||
| 90 | ), |
||
| 91 | |||
| 92 | array( |
||
| 93 | 'SELECT * FROM ddc1372_foobar f WHERE f.bar NOT IN (:arg) AND f.foo IN (:arg) ORDER BY f.id', |
||
| 94 | array('arg'=>array(1, 2)), |
||
| 95 | array('arg'=>Connection::PARAM_INT_ARRAY), |
||
| 96 | array( |
||
| 97 | array('id'=>3,'foo'=>1,'bar'=>3), |
||
| 98 | array('id'=>4,'foo'=>1,'bar'=>4), |
||
| 99 | ) |
||
| 180 |