Issues in SolrClient.php (master) - Issues in master - cpliakas/psolr - Measure and Improve Code Quality continuously with Scrutinizer

Issues (46)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/PSolr/Client/SolrClient.php (17 issues)

Labels

Severity

Minor 17

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace PSolr\Client;

use Guzzle\Common\Collection;
use Guzzle\Http\Message\Response;
use Guzzle\Http\Url;
use Guzzle\Service\Client;

/**
 * @method array luke(   $params = array(), $body = null, $headers = null, array $options = array())
 * @method array mbeans( $params = array(), $body = null, $headers = null, array $options = array())
 * @method array mlt(    $params = array(), $body = null, $headers = null, array $options = array())
 * @method array ping(   $params = array(), $body = null, $headers = null, array $options = array())
 * @method array select( $params = array(), $body = null, $headers = null, array $options = array())
 * @method array spell(  $params = array(), $body = null, $headers = null, array $options = array())
 * @method array stats(  $params = array(), $body = null, $headers = null, array $options = array())
 * @method array suggest($params = array(), $body = null, $headers = null, array $options = array())
 * @method array system( $params = array(), $body = null, $headers = null, array $options = array())
 * @method array update( $params = array(), $body = null, $headers = null, array $options = array())
 */
class SolrClient extends Client
{
    const MAX_QUERY_LENGTH = 3600;

    /**
     * @var \PSolr\Client\RequestHandler[]
     */
    protected $handlers = array();

    /**
     * {@inheritdoc}
     *
     * @return \PSolr\Client\SolrClient
     */
    public static function factory($config = array())
    {
        $defaults = array(
            'base_url' => 'http://localhost:8983',
            'base_path' => '/solr',
            'max_query_length' => self::MAX_QUERY_LENGTH,
        );

        $required = array(
            'base_url',
            'base_path',
            'max_query_length',
        );

        // Instantiate and return the Solr client.
        $config = Collection::fromConfig($config, $defaults, $required);
        $solr = new static($config->get('base_url'), $config);

        // Use URI template expansion in a way that doesn't break Solr.
        $solr->setUriTemplate(new SolrUriTemplate());

        // Use JSON whenever possible.
        // @see http://code.google.com/p/solr-php-client/issues/detail?id=6#c1
        $jsonParams = array(
            'wt'      => 'json',
            'json.nl' => 'map',
        );

        // Sometimes we have to use XML :-(.
        $xmlParams = array(
            'wt' => 'xml',
        );

        $solr
            ->setRequestHandler(new RequestHandler('luke',    'admin/luke',      'GET',  $jsonParams))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setRequestHandler(new RequestHandler('mbeans',  'admin/mbeans',    'GET',  $xmlParams + array('stats' => 'true')))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setRequestHandler(new RequestHandler('mlt',     'mlt',             'GET',  $jsonParams))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setRequestHandler(new RequestHandler('ping',    'admin/ping',      'HEAD', $jsonParams))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setRequestHandler(new RequestHandler('select',  'select',          'GET',  $jsonParams))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setRequestHandler(new RequestHandler('spell',   'spell',           'GET',  $jsonParams))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setRequestHandler(new RequestHandler('stats',   'admin/stats.jsp', 'GET',  $xmlParams))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setRequestHandler(new RequestHandler('suggest', 'suggest',         'GET',  $jsonParams))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setRequestHandler(new RequestHandler('system',  'admin/system',    'GET',  $jsonParams))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setRequestHandler(new RequestHandler('update',  'update',          'POST', $jsonParams))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        ;

        return $solr;
    }

    /**
     * @param string $handlerName
     *
     * @return boolean
     */
    public function hasRequestHandler($handlerName)
    {
        return isset($this->handlers[$handlerName]);
    }

    /**
     * @param \PSolr\Client\RequestHandler $handler
     *
     * @return \PSolr\Client\SolrClient
     */
    public function setRequestHandler(RequestHandler $handler)
    {
        $handlerName = $handler->getName();
        $this->handlers[$handlerName] = $handler;
        return $this;
    }

    /**
     * @param string $handlerName
     *
     * @return \PSolr\Client\RequestHandler
     *
     * @throws \OutOfBoundsException
     */
    public function getRequestHandler($handlerName)
    {
        if (!isset($this->handlers[$handlerName])) {
            throw new \OutOfBoundsException('Request handler not registered: ' . $handlerName);
        }
        return $this->handlers[$handlerName];
    }

    /**
     * @param string $handlerName
     *
     * @return \PSolr\Client\SolrClient
     */
    public function removeRequestHandler($handlerName)
    {
        unset($this->handlers[$handlerName]);
        return $this;
    }

    /**
     * @param string $handlerName
     * @param mixed $params
     * @param string|null $body
     * @param array|null $headers
     * @param array $options
     *
     * @return array|\SimpleXMLElement
     */
    public function sendRequest($handlerName, $params = array(), $body = null, $headers = null, array $options = array())
    {
        $handler = $this->getRequestHandler($handlerName);
        $params = $this->normalizeParams($handler, $params);

        // For GETs and HEADs, the params are the query string. For POSTs
        // without a body, the params are post data. For POSTs with a body, the
        // params are the qstring.
        $method = $handler->getMethod();
        if ('GET' == $method || 'HEAD' == $method) {
            $options['query'] = $params;
        } elseif ('POST' == $method) {
            if (null === $body) {
                $body = $params;
            } else {
                $options['query'] = $params;
            }
        }

        $request = $this->createRequest($method, $handler->getPath(), $headers, $body, $options);
        $response = $request->send();
        return $this->parseResponse($response, $params);
    }

    /**
     * Normalizes and merges default params.
     *
     * @param \PSolr\Client\RequestHandler $handler
     * @param mixed $params
     *
     * @return array
     */
    public function normalizeParams(RequestHandler $handler, $params)
    {
        if (is_string($params)) {
            $params = array('q' => $params);
        } elseif (!is_array($params)) {
            $params = (array) $params;
        }
        return array_merge($handler->getDefaultParams(), $params);
    }

    /**
     * {@inheritdoc}
     *
     * Prepends the {+base_path} expressions to the URI, converts the GET to a
     * POST if the query string is too long.
     */
    public function createRequest($method = 'GET', $uri = null, $headers = null, $body = null, array $options = array())
    {
        $uri = '{+base_path}/' . ltrim($uri, '/');
        if ('GET' == $method && $this->usePostMethod($uri, $options)) {
            $method = 'POST';
            $body = $options['query'];
            unset($options['query']);
        }
        return parent::createRequest($method, $uri, $headers, $body, $options);
    }

    /**
     * @param string $uri
     * @param array $options
     *
     * @return boolean
     */
    public function usePostMethod($uri, array $options)
    {
        if (isset($options['query'])) {
            $url = Url::factory($this->getBaseUrl())->combine($this->expandTemplate($uri, $options['query']));

            return strlen($url) > $this->getConfig('max_query_length');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
        return false;
    }

    /**
     * @param \Guzzle\Http\Message\Response $response
     * @param array $params
     *
     * @return array|\SimpleXMLElement
     */
    public function parseResponse(Response $response, array $params)
    {
        $method = (isset($params['wt']) && 'json' == $params['wt']) ? 'json' : 'xml';
        return $response->$method();
    }

    /**
     * Allows request handlers to be called as methods.
     */
    public function __call($name, $arguments)
    {
        array_unshift($arguments, $name);
        return call_user_func_array(array($this, 'sendRequest'), $arguments);
    }
}


1		<?php
2
3		namespace PSolr\Client;
4
5		use Guzzle\Common\Collection;
6		use Guzzle\Http\Message\Response;
7		use Guzzle\Http\Url;
8		use Guzzle\Service\Client;
9
10		/**
11		* @method array luke( $params = array(), $body = null, $headers = null, array $options = array())
12		* @method array mbeans( $params = array(), $body = null, $headers = null, array $options = array())
13		* @method array mlt( $params = array(), $body = null, $headers = null, array $options = array())
14		* @method array ping( $params = array(), $body = null, $headers = null, array $options = array())
15		* @method array select( $params = array(), $body = null, $headers = null, array $options = array())
16		* @method array spell( $params = array(), $body = null, $headers = null, array $options = array())
17		* @method array stats( $params = array(), $body = null, $headers = null, array $options = array())
18		* @method array suggest($params = array(), $body = null, $headers = null, array $options = array())
19		* @method array system( $params = array(), $body = null, $headers = null, array $options = array())
20		* @method array update( $params = array(), $body = null, $headers = null, array $options = array())
21		*/
22		class SolrClient extends Client
23		{
24		const MAX_QUERY_LENGTH = 3600;
25
26		/**
27		* @var \PSolr\Client\RequestHandler[]
28		*/
29		protected $handlers = array();
30
31		/**
32		* {@inheritdoc}
33		*
34		* @return \PSolr\Client\SolrClient
35		*/
36	28	public static function factory($config = array())
37		{
38		$defaults = array(
39	28	'base_url' => 'http://localhost:8983',
40	28	'base_path' => '/solr',
41	28	'max_query_length' => self::MAX_QUERY_LENGTH,
42	28	);
43
44		$required = array(
45	28	'base_url',
46	28	'base_path',
47	28	'max_query_length',
48	28	);
49
50		// Instantiate and return the Solr client.
51	28	$config = Collection::fromConfig($config, $defaults, $required);
52	28	$solr = new static($config->get('base_url'), $config);
53
54		// Use URI template expansion in a way that doesn't break Solr.
55	28	$solr->setUriTemplate(new SolrUriTemplate());
56
57		// Use JSON whenever possible.
58		// @see http://code.google.com/p/solr-php-client/issues/detail?id=6#c1
59		$jsonParams = array(
60	28	'wt' => 'json',
61	28	'json.nl' => 'map',
62	28	);
63
64		// Sometimes we have to use XML :-(.
65		$xmlParams = array(
66	28	'wt' => 'xml',
67	28	);
68
69		$solr
70	28	->setRequestHandler(new RequestHandler('luke', 'admin/luke', 'GET', $jsonParams))
		0 ignored issues – show Documentation introduced 2016-09-12 12:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'luke'` is of type `string`, but the function expects a `object<PSolr\Client\type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2016-09-12 12:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'admin/luke'` is of type `string`, but the function expects a `object<PSolr\Client\type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
71	28	->setRequestHandler(new RequestHandler('mbeans', 'admin/mbeans', 'GET', $xmlParams + array('stats' => 'true')))
		0 ignored issues – show Documentation introduced 2016-09-12 12:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'mbeans'` is of type `string`, but the function expects a `object<PSolr\Client\type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2016-09-12 12:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'admin/mbeans'` is of type `string`, but the function expects a `object<PSolr\Client\type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
72	28	->setRequestHandler(new RequestHandler('mlt', 'mlt', 'GET', $jsonParams))
		0 ignored issues – show Documentation introduced 2016-09-12 12:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'mlt'` is of type `string`, but the function expects a `object<PSolr\Client\type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
73	28	->setRequestHandler(new RequestHandler('ping', 'admin/ping', 'HEAD', $jsonParams))
		0 ignored issues – show Documentation introduced 2016-09-12 12:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'ping'` is of type `string`, but the function expects a `object<PSolr\Client\type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2016-09-12 12:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'admin/ping'` is of type `string`, but the function expects a `object<PSolr\Client\type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
74	28	->setRequestHandler(new RequestHandler('select', 'select', 'GET', $jsonParams))
		0 ignored issues – show Documentation introduced 2016-09-12 12:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'select'` is of type `string`, but the function expects a `object<PSolr\Client\type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
75	28	->setRequestHandler(new RequestHandler('spell', 'spell', 'GET', $jsonParams))
		0 ignored issues – show Documentation introduced 2016-09-12 12:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'spell'` is of type `string`, but the function expects a `object<PSolr\Client\type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
76	28	->setRequestHandler(new RequestHandler('stats', 'admin/stats.jsp', 'GET', $xmlParams))
		0 ignored issues – show Documentation introduced 2016-09-12 12:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'stats'` is of type `string`, but the function expects a `object<PSolr\Client\type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2016-09-12 12:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'admin/stats.jsp'` is of type `string`, but the function expects a `object<PSolr\Client\type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
77	28	->setRequestHandler(new RequestHandler('suggest', 'suggest', 'GET', $jsonParams))
		0 ignored issues – show Documentation introduced 2016-09-12 12:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'suggest'` is of type `string`, but the function expects a `object<PSolr\Client\type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
78	28	->setRequestHandler(new RequestHandler('system', 'admin/system', 'GET', $jsonParams))
		0 ignored issues – show Documentation introduced 2016-09-12 12:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'system'` is of type `string`, but the function expects a `object<PSolr\Client\type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2016-09-12 12:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'admin/system'` is of type `string`, but the function expects a `object<PSolr\Client\type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
79	28	->setRequestHandler(new RequestHandler('update', 'update', 'POST', $jsonParams))
		0 ignored issues – show Documentation introduced 2016-09-12 12:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'update'` is of type `string`, but the function expects a `object<PSolr\Client\type>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
80		;
81
82	28	return $solr;
83		}
84
85		/**
86		* @param string $handlerName
87		*
88		* @return boolean
89		*/
90	8	public function hasRequestHandler($handlerName)
91		{
92	8	return isset($this->handlers[$handlerName]);
93		}
94
95		/**
96		* @param \PSolr\Client\RequestHandler $handler
97		*
98		* @return \PSolr\Client\SolrClient
99		*/
100	28	public function setRequestHandler(RequestHandler $handler)
101		{
102	28	$handlerName = $handler->getName();
103	28	$this->handlers[$handlerName] = $handler;
104	28	return $this;
105		}
106
107		/**
108		* @param string $handlerName
109		*
110		* @return \PSolr\Client\RequestHandler
111		*
112		* @throws \OutOfBoundsException
113		*/
114	16	public function getRequestHandler($handlerName)
115		{
116	16	if (!isset($this->handlers[$handlerName])) {
117	4	throw new \OutOfBoundsException('Request handler not registered: ' . $handlerName);
118		}
119	12	return $this->handlers[$handlerName];
120		}
121
122		/**
123		* @param string $handlerName
124		*
125		* @return \PSolr\Client\SolrClient
126		*/
127	4	public function removeRequestHandler($handlerName)
128		{
129	4	unset($this->handlers[$handlerName]);
130	4	return $this;
131		}
132
133		/**
134		* @param string $handlerName
135		* @param mixed $params
136		* @param string\|null $body
137		* @param array\|null $headers
138		* @param array $options
139		*
140		* @return array\|\SimpleXMLElement
141		*/
142	4	public function sendRequest($handlerName, $params = array(), $body = null, $headers = null, array $options = array())
143		{
144	4	$handler = $this->getRequestHandler($handlerName);
145	4	$params = $this->normalizeParams($handler, $params);
146
147		// For GETs and HEADs, the params are the query string. For POSTs
148		// without a body, the params are post data. For POSTs with a body, the
149		// params are the qstring.
150	4	$method = $handler->getMethod();
151	4	if ('GET' == $method \|\| 'HEAD' == $method) {
152	4	$options['query'] = $params;
153	4	} elseif ('POST' == $method) {
154		if (null === $body) {
155		$body = $params;
156		} else {
157		$options['query'] = $params;
158		}
159		}
160
161	4	$request = $this->createRequest($method, $handler->getPath(), $headers, $body, $options);
162	4	$response = $request->send();
163		return $this->parseResponse($response, $params);
164		}
165
166		/**
167		* Normalizes and merges default params.
168		*
169		* @param \PSolr\Client\RequestHandler $handler
170		* @param mixed $params
171		*
172		* @return array
173		*/
174	8	public function normalizeParams(RequestHandler $handler, $params)
175		{
176	8	if (is_string($params)) {
177	4	$params = array('q' => $params);
178	8	} elseif (!is_array($params)) {
179	4	$params = (array) $params;
180	4	}
181	8	return array_merge($handler->getDefaultParams(), $params);
182		}
183
184		/**
185		* {@inheritdoc}
186		*
187		* Prepends the {+base_path} expressions to the URI, converts the GET to a
188		* POST if the query string is too long.
189		*/
190	4	public function createRequest($method = 'GET', $uri = null, $headers = null, $body = null, array $options = array())
191		{
192	4	$uri = '{+base_path}/' . ltrim($uri, '/');
193	4	if ('GET' == $method && $this->usePostMethod($uri, $options)) {
194		$method = 'POST';
195		$body = $options['query'];
196		unset($options['query']);
197		}
198	4	return parent::createRequest($method, $uri, $headers, $body, $options);
199	4	}
200
201		/**
202		* @param string $uri
203		* @param array $options
204		*
205		* @return boolean
206		*/
207		public function usePostMethod($uri, array $options)
208		{
209		if (isset($options['query'])) {
210		$url = Url::factory($this->getBaseUrl())->combine($this->expandTemplate($uri, $options['query']));
		0 ignored issues – show Bug introduced 2016-09-12 12:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->getBaseUrl()` targeting `Guzzle\Http\Client::getBaseUrl()` can also be of type `object<Guzzle\Http\Url>`; however, `Guzzle\Http\Url::factory()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
211		return strlen($url) > $this->getConfig('max_query_length');
		0 ignored issues – show Documentation introduced 2016-09-12 12:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'max_query_length'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
212		}
213		return false;
214		}
215
216		/**
217		* @param \Guzzle\Http\Message\Response $response
218		* @param array $params
219		*
220		* @return array\|\SimpleXMLElement
221		*/
222		public function parseResponse(Response $response, array $params)
223		{
224		$method = (isset($params['wt']) && 'json' == $params['wt']) ? 'json' : 'xml';
225		return $response->$method();
226		}
227
228		/**
229		* Allows request handlers to be called as methods.
230		*/
231	4	public function __call($name, $arguments)
232		{
233	4	array_unshift($arguments, $name);
234	4	return call_user_func_array(array($this, 'sendRequest'), $arguments);
235		}
236		}
237

cpliakas / psolr

Issues (46)

Security Analysis no request data

src/PSolr/Client/SolrClient.php (17 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like