Directories - Code Metrics - cpliakas/manifest-publisher - Measure and Improve Code Quality continuously with Scrutinizer

Directories A
last analyzed 2017-12-19 03:08 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	3
lcom	0
cbo	0
dl	0
loc	31
ccs	0
cts	6
cp	0
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	getBaseDirectory()	4	1
A	getRepositoryDirectory()	4	1
A	getPharDirectory()	4	1

<?php

namespace Cpliakas\ManifestPublisher\Traits;

use Cpliakas\ManifestPublisher\Repository;

trait Directories
{
    /**
     * @return string
     */
    public function getBaseDirectory()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        return $_SERVER['HOME'] . '/.ManifestPublisher';
    }

    /**
     * @param Repository $repository
     *
     * @return string
     */
    public function getRepositoryDirectory(Repository $repository)
    {
        return $this->getBaseDirectory() . '/repos/' . $repository;
    }

    /**
     * @param Repository $repository
     * @param string     $version
     *
     * @return string
     */
    public function getPharDirectory(Repository $repository, $version)
    {
        return $this->getBaseDirectory() . '/phars/' . $repository . '/' . $version;
    }
}


1			<?php
2
3			namespace Cpliakas\ManifestPublisher\Traits;
4
5			use Cpliakas\ManifestPublisher\Repository;
6
7			trait Directories
8			{
9			/**
10			* @return string
11			*/
12			public function getBaseDirectory()
			0 ignored issues – show Coding Style introduced 2017-12-19 03:08 UTC by Report Bug Copy Issue Report `getBaseDirectory` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
13			{
14			return $_SERVER['HOME'] . '/.ManifestPublisher';
15			}
16
17			/**
18			* @param Repository $repository
19			*
20			* @return string
21			*/
22			public function getRepositoryDirectory(Repository $repository)
23			{
24			return $this->getBaseDirectory() . '/repos/' . $repository;
25			}
26
27			/**
28			* @param Repository $repository
29			* @param string $version
30			*
31			* @return string
32			*/
33			public function getPharDirectory(Repository $repository, $version)
34			{
35			return $this->getBaseDirectory() . '/phars/' . $repository . '/' . $version;
36			}
37			}
38

cpliakas / manifest-publisher

Directories A last analyzed 2017-12-19 03:08 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like

Directories A
last analyzed 2017-12-19 03:08 UTC