Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like GitWrapper often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use GitWrapper, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 18 | class GitWrapper |
||
| 19 | { |
||
| 20 | /** |
||
| 21 | * Symfony event dispatcher object used by this library to dispatch events. |
||
| 22 | * |
||
| 23 | * @var \Symfony\Component\EventDispatcher\EventDispatcherInterface |
||
| 24 | */ |
||
| 25 | private $dispatcher; |
||
| 26 | |||
| 27 | /** |
||
| 28 | * Path to the Git binary. |
||
| 29 | * |
||
| 30 | * @var string |
||
| 31 | */ |
||
| 32 | protected $gitBinary; |
||
| 33 | |||
| 34 | /** |
||
| 35 | * Environment variables defined in the scope of the Git command. |
||
| 36 | * |
||
| 37 | * @var array |
||
| 38 | */ |
||
| 39 | protected $env = array(); |
||
| 40 | |||
| 41 | /** |
||
| 42 | * The timeout of the Git command in seconds, defaults to 60. |
||
| 43 | * |
||
| 44 | * @var int |
||
| 45 | */ |
||
| 46 | protected $timeout = 60; |
||
| 47 | |||
| 48 | /** |
||
| 49 | * An array of options passed to the proc_open() function. |
||
| 50 | * |
||
| 51 | * @var array |
||
| 52 | */ |
||
| 53 | protected $procOptions = array(); |
||
| 54 | |||
| 55 | /** |
||
| 56 | * @var \GitWrapper\Event\GitOutputListenerInterface |
||
| 57 | */ |
||
| 58 | protected $streamListener; |
||
| 59 | |||
| 60 | /** |
||
| 61 | * Constructs a GitWrapper object. |
||
| 62 | * |
||
| 63 | * @param string|null $gitBinary |
||
| 64 | * The path to the Git binary. Defaults to null, which uses Symfony's |
||
| 65 | * ExecutableFinder to resolve it automatically. |
||
| 66 | * |
||
| 67 | * @throws \GitWrapper\GitException |
||
| 68 | * Throws an exception if the path to the Git binary couldn't be resolved |
||
| 69 | * by the ExecutableFinder class. |
||
| 70 | */ |
||
| 71 | 180 | public function __construct($gitBinary = null) |
|
| 72 | { |
||
| 73 | 180 | if (null === $gitBinary) { |
|
| 74 | // @codeCoverageIgnoreStart |
||
| 75 | $finder = new ExecutableFinder(); |
||
| 76 | $gitBinary = $finder->find('git'); |
||
| 77 | if (!$gitBinary) { |
||
| 78 | throw new GitException('Unable to find the Git executable.'); |
||
| 79 | } |
||
| 80 | // @codeCoverageIgnoreEnd |
||
| 81 | 180 | } |
|
| 82 | |||
| 83 | 180 | $this->setGitBinary($gitBinary); |
|
| 84 | 180 | } |
|
| 85 | |||
| 86 | /** |
||
| 87 | * Gets the dispatcher used by this library to dispatch events. |
||
| 88 | * |
||
| 89 | * @return \Symfony\Component\EventDispatcher\EventDispatcherInterface |
||
| 90 | */ |
||
| 91 | 88 | public function getDispatcher() |
|
| 92 | { |
||
| 93 | 88 | if (!isset($this->dispatcher)) { |
|
| 94 | 84 | $this->dispatcher = new EventDispatcher(); |
|
| 95 | 84 | } |
|
| 96 | 88 | return $this->dispatcher; |
|
| 97 | } |
||
| 98 | |||
| 99 | /** |
||
| 100 | * Sets the dispatcher used by this library to dispatch events. |
||
| 101 | * |
||
| 102 | * @param \Symfony\Component\EventDispatcher\EventDispatcherInterface $dispatcher |
||
| 103 | * The Symfony event dispatcher object. |
||
| 104 | * |
||
| 105 | * @return \GitWrapper\GitWrapper |
||
| 106 | */ |
||
| 107 | 4 | public function setDispatcher(EventDispatcherInterface $dispatcher) |
|
| 108 | { |
||
| 109 | 4 | $this->dispatcher = $dispatcher; |
|
| 110 | 4 | return $this; |
|
| 111 | } |
||
| 112 | |||
| 113 | /** |
||
| 114 | * Sets the path to the Git binary. |
||
| 115 | * |
||
| 116 | * @param string $gitBinary |
||
| 117 | * Path to the Git binary. |
||
| 118 | * |
||
| 119 | * @return \GitWrapper\GitWrapper |
||
| 120 | */ |
||
| 121 | 180 | public function setGitBinary($gitBinary) |
|
| 122 | { |
||
| 123 | 180 | $this->gitBinary = $gitBinary; |
|
| 124 | 180 | return $this; |
|
| 125 | } |
||
| 126 | |||
| 127 | /** |
||
| 128 | * Returns the path to the Git binary. |
||
| 129 | * |
||
| 130 | * @return string |
||
| 131 | */ |
||
| 132 | 92 | public function getGitBinary() |
|
| 133 | { |
||
| 134 | 92 | return $this->gitBinary; |
|
| 135 | } |
||
| 136 | |||
| 137 | /** |
||
| 138 | * Sets an environment variable that is defined only in the scope of the Git |
||
| 139 | * command. |
||
| 140 | * |
||
| 141 | * @param string $var |
||
| 142 | * The name of the environment variable, e.g. "HOME", "GIT_SSH". |
||
| 143 | * @param mixed $default |
||
|
|
|||
| 144 | * The value of the environment variable is not set, defaults to null. |
||
| 145 | * |
||
| 146 | * @return \GitWrapper\GitWrapper |
||
| 147 | */ |
||
| 148 | 20 | public function setEnvVar($var, $value) |
|
| 153 | |||
| 154 | /** |
||
| 155 | * Unsets an environment variable that is defined only in the scope of the |
||
| 156 | * Git command. |
||
| 157 | * |
||
| 158 | * @param string $var |
||
| 159 | * The name of the environment variable, e.g. "HOME", "GIT_SSH". |
||
| 160 | * |
||
| 161 | * @return \GitWrapper\GitWrapper |
||
| 162 | */ |
||
| 163 | 8 | public function unsetEnvVar($var) |
|
| 168 | |||
| 169 | /** |
||
| 170 | * Returns an environment variable that is defined only in the scope of the |
||
| 171 | * Git command. |
||
| 172 | * |
||
| 173 | * @param string $var |
||
| 174 | * The name of the environment variable, e.g. "HOME", "GIT_SSH". |
||
| 175 | * @param mixed $default |
||
| 176 | * The value returned if the environment variable is not set, defaults to |
||
| 177 | * null. |
||
| 178 | * |
||
| 179 | * @return mixed |
||
| 180 | */ |
||
| 181 | 24 | public function getEnvVar($var, $default = null) |
|
| 185 | |||
| 186 | /** |
||
| 187 | * Returns the associative array of environment variables that are defined |
||
| 188 | * only in the scope of the Git command. |
||
| 189 | * |
||
| 190 | * @return array |
||
| 191 | */ |
||
| 192 | 88 | public function getEnvVars() |
|
| 196 | |||
| 197 | /** |
||
| 198 | * Sets the timeout of the Git command. |
||
| 199 | * |
||
| 200 | * @param int $timeout |
||
| 201 | * The timeout in seconds. |
||
| 202 | * |
||
| 203 | * @return \GitWrapper\GitWrapper |
||
| 204 | */ |
||
| 205 | 4 | public function setTimeout($timeout) |
|
| 210 | |||
| 211 | /** |
||
| 212 | * Gets the timeout of the Git command. |
||
| 213 | * |
||
| 214 | * @return int |
||
| 215 | * The timeout in seconds. |
||
| 216 | */ |
||
| 217 | 88 | public function getTimeout() |
|
| 221 | |||
| 222 | /** |
||
| 223 | * Sets the options passed to proc_open() when executing the Git command. |
||
| 224 | * |
||
| 225 | * @param array $timeout |
||
| 226 | * The options passed to proc_open(). |
||
| 227 | * |
||
| 228 | * @return \GitWrapper\GitWrapper |
||
| 229 | */ |
||
| 230 | 4 | public function setProcOptions(array $options) |
|
| 235 | |||
| 236 | /** |
||
| 237 | * Gets the options passed to proc_open() when executing the Git command. |
||
| 238 | * |
||
| 239 | * @return array |
||
| 240 | */ |
||
| 241 | 88 | public function getProcOptions() |
|
| 245 | |||
| 246 | /** |
||
| 247 | * Set an alternate private key used to connect to the repository. |
||
| 248 | * |
||
| 249 | * This method sets the GIT_SSH environment variable to use the wrapper |
||
| 250 | * script included with this library. It also sets the custom GIT_SSH_KEY |
||
| 251 | * and GIT_SSH_PORT environment variables that are used by the script. |
||
| 252 | * |
||
| 253 | * @param string $privateKey |
||
| 254 | * Path to the private key. |
||
| 255 | * @param int $port |
||
| 256 | * Port that the SSH server being connected to listens on, defaults to 22. |
||
| 257 | * @param string|null $wrapper |
||
| 258 | * Path the the GIT_SSH wrapper script, defaults to null which uses the |
||
| 259 | * script included with this library. |
||
| 260 | * |
||
| 261 | * @return \GitWrapper\GitWrapper |
||
| 262 | * |
||
| 263 | * @throws \GitWrapper\GitException |
||
| 264 | * Thrown when any of the paths cannot be resolved. |
||
| 265 | */ |
||
| 266 | 24 | public function setPrivateKey($privateKey, $port = 22, $wrapper = null) |
|
| 284 | |||
| 285 | /** |
||
| 286 | * Unsets the private key by removing the appropriate environment variables. |
||
| 287 | * |
||
| 288 | * @return \GitWrapper\GitWrapper |
||
| 289 | */ |
||
| 290 | 4 | public function unsetPrivateKey() |
|
| 298 | |||
| 299 | /** |
||
| 300 | * Adds output listener. |
||
| 301 | * |
||
| 302 | * @param \GitWrapper\Event\GitOutputListenerInterface $listener |
||
| 303 | * |
||
| 304 | * @return \GitWrapper\GitWrapper |
||
| 305 | */ |
||
| 306 | public function addOutputListener(Event\GitOutputListenerInterface $listener) |
||
| 307 | { |
||
| 308 | $this |
||
| 309 | ->getDispatcher() |
||
| 310 | ->addListener(Event\GitEvents::GIT_OUTPUT, array($listener, 'handleOutput')) |
||
| 311 | ; |
||
| 312 | return $this; |
||
| 313 | } |
||
| 314 | |||
| 315 | /** |
||
| 316 | * Adds logger listener listener. |
||
| 317 | * |
||
| 318 | * @param Event\GitLoggerListener $listener |
||
| 319 | * |
||
| 320 | * @return GitWrapper |
||
| 321 | */ |
||
| 322 | 8 | public function addLoggerListener(Event\GitLoggerListener $listener) |
|
| 330 | |||
| 331 | /** |
||
| 332 | * Removes an output listener. |
||
| 333 | * |
||
| 334 | * @param \GitWrapper\Event\GitOutputListenerInterface $listener |
||
| 335 | * |
||
| 336 | * @return \GitWrapper\GitWrapper |
||
| 337 | */ |
||
| 338 | public function removeOutputListener(Event\GitOutputListenerInterface $listener) |
||
| 339 | { |
||
| 340 | $this |
||
| 341 | ->getDispatcher() |
||
| 342 | ->removeListener(Event\GitEvents::GIT_OUTPUT, array($listener, 'handleOutput')) |
||
| 343 | ; |
||
| 344 | return $this; |
||
| 345 | } |
||
| 346 | |||
| 347 | /** |
||
| 348 | * Set whether or not to stream real-time output to STDOUT and STDERR. |
||
| 349 | * |
||
| 350 | * @param boolean $streamOutput |
||
| 351 | * |
||
| 352 | * @return \GitWrapper\GitWrapper |
||
| 353 | */ |
||
| 354 | public function streamOutput($streamOutput = true) |
||
| 355 | { |
||
| 356 | if ($streamOutput && !isset($this->streamListener)) { |
||
| 357 | $this->streamListener = new Event\GitOutputStreamListener(); |
||
| 358 | $this->addOutputListener($this->streamListener); |
||
| 359 | } |
||
| 360 | |||
| 361 | if (!$streamOutput && isset($this->streamListener)) { |
||
| 362 | $this->removeOutputListener($this->streamListener); |
||
| 363 | unset($this->streamListener); |
||
| 364 | } |
||
| 365 | |||
| 366 | return $this; |
||
| 367 | } |
||
| 368 | |||
| 369 | /** |
||
| 370 | * Returns an object that interacts with a working copy. |
||
| 371 | * |
||
| 372 | * @param string $directory |
||
| 373 | * Path to the directory containing the working copy. |
||
| 374 | * |
||
| 375 | * @return GitWorkingCopy |
||
| 376 | */ |
||
| 377 | 56 | public function workingCopy($directory) |
|
| 381 | |||
| 382 | /** |
||
| 383 | * Returns the version of the installed Git client. |
||
| 384 | * |
||
| 385 | * @return string |
||
| 386 | * |
||
| 387 | * @throws \GitWrapper\GitException |
||
| 388 | */ |
||
| 389 | 12 | public function version() |
|
| 390 | { |
||
| 391 | 12 | return $this->git('--version'); |
|
| 392 | } |
||
| 393 | |||
| 394 | /** |
||
| 395 | * Parses name of the repository from the path. |
||
| 396 | * |
||
| 397 | * For example, passing the "[email protected]:cpliakas/git-wrapper.git" |
||
| 398 | * repository would return "git-wrapper". |
||
| 399 | * |
||
| 400 | * @param string $repository |
||
| 401 | * The repository URL. |
||
| 402 | * |
||
| 403 | * @return string |
||
| 404 | */ |
||
| 405 | 8 | public static function parseRepositoryName($repository) |
|
| 419 | |||
| 420 | /** |
||
| 421 | * Executes a `git init` command. |
||
| 422 | * |
||
| 423 | * Create an empty git repository or reinitialize an existing one. |
||
| 424 | * |
||
| 425 | * @param string $directory |
||
| 426 | * The directory being initialized. |
||
| 427 | * @param array $options |
||
| 428 | * (optional) An associative array of command line options. |
||
| 429 | * |
||
| 430 | * @return \GitWrapper\GitWorkingCopy |
||
| 431 | * |
||
| 432 | * @throws \GitWrapper\GitException |
||
| 433 | * |
||
| 434 | * @see GitWorkingCopy::cloneRepository() |
||
| 435 | * |
||
| 436 | * @ingroup commands |
||
| 437 | */ |
||
| 438 | 48 | public function init($directory, array $options = array()) |
|
| 445 | |||
| 446 | /** |
||
| 447 | * Executes a `git clone` command and returns a working copy object. |
||
| 448 | * |
||
| 449 | * Clone a repository into a new directory. Use GitWorkingCopy::clone() |
||
| 450 | * instead for more readable code. |
||
| 451 | * |
||
| 452 | * @param string $repository |
||
| 453 | * The Git URL of the repository being cloned. |
||
| 454 | * @param string $directory |
||
| 455 | * The directory that the repository will be cloned into. If null is |
||
| 456 | * passed, the directory will automatically be generated from the URL via |
||
| 457 | * the GitWrapper::parseRepositoryName() method. |
||
| 458 | * @param array $options |
||
| 459 | * (optional) An associative array of command line options. |
||
| 460 | * |
||
| 461 | * @return \GitWrapper\GitWorkingCopy |
||
| 462 | * |
||
| 463 | * @throws \GitWrapper\GitException |
||
| 464 | * |
||
| 465 | * @see GitWorkingCopy::cloneRepository() |
||
| 466 | * |
||
| 467 | * @ingroup commands |
||
| 468 | */ |
||
| 469 | 48 | public function cloneRepository($repository, $directory = null, array $options = array()) |
|
| 479 | |||
| 480 | /** |
||
| 481 | * Runs an arbitrary Git command. |
||
| 482 | * |
||
| 483 | * The command is simply a raw command line entry for everything after the |
||
| 484 | * Git binary. For example, a `git config -l` command would be passed as |
||
| 485 | * `config -l` via the first argument of this method. |
||
| 486 | * |
||
| 487 | * Note that no events are thrown by this method. |
||
| 488 | * |
||
| 489 | * @param string $commandLine |
||
| 490 | * The raw command containing the Git options and arguments. The Git |
||
| 491 | * binary should not be in the command, for example `git config -l` would |
||
| 492 | * translate to "config -l". |
||
| 493 | * @param string|null $cwd |
||
| 494 | * The working directory of the Git process. Defaults to null which uses |
||
| 495 | * the current working directory of the PHP process. |
||
| 496 | * |
||
| 497 | * @return string |
||
| 498 | * The STDOUT returned by the Git command. |
||
| 499 | * |
||
| 500 | * @throws \GitWrapper\GitException |
||
| 501 | * |
||
| 502 | * @see GitWrapper::run() |
||
| 503 | */ |
||
| 504 | 24 | public function git($commandLine, $cwd = null) |
|
| 510 | |||
| 511 | /** |
||
| 512 | * Runs a Git command. |
||
| 513 | * |
||
| 514 | * @param \GitWrapper\GitCommand $command |
||
| 515 | * The Git command being executed. |
||
| 516 | * @param string|null $cwd |
||
| 517 | * Explicitly specify the working directory of the Git process. Defaults |
||
| 518 | * to null which automatically sets the working directory based on the |
||
| 519 | * command being executed relative to the working copy. |
||
| 520 | * |
||
| 521 | * @return string |
||
| 522 | * The STDOUT returned by the Git command. |
||
| 523 | * |
||
| 524 | * @throws \GitWrapper\GitException |
||
| 525 | * |
||
| 526 | * @see Process |
||
| 527 | */ |
||
| 528 | 88 | public function run(GitCommand $command, $cwd = null) |
|
| 529 | { |
||
| 530 | 88 | $wrapper = $this; |
|
| 531 | 88 | $process = new GitProcess($this, $command, $cwd); |
|
| 532 | 84 | $process->run(function ($type, $buffer) use ($wrapper, $process, $command) { |
|
| 533 | 72 | $event = new Event\GitOutputEvent($wrapper, $process, $command, $type, $buffer); |
|
| 534 | 72 | $wrapper->getDispatcher()->dispatch(Event\GitEvents::GIT_OUTPUT, $event); |
|
| 535 | 84 | }); |
|
| 536 | 76 | return $command->notBypassed() ? $process->getOutput() : ''; |
|
| 537 | } |
||
| 538 | |||
| 539 | /** |
||
| 540 | * Hackish, allows us to use "clone" as a method name. |
||
| 541 | * |
||
| 542 | * $throws \BadMethodCallException |
||
| 543 | * @throws \GitWrapper\GitException |
||
| 544 | */ |
||
| 545 | 52 | View Code Duplication | public function __call($method, $args) |
| 555 | } |
||
| 556 |
This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function.
Consider the following example. The parameter
$italyis not defined by the methodfinale(...).The most likely cause is that the parameter was removed, but the annotation was not.