Result::__construct() - Code Metrics - Inspection of "Merge pull request #18 from avostrovskyi1989/maste..." - covery/php-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cd54d5...b808c3 )

unknown

created 2019-08-16 11:09 UTC

Result::__construct() C

↳ Parent: Result

Complexity

Conditions	16
Paths	13

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	63
rs	5.5666
c	0
b	0
f	0
cc	16
nc	13
nop	12

How to fix Long Method Complexity Many Parameters

<?php

namespace Covery\Client;

/**
 * Class Result
 *
 * Contains decision result data, received from Covery
 *
 * @package Covery\Client
 */
class Result
{
    /**
     * @var int
     */
    private $requestId;
    /**
     * @var string
     */
    private $type;
    /**
     * @var int
     */
    private $createdAt;
    /**
     * @var string
     */
    private $sequenceId;
    /**
     * @var string
     */
    private $merchantUserId;
    /**
     * @var int
     */
    private $score;
    /**
     * @var bool
     */
    private $accept;
    /**
     * @var bool
     */
    private $reject;
    /**
     * @var bool
     */
    private $manual;
    /**
     * @var null|string
     */
    private $reason;
    /**
     * @var null|string
     */
    private $action;
    /**
     * @var null|array
     */
    private $customResponse;

    /**
     * Result constructor.
     *
     * @param int $requestId
     * @param string $type
     * @param int $createdAt
     * @param string $sequenceId
     * @param string $merchantUserId
     * @param int $score
     * @param bool $accept
     * @param bool $reject
     * @param bool $manual
     * @param null|string $reason
     * @param null|string $action
     * @param null|array $customResponse
     */
    public function __construct(
        $requestId,
        $type,
        $createdAt,
        $sequenceId,
        $merchantUserId,
        $score,
        $accept,
        $reject,
        $manual,
        $reason = null,
        $action = null,
        $customResponse = null
    ) {
        if (!is_int($requestId)) {
            throw new \InvalidArgumentException('Request ID must be integer');
        }
        if (!is_string($type)) {
            throw new \InvalidArgumentException('Type must be string');
        }
        if (!is_int($createdAt)) {
            throw new \InvalidArgumentException('Created At must be integer');
        }
        if (!is_string($sequenceId)) {
            throw new \InvalidArgumentException('Sequence Id must be string');
        }
        if (!is_string($merchantUserId)) {
            throw new \InvalidArgumentException('Merchant User Id must be string');
        }
        if (!is_int($score)) {
            throw new \InvalidArgumentException('Score must be integer');
        }
        if (!is_bool($accept)) {
            throw new \InvalidArgumentException('Accept flag must be boolean');
        }
        if (!is_bool($reject)) {
            throw new \InvalidArgumentException('Reject flag must be boolean');
        }
        if (!is_bool($manual)) {
            throw new \InvalidArgumentException('Manual flag must be boolean');
        }
        if ($reason !== null && !is_string($reason)) {
            throw new \InvalidArgumentException('Reason must be string');
        }
        if ($action !== null && !is_string($action)) {
            throw new \InvalidArgumentException('Action must be string');
        }
        if ($customResponse !== null && !is_array($customResponse)) {
            throw new \InvalidArgumentException('Custom Response must be array');
        }
        $this->requestId = $requestId;
        $this->type = $type;
        $this->createdAt = $createdAt;
        $this->sequenceId = $sequenceId;
        $this->merchantUserId = $merchantUserId;
        $this->score = $score;
        $this->accept = $accept;
        $this->reject = $reject;
        $this->manual = $manual;
        $this->reason = $reason;
        $this->action = $action;
        $this->customResponse = $customResponse;
    }

    /**
     * @return int
     */
    public function getRequestId()
    {
        return $this->requestId;
    }

    /**
     * @return string
     */
    public function getType()
    {
        return $this->type;
    }

    /**
     * @return int
     */
    public function getCreatedAt()
    {
        return $this->createdAt;
    }

    /**
     * @return string
     */
    public function getSequenceId()
    {
        return $this->sequenceId;
    }

    /**
     * @return string
     */
    public function getMerchantUserId()
    {
        return $this->merchantUserId;
    }

    /**
     * @return int
     */
    public function getScore()
    {
        return $this->score;
    }

    /**
     * @return boolean
     */
    public function isAccept()
    {
        return $this->accept;
    }

    /**
     * @return boolean
     */
    public function isReject()
    {
        return $this->reject;
    }

    /**
     * @return boolean
     */
    public function isManual()
    {
        return $this->manual;
    }

    /**
     * @return string|null
     */
    public function getReason()
    {
        return $this->reason;
    }

    /**
     * @return string|null
     */
    public function getAction()
    {
        return $this->action;
    }

    /**
     * @return array|null
     */
    public function getCustomResponse()
    {
        return $this->customResponse;
    }
}


1			<?php
2
3			namespace Covery\Client;
4
5			/**
6			* Class Result
7			*
8			* Contains decision result data, received from Covery
9			*
10			* @package Covery\Client
11			*/
12			class Result
13			{
14			/**
15			* @var int
16			*/
17			private $requestId;
18			/**
19			* @var string
20			*/
21			private $type;
22			/**
23			* @var int
24			*/
25			private $createdAt;
26			/**
27			* @var string
28			*/
29			private $sequenceId;
30			/**
31			* @var string
32			*/
33			private $merchantUserId;
34			/**
35			* @var int
36			*/
37			private $score;
38			/**
39			* @var bool
40			*/
41			private $accept;
42			/**
43			* @var bool
44			*/
45			private $reject;
46			/**
47			* @var bool
48			*/
49			private $manual;
50			/**
51			* @var null\|string
52			*/
53			private $reason;
54			/**
55			* @var null\|string
56			*/
57			private $action;
58			/**
59			* @var null\|array
60			*/
61			private $customResponse;
62
63			/**
64			* Result constructor.
65			*
66			* @param int $requestId
67			* @param string $type
68			* @param int $createdAt
69			* @param string $sequenceId
70			* @param string $merchantUserId
71			* @param int $score
72			* @param bool $accept
73			* @param bool $reject
74			* @param bool $manual
75			* @param null\|string $reason
76			* @param null\|string $action
77			* @param null\|array $customResponse
78			*/
79			public function __construct(
80			$requestId,
81			$type,
82			$createdAt,
83			$sequenceId,
84			$merchantUserId,
85			$score,
86			$accept,
87			$reject,
88			$manual,
89			$reason = null,
90			$action = null,
91			$customResponse = null
92			) {
93			if (!is_int($requestId)) {
94			throw new \InvalidArgumentException('Request ID must be integer');
95			}
96			if (!is_string($type)) {
97			throw new \InvalidArgumentException('Type must be string');
98			}
99			if (!is_int($createdAt)) {
100			throw new \InvalidArgumentException('Created At must be integer');
101			}
102			if (!is_string($sequenceId)) {
103			throw new \InvalidArgumentException('Sequence Id must be string');
104			}
105			if (!is_string($merchantUserId)) {
106			throw new \InvalidArgumentException('Merchant User Id must be string');
107			}
108			if (!is_int($score)) {
109			throw new \InvalidArgumentException('Score must be integer');
110			}
111			if (!is_bool($accept)) {
112			throw new \InvalidArgumentException('Accept flag must be boolean');
113			}
114			if (!is_bool($reject)) {
115			throw new \InvalidArgumentException('Reject flag must be boolean');
116			}
117			if (!is_bool($manual)) {
118			throw new \InvalidArgumentException('Manual flag must be boolean');
119			}
120			if ($reason !== null && !is_string($reason)) {
121			throw new \InvalidArgumentException('Reason must be string');
122			}
123			if ($action !== null && !is_string($action)) {
124			throw new \InvalidArgumentException('Action must be string');
125			}
126			if ($customResponse !== null && !is_array($customResponse)) {
127			throw new \InvalidArgumentException('Custom Response must be array');
128			}
129			$this->requestId = $requestId;
130			$this->type = $type;
131			$this->createdAt = $createdAt;
132			$this->sequenceId = $sequenceId;
133			$this->merchantUserId = $merchantUserId;
134			$this->score = $score;
135			$this->accept = $accept;
136			$this->reject = $reject;
137			$this->manual = $manual;
138			$this->reason = $reason;
139			$this->action = $action;
140			$this->customResponse = $customResponse;
141			}
142
143			/**
144			* @return int
145			*/
146			public function getRequestId()
147			{
148			return $this->requestId;
149			}
150
151			/**
152			* @return string
153			*/
154			public function getType()
155			{
156			return $this->type;
157			}
158
159			/**
160			* @return int
161			*/
162			public function getCreatedAt()
163			{
164			return $this->createdAt;
165			}
166
167			/**
168			* @return string
169			*/
170			public function getSequenceId()
171			{
172			return $this->sequenceId;
173			}
174
175			/**
176			* @return string
177			*/
178			public function getMerchantUserId()
179			{
180			return $this->merchantUserId;
181			}
182
183			/**
184			* @return int
185			*/
186			public function getScore()
187			{
188			return $this->score;
189			}
190
191			/**
192			* @return boolean
193			*/
194			public function isAccept()
195			{
196			return $this->accept;
197			}
198
199			/**
200			* @return boolean
201			*/
202			public function isReject()
203			{
204			return $this->reject;
205			}
206
207			/**
208			* @return boolean
209			*/
210			public function isManual()
211			{
212			return $this->manual;
213			}
214
215			/**
216			* @return string\|null
217			*/
218			public function getReason()
219			{
220			return $this->reason;
221			}
222
223			/**
224			* @return string\|null
225			*/
226			public function getAction()
227			{
228			return $this->action;
229			}
230
231			/**
232			* @return array\|null
233			*/
234			public function getCustomResponse()
235			{
236			return $this->customResponse;
237			}
238			}
239

covery / php-client

Push — master ( cd54d5...b808c3 )

Result::__construct() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity Many Parameters

Long Method

Many Parameters

Duplication Side-by-Side

Filter issues like