Issues in UsersPresenter.php (master) - Issues in master - cothema/cmsbe-user - Measure and Improve Code Quality continuously with Scrutinizer

Issues (59)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/presenters/UsersPresenter.php (51 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace App\Presenters;

use Nette;
use Nette\Application\UI\Form;
use Cothema\Model as PModel;

/**
 * @Secured
 * @Secured\User(loggedIn)
 * @Secured\Role(admin)
 *
 * Users Presenter
 */
class UsersPresenter extends BasePresenter
{

    public function renderChangePass()
    {
        $navbar   = [];
        $navbar[] = (object) ['name' => 'Uživatelé', 'link' => 'Users:list'];
        $navbar[] = (object) ['name' => 'Detail'];
        $navbar[] = (object) ['name' => 'Změna hesla'];

        $this->template->navbar = $navbar;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function renderList()
    {
        $navbar   = [];
        $navbar[] = (object) ['name' => 'Uživatelé'];

        $this->template->navbar = $navbar;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $usersDao = $this->em->getRepository(PModel\User\User::getClassName());
        $users    = $usersDao->findBy(['active' => 1]);

        $this->template->users = $users;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function renderListUnactive()

    {
        $navbar   = [];
        $navbar[] = (object) ['name' => 'Uživatelé', 'link' => 'Users:list'];
        $navbar[] = (object) ['name' => 'Neaktivní'];

        $this->template->navbar = $navbar;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $usersDao = $this->em->getRepository(PModel\User\User::getClassName());
        $users    = $usersDao->findBy(['active' => 0]);

        $this->template->users = $users;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * @Secured
     * @Secured\User(loggedIn)
     * @Secured\Role(usermanager)
     */
    public function renderNew()

    {
        $navbar   = [];
        $navbar[] = (object) ['name' => 'Uživatelé', 'link' => 'Users:list'];
        $navbar[] = (object) ['name' => 'Nový'];

        $this->template->navbar = $navbar;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function renderChange()

    {
        $navbar   = [];
        $navbar[] = (object) ['name' => 'Uživatelé', 'link' => 'Users:list'];
        $navbar[] = (object) ['name' => 'Úprava'];

        $this->template->navbar = $navbar;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $this->notYetImplemented();
    }

    public function renderProfile()
    {
        $navbar   = [];
        $navbar[] = (object) ['name' => 'Uživatelé', 'link' => 'Users:list'];
        $navbar[] = (object) ['name' => 'Profil'];

        $this->template->navbar = $navbar;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $id = ($this->getParameter('id') !== null) ? $this->getParameter('id') : $this->getUser()->getIdentity()->id;

        $user        = $this->em->getRepository(PModel\User\User::getClassName());
        $profileUser = $user->find($id);

        $this->template->profileUser = $profileUser;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $isActual = false;
        if ($this->getUser()->isLoggedIn() && $this->getUser()->getIdentity()->id
            == $profileUser->id) {
            $isActual = true;
        }

        $this->template->isActual = $isActual;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    public function renderGroups()

    {
        $navbar   = [];
        $navbar[] = (object) ['name' => 'Uživatelé', 'link' => 'Users:list'];
        $navbar[] = (object) ['name' => 'Skupiny'];

        $this->template->navbar = $navbar;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $userGroupsDao = $this->em->getRepository(PModel\User\Group::getClassName());
        $userGroups    = $userGroupsDao->findAll();

        $this->template->userGroups = $userGroups;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * @Secured
     * @Secured\User(loggedIn)
     * @Secured\Role(superadmin)
     */
    public function renderLogActivity()

    {
        $navbar   = [];
        $navbar[] = (object) ['link' => 'Users:list', 'name' => 'Uživatelé'];
        $navbar[] = (object) ['name' => 'Sledování přihlášení'];

        $this->template->navbar = $navbar;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $activityDao = $this->em->getRepository(PModel\User\LogActivity::getClassName());
        $activity    = $activityDao->findBy([], ['id' => 'DESC'], 30);

        $this->template->activity = $activity;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    protected function createComponentChangePasswordForm()
    {
        $form = new Nette\Application\UI\Form;
        $form->addPassword('oldpassw', 'Staré heslo:')
            ->setRequired('Prosím, zadejte své staré heslo.')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->getControlPrototype()->class('form-control');

        $form->addPassword('newpassw', 'Nové heslo:')
            ->setRequired('Prosím, zadejte své nové heslo.')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->getControlPrototype()->class('form-control');

        $form->addPassword('newpassw2', 'Nové heslo (znovu):')
            ->setRequired('Prosím, zadejte své nové heslo pro kontrolu.')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->addRule(
                Form::EQUAL,
                "Zadaná nová hesla se neshodují.",
                $form["newpassw"]
            )
            ->getControlPrototype()->class('form-control');

        $form->addSubmit('send', 'Změnit heslo')
            ->getControlPrototype()->class('btn btn-success');

        $form->onSuccess[] = [$this, 'changePasswordFormSucceeded'];
        return $form;
    }

    protected function createComponentChangeProfileForm()
    {
        $userDao = $this->em->getRepository(PModel\User\User::getClassName());
        $user    = $userDao->find($this->getUser()->id);

        $form = new Nette\Application\UI\Form;
        $form->addText('firstname', 'Jméno:')
            ->setRequired('Prosím, zadejte své své jméno.')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setDefaultValue($user->firstName)
            ->getControlPrototype()->class('form-control');

        $form->addText('lastname', 'Příjmení:')
            ->setRequired('Prosím, zadejte své nové příjmení.')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setDefaultValue($user->lastName)
            ->getControlPrototype()->class('form-control');

        $form->addText('email', 'Email:')
            ->setRequired('Prosím, zadejte svou emailovou adesu.')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setDefaultValue($user->email)
            ->getControlPrototype()->class('form-control');

        $form->addSubmit('send', 'Uložit změny')
            ->getControlPrototype()->class('btn btn-success');

        $form->onSuccess[] = [$this, 'changeProfileFormSucceeded'];
        return $form;
    }

    public function createComponentUsersNewForm()
    {
        $form = new Form;

        $form->addText('login', 'Přihlašovací jméno:')
            ->setRequired('Prosím, zadejte přihlašovací jméno.')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->getControlPrototype()->class('form-control');

        $form->addText('firstname', 'Jméno:')
            ->setRequired('Prosím, zadejte jméno.')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->getControlPrototype()->class('form-control');

        $form->addText('lastname', 'Příjmení:')
            ->setRequired('Prosím, zadejte příjmení.')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->getControlPrototype()->class('form-control');

        $form->addText('email', 'Email:')
            ->setRequired('Prosím, zadejte emailovou adesu.')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->getControlPrototype()->class('form-control mediumwidth');

        $form->addPassword('password', 'Heslo:')
            ->setRequired('Prosím, zadejte heslo.')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->getControlPrototype()->class('form-control mediumwidth');

        $form->addPassword('passwordValid', 'Heslo znovu:')
            ->setRequired('Prosím, zadejte heslo pro kontrolu.')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->getControlPrototype()->class('form-control mediumwidth');

        $form->addSubmit('send', 'Vytvořit uživatelský profil')
            ->getControlPrototype()->class('btn btn-success');

        $form->onSuccess[] = [$this, 'usersNewFormSucceeded'];
        return $form;
    }

    public function createComponentUsersChangeForm()
    {
        $userDao = $this->em->getRepository(PModel\User\User::getClassName());
        $user    = $userDao->find($this->getUser()->id);

        $form = new Form;

        $form->addText('login', 'Přihlašovací jméno:')
            ->setRequired('Prosím, zadejte přihlašovací jméno.')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setDisabled()
            ->setValue($user->username)
            ->getControlPrototype()->class('form-control');

        $form->addText('firstname', 'Jméno:')
            ->setRequired('Prosím, zadejte jméno.')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setDefaultValue($user->firstName)
            ->getControlPrototype()->class('form-control');

        $form->addText('lastname', 'Příjmení:')
            ->setRequired('Prosím, zadejte příjmení.')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setDefaultValue($user->lastName)
            ->getControlPrototype()->class('form-control');

        $form->addText('email', 'Email:')
            ->setRequired('Prosím, zadejte emailovou adesu.')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setDefaultValue($user->email)
            ->getControlPrototype()->class('form-control mediumwidth');

        $form->addSubmit('send', 'Upravit uživatelský profil')
            ->getControlPrototype()->class('btn btn-warning');

        $form->onSuccess[] = [$this, 'usersNewFormSucceeded'];
        return $form;
    }

    public function usersNewFormSucceeded()
    {
    }

    public function handleActive($id)

    {
        $this->setActiveStatus($id, true);

        $this->flashMessage(
            'Uživatel s ID '.$id.' byl úspěšně aktivován.',
            'success'
        );
        $this->redirect('this');
    }

    public function handleDeactive($id)

    {
        $this->setActiveStatus($id, false);

        $this->flashMessage(
            'Uživatel s ID '.$id.' byl úspěšně deaktivován.',
            'success'
        );
        $this->redirect('this');
    }

    /**
     * @param boolean $status
     */
    private function setActiveStatus($id, $status)
    {
        $userDao      = $this->em->getRepository(PModel\User\User::getClassName());
        $user         = $userDao->find($id);
        $user->active = (bool) $status;

        $this->em->persist($user);
        $this->em->flush();

        return true;
    }

    public function changeProfileFormSucceeded($form)
    {
        $values = $form->getValues(true);

        $userDao         = $this->em->getRepository(PModel\User\User::getClassName());
        $user            = $userDao->find($this->getUser()->id);
        $user->firstName = $values['firstname'];
        $user->lastName  = $values['lastname'];
        $user->email     = $values['email'];

        $this->em->persist($user);
        $this->em->flush();

        $this->flashMessage('Údaje o uživateli byly úspěšně uloženy.', 'success');
        $this->redirect('Users:profile');
    }

    public function changePasswordFormSucceeded($form)
    {
        $values = $form->getValues();
        $userId = $this->getUser()->id;

        $fOldPass = $values["oldpassw"];
        $fNewPass = $values["newpassw"];

        try {
            $this->getUser()->getAuthenticator()->changePassword(
                $userId,
                $fOldPass,
                $fNewPass
            );

            $this->flashMessage('Vaše heslo bylo úspěšně změněno.', 'success');
            $this->redirect('Users:profile');
        } catch (Nette\Security\AuthenticationException $e) {
            $form->addError('Zadané staré heslo není správné.');
        }
    }
}


Issues (59)

Security Analysis no request data

src/presenters/UsersPresenter.php (51 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace App\Presenters;
4
5			use Nette;
6			use Nette\Application\UI\Form;
7			use Cothema\Model as PModel;
8
9			/**
10			* @Secured
11			* @Secured\User(loggedIn)
12			* @Secured\Role(admin)
13			*
14			* Users Presenter
15			*/
16			class UsersPresenter extends BasePresenter
17			{
18
19			public function renderChangePass()
20			{
21			$navbar = [];
22			$navbar[] = (object) ['name' => 'Uživatelé', 'link' => 'Users:list'];
23			$navbar[] = (object) ['name' => 'Detail'];
24			$navbar[] = (object) ['name' => 'Změna hesla'];
25
26			$this->template->navbar = $navbar;
			0 ignored issues – show Documentation introduced 2016-09-13 07:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$template` is declared private in `Nette\Application\UI\Control`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2016-09-13 07:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `navbar` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
27			}
28
29			public function renderList()
30			{
31			$navbar = [];
32			$navbar[] = (object) ['name' => 'Uživatelé'];
33
34			$this->template->navbar = $navbar;
			0 ignored issues – show Documentation introduced 2016-09-13 07:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$template` is declared private in `Nette\Application\UI\Control`. Since you implemented `__get()`, maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2016-09-13 07:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `navbar` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
35
36			$usersDao = $this->em->getRepository(PModel\User\User::getClassName());
37			$users = $usersDao->findBy(['active' => 1]);
38

cothema / cmsbe-user

Issues (59)

Security Analysis no request data

src/presenters/UsersPresenter.php (51 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like