Issues in PluginNode.php (master) - Issues in master - cosmocode/dokuwiki-plugin-prosemirror - Measure and Improve Code Quality continuously with Scrutinizer

Issues (109)

parser/PluginNode.php (1 issue)

Labels

Bug 1

Severity

Minor 1

<?php

namespace dokuwiki\plugin\prosemirror\parser;

class PluginNode extends Node implements InlineNodeInterface
{
    protected $textNode;

    public function __construct($data, Node $parent, Node $previous = null)
    {
        $this->textNode = new TextNode($data['content'][0], $this, $previous);
    }

    public function toSyntax()
    {
        return $this->textNode->toSyntax();
    }

    /**
     * @param string $markType
     */
    public function increaseMark($markType)
    {
        return $this->textNode->increaseMark($markType);
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    public function getStartingNodeMarkScore($markType)
    {
        return $this->textNode->getStartingNodeMarkScore($markType);
    }
}


1			<?php
2
3			namespace dokuwiki\plugin\prosemirror\parser;
4
5			class PluginNode extends Node implements InlineNodeInterface
6			{
7			protected $textNode;
8
9			public function __construct($data, Node $parent, Node $previous = null)
10			{
11			$this->textNode = new TextNode($data['content'][0], $this, $previous);
12			}
13
14			public function toSyntax()
15			{
16			return $this->textNode->toSyntax();
17			}
18
19			/**
20			* @param string $markType
21			*/
22			public function increaseMark($markType)
23			{
24			return $this->textNode->increaseMark($markType);
			0 ignored issues – show Bug introduced 2018-05-02 11:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `$this->textNode->increaseMark($markType)` targeting `dokuwiki\plugin\prosemir...extNode::increaseMark()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
25			}
26
27			public function getStartingNodeMarkScore($markType)
28			{
29			return $this->textNode->getStartingNodeMarkScore($markType);
30			}
31			}
32

cosmocode / dokuwiki-plugin-prosemirror

Issues (109)

parser/PluginNode.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like