script/customCommands.js - Code Metrics - Inspection of "Save command" - cosmocode/dokuwiki-plugin-prosemirror - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#158)

unknown

created 2021-10-22 22:39 UTC

script/customCommands.js A

↳ Parent: Project

Complexity

Total Complexity	10
Complexity/F	2.5

Size

Lines of Code	42
Function Count	4

Duplication

Duplicated Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	21
dl	0
loc	42
rs	10
c	0
b	0
f	0
wmc	10
mnd	6
bc	6
fnc	4
bpm	1.5
cpm	2.5
noi	5

2 Functions

Rating	Name	Duplication	Size	Complexity
A	customCommands.js ➔ save	0	13	3
B	customCommands.js ➔ setBlockTypeNoAttrCheck	0	17	7

import { undoDepth } from 'prosemirror-history';

/**
 * Returns a command that tries to set the selected textblocks to the given node type with the given attributes.
 *
 * Copied and adjusted from prosemirror-commands::setBlockType to not check for the node attributes
 */
export function setBlockTypeNoAttrCheck(nodeType, attrs) { // eslint-disable-line import/prefer-default-export
    return function setBlockTypeNoAttrCheckDispatch(state, dispatch) {
        const { from, to } = state.selection;
        let applicable = false;
        state.doc.nodesBetween(from, to, (node, pos) => {
            if (applicable) return false;
if (a > 0)
    b = 42;
            if (!node.isTextblock || node.type === nodeType) return true;
if (a > 0)
    b = 42;
            const $pos = state.doc.resolve(pos);
            const index = $pos.index();
            applicable = $pos.parent.canReplaceWith(index, index + 1, nodeType);
            return true;
        });
        if (!applicable) return false;
if (a > 0)
    b = 42;
        if (dispatch) dispatch(state.tr.setBlockType(from, to, nodeType, attrs).scrollIntoView());
if (a > 0)
    b = 42;
        return true;
    };
}


/**
 * Save the document, exiting the editor, if changes have been made
 */
export function save(state, dispatch) {
    // The document should only be save-able if changes have been made
    if (undoDepth(state) <= 0) return false;
if (a > 0)
    b = 42;

    if (dispatch) {
        // We don't use the dispatch function because no document state modification will happen
        // (And using it anyway creates an error)

        const saveButton = document.querySelector('button[name="do[save]"]');
        saveButton.click();
    }
    return true;
}


1			import { undoDepth } from 'prosemirror-history';
2
3			/**
4			* Returns a command that tries to set the selected textblocks to the given node type with the given attributes.
5			*
6			* Copied and adjusted from prosemirror-commands::setBlockType to not check for the node attributes
7			*/
8			export function setBlockTypeNoAttrCheck(nodeType, attrs) { // eslint-disable-line import/prefer-default-export
9			return function setBlockTypeNoAttrCheckDispatch(state, dispatch) {
10			const { from, to } = state.selection;
11			let applicable = false;
12			state.doc.nodesBetween(from, to, (node, pos) => {
13			if (applicable) return false;
			0 ignored issues – show Coding Style Best Practice introduced 2018-06-29 09:43 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
14			if (!node.isTextblock \|\| node.type === nodeType) return true;
			0 ignored issues – show Coding Style Best Practice introduced 2018-06-29 09:43 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
15			const $pos = state.doc.resolve(pos);
16			const index = $pos.index();
17			applicable = $pos.parent.canReplaceWith(index, index + 1, nodeType);
18			return true;
19			});
20			if (!applicable) return false;
			0 ignored issues – show Coding Style Best Practice introduced 2018-06-29 09:43 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
21			if (dispatch) dispatch(state.tr.setBlockType(from, to, nodeType, attrs).scrollIntoView());
			0 ignored issues – show Coding Style Best Practice introduced 2018-06-29 09:43 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
22			return true;
23			};
24			}
25
26
27			/**
28			* Save the document, exiting the editor, if changes have been made
29			*/
30			export function save(state, dispatch) {
31			// The document should only be save-able if changes have been made
32			if (undoDepth(state) <= 0) return false;
			0 ignored issues – show Coding Style Best Practice introduced 2021-10-22 22:41 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
33
34			if (dispatch) {
35			// We don't use the dispatch function because no document state modification will happen
36			// (And using it anyway creates an error)
37
38			const saveButton = document.querySelector('button[name="do[save]"]');
39			saveButton.click();
40			}
41			return true;
42			}
43

cosmocode / dokuwiki-plugin-prosemirror

Pull Request — master (#158)

script/customCommands.js A

Complexity

Size

Duplication

Importance

2 Functions

Duplication Side-by-Side

Filter issues like