corretgecom / PHPCI

PHPCI/Plugin/PhpMessDetector.php

Doc Comments +4 added lines, -4 removed lines

@@ -132,7 +132,7 @@ 
     /**
      * Override a default setting.
      * @param $options
-     * @param $key
+     * @param string $key
      */
     protected function overrideSetting($options, $key)
     {
@@ -143,8 +143,8 @@ 
 
     /**
      * Process PHPMD's XML output report.
-     * @param $xmlString
-     * @return array
+     * @param string $xmlString
+     * @return integer
      * @throws \Exception
      */
     protected function processReport($xmlString)
@@ -202,7 +202,7 @@ 
 
     /**
      * Execute PHP Mess Detector.
-     * @param $binaryPath
+     * @param null|string $binaryPath
      */
     protected function executePhpMd($binaryPath)
     {

Spacing +5 added lines, -5 removed lines

@@ -193,7 +193,7 @@ 
 
         foreach ($this->rules as &$rule) {
             if (strpos($rule, '/') !== false) {
-                $rule = $this->phpci->buildPath . $rule;
+                $rule = $this->phpci->buildPath.$rule;
             }
         }
 
@@ -206,18 +206,18 @@ 
      */
     protected function executePhpMd($binaryPath)
     {
-        $cmd = $binaryPath . ' "%s" xml %s %s %s';
+        $cmd = $binaryPath.' "%s" xml %s %s %s';
 
         $path = $this->getTargetPath();
 
         $ignore = '';
         if (count($this->ignore)) {
-            $ignore = ' --exclude ' . implode(',', $this->ignore);
+            $ignore = ' --exclude '.implode(',', $this->ignore);
         }
 
         $suffixes = '';
         if (count($this->suffixes)) {
-            $suffixes = ' --suffixes ' . implode(',', $this->suffixes);
+            $suffixes = ' --suffixes '.implode(',', $this->suffixes);
         }
 
         // Disable exec output logging, as we don't want the XML report in the log:
@@ -242,7 +242,7 @@ 
      */
     protected function getTargetPath()
     {
-        $path = $this->phpci->buildPath . $this->path;
+        $path = $this->phpci->buildPath.$this->path;
         if (!empty($this->path) && $this->path{0} == '/') {
             $path = $this->path;
             return $path;

Indentation +6 added lines, -6 removed lines

@@ -1,11 +1,11 @@
 <?php
 /**
- * PHPCI - Continuous Integration for PHP
- *
- * @copyright    Copyright 2014, Block 8 Limited.
- * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
- * @link         https://www.phptesting.org/
- */
+     * PHPCI - Continuous Integration for PHP
+     *
+     * @copyright    Copyright 2014, Block 8 Limited.
+     * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
+     * @link         https://www.phptesting.org/
+     */
 
 namespace PHPCI\Service;
 

PHPCI/Plugin/PhpUnit.php

Doc Comments +4 added lines, -4 removed lines

@@ -67,7 +67,7 @@ 
 
     /**
      * Try and find the phpunit XML config file.
-     * @param $buildPath
+     * @param string $buildPath
      * @return null|string
      */
     public static function findConfigFile($buildPath)
@@ -185,7 +185,7 @@ 
     /**
      * Run the tests defined in a PHPUnit config file.
      * @param $configPath
-     * @return bool|mixed
+     * @return boolean
      */
     protected function runConfigFile($configPath)
     {
@@ -213,7 +213,7 @@ 
     /**
      * Run the PHPUnit tests in a specific directory or array of directories.
      * @param $directory
-     * @return bool|mixed
+     * @return boolean
      */
     protected function runDir($directory)
     {
@@ -235,7 +235,7 @@ 
     /**
      * @param $array
      * @param $callable
-     * @return bool|mixed
+     * @return boolean
      */
     protected function recurseArg($array, $callable)
     {

Indentation +8 added lines, -8 removed lines

@@ -1,11 +1,11 @@ 
 <?php
 /**
- * PHPCI - Continuous Integration for PHP
- *
- * @copyright    Copyright 2014, Block 8 Limited.
- * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
- * @link         https://www.phptesting.org/
- */
+     * PHPCI - Continuous Integration for PHP
+     *
+     * @copyright    Copyright 2014, Block 8 Limited.
+     * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
+     * @link         https://www.phptesting.org/
+     */
 
 namespace PHPCI\Plugin;
 
@@ -138,8 +138,8 @@ 
     }
 
     /**
-    * Runs PHP Unit tests in a specified directory, optionally using specified config file(s).
-    */
+     * Runs PHP Unit tests in a specified directory, optionally using specified config file(s).
+     */
     public function execute()
     {
         if (empty($this->xmlConfigFile) && empty($this->directory)) {

Spacing +12 added lines, -12 removed lines

@@ -72,20 +72,20 @@ 
      */
     public static function findConfigFile($buildPath)
     {
-        if (file_exists($buildPath . 'phpunit.xml')) {
+        if (file_exists($buildPath.'phpunit.xml')) {
             return 'phpunit.xml';
         }
 
-        if (file_exists($buildPath . 'tests' . DIRECTORY_SEPARATOR . 'phpunit.xml')) {
-            return 'tests' . DIRECTORY_SEPARATOR . 'phpunit.xml';
+        if (file_exists($buildPath.'tests'.DIRECTORY_SEPARATOR.'phpunit.xml')) {
+            return 'tests'.DIRECTORY_SEPARATOR.'phpunit.xml';
         }
 
-        if (file_exists($buildPath . 'phpunit.xml.dist')) {
+        if (file_exists($buildPath.'phpunit.xml.dist')) {
             return 'phpunit.xml.dist';
         }
 
-        if (file_exists($buildPath . 'tests/phpunit.xml.dist')) {
-            return 'tests' . DIRECTORY_SEPARATOR . 'phpunit.xml.dist';
+        if (file_exists($buildPath.'tests/phpunit.xml.dist')) {
+            return 'tests'.DIRECTORY_SEPARATOR.'phpunit.xml.dist';
         }
 
         return null;
@@ -133,7 +133,7 @@ 
         }
 
         if (isset($options['coverage'])) {
-            $this->coverage = ' --coverage-html ' . $this->phpci->interpolate($options['coverage']) . ' ';
+            $this->coverage = ' --coverage-html '.$this->phpci->interpolate($options['coverage']).' ';
         }
     }
 
@@ -194,13 +194,13 @@ 
         } else {
             if ($this->runFrom) {
                 $curdir = getcwd();
-                chdir($this->phpci->buildPath . DIRECTORY_SEPARATOR . $this->runFrom);
+                chdir($this->phpci->buildPath.DIRECTORY_SEPARATOR.$this->runFrom);
             }
 
             $phpunit = $this->phpci->findBinary('phpunit');
 
-            $cmd = $phpunit . ' --tap %s -c "%s" ' . $this->coverage . $this->path;
-            $success = $this->phpci->executeCommand($cmd, $this->args, $this->phpci->buildPath . $configPath);
+            $cmd = $phpunit.' --tap %s -c "%s" '.$this->coverage.$this->path;
+            $success = $this->phpci->executeCommand($cmd, $this->args, $this->phpci->buildPath.$configPath);
 
             if ($this->runFrom) {
                 chdir($curdir);
@@ -225,8 +225,8 @@ 
 
             $phpunit = $this->phpci->findBinary('phpunit');
 
-            $cmd = $phpunit . ' --tap %s "%s"';
-            $success = $this->phpci->executeCommand($cmd, $this->args, $this->phpci->buildPath . $directory);
+            $cmd = $phpunit.' --tap %s "%s"';
+            $success = $this->phpci->executeCommand($cmd, $this->args, $this->phpci->buildPath.$directory);
             chdir($curdir);
             return $success;
         }

PHPCI/Plugin/TechnicalDebt.php

Doc Comments +1 added lines, -1 removed lines

@@ -140,7 +140,7 @@
     /**
      * Gets the number and list of errors returned from the search
      *
-     * @return array
+     * @return integer
      */
     public function getErrorList()
     {

Spacing +2 added lines, -2 removed lines

@@ -126,7 +126,7 @@ 
 
         $errorCount = $this->getErrorList();
 
-        $this->phpci->log("Found $errorCount instances of " . implode(', ', $this->searches));
+        $this->phpci->log("Found $errorCount instances of ".implode(', ', $this->searches));
 
         $this->build->storeMeta('technical_debt-warnings', $errorCount);
 
@@ -163,7 +163,7 @@ 
             }
 
             // Ignore hidden files, else .git, .sass_cache, etc. all get looped over
-            if (stripos($filePath, DIRECTORY_SEPARATOR . '.') !== false) {
+            if (stripos($filePath, DIRECTORY_SEPARATOR.'.') !== false) {
                 $skipFile = true;
             }
 

Indentation +8 added lines, -8 removed lines

@@ -1,11 +1,11 @@ 
 <?php
 /**
- * PHPCI - Continuous Integration for PHP
- *
- * @copyright    Copyright 2014, Block 8 Limited.
- * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
- * @link         https://www.phptesting.org/
- */
+     * PHPCI - Continuous Integration for PHP
+     *
+     * @copyright    Copyright 2014, Block 8 Limited.
+     * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
+     * @link         https://www.phptesting.org/
+     */
 
 namespace PHPCI\Plugin;
 
@@ -122,8 +122,8 @@ 
     }
 
     /**
-    * Runs the plugin
-    */
+     * Runs the plugin
+     */
     public function execute()
     {
         $success = true;

PHPCI/Plugin/Util/Executor.php

Doc Comments +2 added lines, -2 removed lines

@@ -71,7 +71,7 @@ 
     /**
      * Check the config for any plugins specific to the branch we're currently building.
      * @param $config
-     * @param $stage
+     * @param string $stage
      * @param $pluginsToExecute
      * @return array
      */
@@ -124,7 +124,7 @@ 
     /**
      * Execute the list of plugins found for a given testing stage.
      * @param $plugins
-     * @param $stage
+     * @param string $stage
      * @return bool
      * @throws \Exception
      */

Spacing +5 added lines, -5 removed lines

@@ -82,12 +82,12 @@ 
         $branch = $build->getBranch();
 
         // If we don't have any branch-specific plugins:
-        if (!isset($config['branch-' . $branch][$stage]) || !is_array($config['branch-' . $branch][$stage])) {
+        if (!isset($config['branch-'.$branch][$stage]) || !is_array($config['branch-'.$branch][$stage])) {
             return $pluginsToExecute;
         }
 
         // If we have branch-specific plugins to execute, add them to the list to be executed:
-        $branchConfig = $config['branch-' . $branch];
+        $branchConfig = $config['branch-'.$branch];
         $plugins = $branchConfig[$stage];
 
         $runOption = 'after';
@@ -150,7 +150,7 @@ 
                 if ($stage === 'setup') {
                     // If we're in the "setup" stage, execution should not continue after
                     // a plugin has failed:
-                    throw new Exception('Plugin failed: ' . $plugin);
+                    throw new Exception('Plugin failed: '.$plugin);
                 } elseif ($stage === 'test') {
                     // If we're in the "test" stage and the plugin is not allowed to fail,
                     // then mark the build as failed:
@@ -175,7 +175,7 @@ 
         if (strpos($plugin, '\\') === false) {
             $class = str_replace('_', ' ', $plugin);
             $class = ucwords($class);
-            $class = 'PHPCI\\Plugin\\' . str_replace(' ', '', $class);
+            $class = 'PHPCI\\Plugin\\'.str_replace(' ', '', $class);
         } else {
             $class = $plugin;
         }
@@ -190,7 +190,7 @@ 
             $obj = $this->pluginFactory->buildPlugin($class, $options);
             return $obj->execute();
         } catch (\Exception $ex) {
-            $this->logger->logFailure(Lang::get('exception') . $ex->getMessage(), $ex);
+            $this->logger->logFailure(Lang::get('exception').$ex->getMessage(), $ex);
             return false;
         }
     }

PHPCI/Plugin/Util/Factory.php

Doc Comments +3 added lines, -3 removed lines

@@ -45,7 +45,7 @@ 
      * file returns a function then $this will be passed to it.
      * This enables the config file to call any public methods.
      *
-     * @param $configPath
+     * @param string $configPath
      * @return bool - true if the function exists else false.
      */
     public function addConfigFromFile($configPath)
@@ -138,8 +138,8 @@ 
 
     /**
      * Get an internal resource ID.
-     * @param null $type
-     * @param null $name
+     * @param string|null $type
+     * @param string|null $name
      * @return string
      */
     private function getInternalID($type = null, $name = null)

Spacing +6 added lines, -6 removed lines

@@ -32,7 +32,7 @@ 
 
         $self = $this;
         $this->registerResource(
-            function () use ($self) {
+            function() use ($self) {
                 return $self->getLastOptions();
             },
             'options',
@@ -88,7 +88,7 @@ 
 
         if (!$reflectedPlugin->implementsInterface(self::INTERFACE_PHPCI_PLUGIN)) {
             throw new \InvalidArgumentException(
-                "Requested class must implement " . self:: INTERFACE_PHPCI_PLUGIN
+                "Requested class must implement ".self:: INTERFACE_PHPCI_PLUGIN
             );
         }
 
@@ -144,9 +144,9 @@ 
      */
     private function getInternalID($type = null, $name = null)
     {
-        $type = $type ? : "";
-        $name = $name ? : "";
-        return $type . "-" . $name;
+        $type = $type ?: "";
+        $name = $name ?: "";
+        return $type."-".$name;
     }
 
     /**
@@ -210,7 +210,7 @@ 
             $existingArgs[] = $param->getDefaultValue();
         } else {
             throw new \DomainException(
-                "Unsatisfied dependency: " . $param->getName()
+                "Unsatisfied dependency: ".$param->getName()
             );
         }
 

PHPCI/Plugin/Util/FilesPluginInformation.php

Doc Comments +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
     protected $pluginInfo = null;
 
     /**
-     * @param $dirPath
+     * @param string $dirPath
      * @return FilesPluginInformation
      */
     public static function newFromDir($dirPath)

Spacing +2 added lines, -2 removed lines

@@ -69,7 +69,7 @@ 
     public function getPluginClasses()
     {
         return array_map(
-            function (\stdClass $plugin) {
+            function(\stdClass $plugin) {
                 return $plugin->class;
             },
             $this->getInstalledPlugins()
@@ -129,7 +129,7 @@ 
             preg_match('#namespace +([A-Za-z\\\\]+);#i', $contents, $matches);
             $namespace = $matches[1];
 
-            return $namespace . '\\' . $className;
+            return $namespace.'\\'.$className;
         } else {
             return null;
         }

PHPCI/Helper/UnixCommandExecutor.php

Spacing +1 added lines, -1 removed lines

@@ -22,6 +22,6 @@
      */
     protected function findGlobalBinary($binary)
     {
-        return trim(shell_exec('which ' . $binary));
+        return trim(shell_exec('which '.$binary));
     }
 }

Indentation +6 added lines, -6 removed lines

@@ -1,11 +1,11 @@
 <?php
 /**
- * PHPCI - Continuous Integration for PHP
- *
- * @copyright    Copyright 2014, Block 8 Limited.
- * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
- * @link         https://www.phptesting.org/
- */
+     * PHPCI - Continuous Integration for PHP
+     *
+     * @copyright    Copyright 2014, Block 8 Limited.
+     * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
+     * @link         https://www.phptesting.org/
+     */
 
 namespace PHPCI\Service;
 

PHPCI/Helper/LoginIsDisabled.php

Spacing +1 added lines, -1 removed lines

@@ -30,7 +30,7 @@
         unset($method, $params);
         
         $config = Config::getInstance();
-        $state = (bool) $config->get('phpci.authentication_settings.state', false);
+        $state = (bool)$config->get('phpci.authentication_settings.state', false);
 
         return (false !== $state);
     }

Indentation +6 added lines, -6 removed lines

@@ -1,11 +1,11 @@
 <?php
 /**
- * PHPCI - Continuous Integration for PHP
- *
- * @copyright    Copyright 2014, Block 8 Limited.
- * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
- * @link         https://www.phptesting.org/
- */
+     * PHPCI - Continuous Integration for PHP
+     *
+     * @copyright    Copyright 2014, Block 8 Limited.
+     * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
+     * @link         https://www.phptesting.org/
+     */
 
 namespace PHPCI\Service;
 

PHPCI/Helper/Email.php

Spacing +3 added lines, -3 removed lines

@@ -121,17 +121,17 @@
         $headers = '';
 
         if ($this->isHtml) {
-            $headers = 'Content-Type: text/html' . PHP_EOL;
+            $headers = 'Content-Type: text/html'.PHP_EOL;
         }
 
-        $headers .= 'From: ' . $this->getFrom() . PHP_EOL;
+        $headers .= 'From: '.$this->getFrom().PHP_EOL;
 
         $emailTo = array();
         foreach ($this->emailTo as $email => $name) {
             $thisTo = $email;
 
             if (!is_null($name)) {
-                $thisTo = '"' . $name . '" <' . $thisTo . '>';
+                $thisTo = '"'.$name.'" <'.$thisTo.'>';
             }
 
             $emailTo[] = $thisTo;

Indentation +6 added lines, -6 removed lines

@@ -1,11 +1,11 @@
 <?php
 /**
- * PHPCI - Continuous Integration for PHP
- *
- * @copyright    Copyright 2014, Block 8 Limited.
- * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
- * @link         https://www.phptesting.org/
- */
+     * PHPCI - Continuous Integration for PHP
+     *
+     * @copyright    Copyright 2014, Block 8 Limited.
+     * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
+     * @link         https://www.phptesting.org/
+     */
 
 namespace PHPCI\Service;