corretgecom / PHPCI

PHPCI/Model/Base/BuildErrorBase.php

Doc Comments +2 added lines, -2 removed lines

@@ -428,7 +428,7 @@ 
     * Set the value of CreatedDate / created_date.
     *
     * Must not be null.
-    * @param $value \DateTime
+    * @param \DateTime $value \DateTime
     */
     public function setCreatedDate($value)
     {
@@ -473,7 +473,7 @@ 
     /**
     * Set Build - Accepts an ID, an array representing a Build or a Build model.
     *
-    * @param $value mixed
+    * @param Model\Build $value mixed
     */
     public function setBuild($value)
     {

Indentation +104 added lines, -104 removed lines

@@ -15,23 +15,23 @@ 
 class BuildErrorBase extends Model
 {
     /**
-    * @var array
-    */
+     * @var array
+     */
     public static $sleepable = array();
 
     /**
-    * @var string
-    */
+     * @var string
+     */
     protected $tableName = 'build_error';
 
     /**
-    * @var string
-    */
+     * @var string
+     */
     protected $modelName = 'BuildError';
 
     /**
-    * @var array
-    */
+     * @var array
+     */
     protected $data = array(
         'id' => null,
         'build_id' => null,
@@ -45,8 +45,8 @@ 
     );
 
     /**
-    * @var array
-    */
+     * @var array
+     */
     protected $getters = array(
         // Direct property getters:
         'id' => 'getId',
@@ -64,8 +64,8 @@ 
     );
 
     /**
-    * @var array
-    */
+     * @var array
+     */
     protected $setters = array(
         // Direct property setters:
         'id' => 'setId',
@@ -83,8 +83,8 @@ 
     );
 
     /**
-    * @var array
-    */
+     * @var array
+     */
     public $columns = array(
         'id' => array(
             'type' => 'int',
@@ -138,16 +138,16 @@ 
     );
 
     /**
-    * @var array
-    */
+     * @var array
+     */
     public $indexes = array(
             'PRIMARY' => array('unique' => true, 'columns' => 'id'),
             'build_id' => array('columns' => 'build_id, created_date'),
     );
 
     /**
-    * @var array
-    */
+     * @var array
+     */
     public $foreignKeys = array(
             'build_error_ibfk_1' => array(
                 'local_col' => 'build_id',
@@ -159,10 +159,10 @@ 
     );
 
     /**
-    * Get the value of Id / id.
-    *
-    * @return int
-    */
+     * Get the value of Id / id.
+     *
+     * @return int
+     */
     public function getId()
     {
         $rtn    = $this->data['id'];
@@ -171,10 +171,10 @@ 
     }
 
     /**
-    * Get the value of BuildId / build_id.
-    *
-    * @return int
-    */
+     * Get the value of BuildId / build_id.
+     *
+     * @return int
+     */
     public function getBuildId()
     {
         $rtn    = $this->data['build_id'];
@@ -183,10 +183,10 @@ 
     }
 
     /**
-    * Get the value of Plugin / plugin.
-    *
-    * @return string
-    */
+     * Get the value of Plugin / plugin.
+     *
+     * @return string
+     */
     public function getPlugin()
     {
         $rtn    = $this->data['plugin'];
@@ -195,10 +195,10 @@ 
     }
 
     /**
-    * Get the value of File / file.
-    *
-    * @return string
-    */
+     * Get the value of File / file.
+     *
+     * @return string
+     */
     public function getFile()
     {
         $rtn    = $this->data['file'];
@@ -207,10 +207,10 @@ 
     }
 
     /**
-    * Get the value of LineStart / line_start.
-    *
-    * @return int
-    */
+     * Get the value of LineStart / line_start.
+     *
+     * @return int
+     */
     public function getLineStart()
     {
         $rtn    = $this->data['line_start'];
@@ -219,10 +219,10 @@ 
     }
 
     /**
-    * Get the value of LineEnd / line_end.
-    *
-    * @return int
-    */
+     * Get the value of LineEnd / line_end.
+     *
+     * @return int
+     */
     public function getLineEnd()
     {
         $rtn    = $this->data['line_end'];
@@ -231,10 +231,10 @@ 
     }
 
     /**
-    * Get the value of Severity / severity.
-    *
-    * @return int
-    */
+     * Get the value of Severity / severity.
+     *
+     * @return int
+     */
     public function getSeverity()
     {
         $rtn    = $this->data['severity'];
@@ -243,10 +243,10 @@ 
     }
 
     /**
-    * Get the value of Message / message.
-    *
-    * @return string
-    */
+     * Get the value of Message / message.
+     *
+     * @return string
+     */
     public function getMessage()
     {
         $rtn    = $this->data['message'];
@@ -255,10 +255,10 @@ 
     }
 
     /**
-    * Get the value of CreatedDate / created_date.
-    *
-    * @return \DateTime
-    */
+     * Get the value of CreatedDate / created_date.
+     *
+     * @return \DateTime
+     */
     public function getCreatedDate()
     {
         $rtn    = $this->data['created_date'];
@@ -271,11 +271,11 @@ 
     }
 
     /**
-    * Set the value of Id / id.
-    *
-    * Must not be null.
-    * @param $value int
-    */
+     * Set the value of Id / id.
+     *
+     * Must not be null.
+     * @param $value int
+     */
     public function setId($value)
     {
         $this->_validateNotNull('Id', $value);
@@ -291,11 +291,11 @@ 
     }
 
     /**
-    * Set the value of BuildId / build_id.
-    *
-    * Must not be null.
-    * @param $value int
-    */
+     * Set the value of BuildId / build_id.
+     *
+     * Must not be null.
+     * @param $value int
+     */
     public function setBuildId($value)
     {
         $this->_validateNotNull('BuildId', $value);
@@ -311,11 +311,11 @@ 
     }
 
     /**
-    * Set the value of Plugin / plugin.
-    *
-    * Must not be null.
-    * @param $value string
-    */
+     * Set the value of Plugin / plugin.
+     *
+     * Must not be null.
+     * @param $value string
+     */
     public function setPlugin($value)
     {
         $this->_validateNotNull('Plugin', $value);
@@ -331,10 +331,10 @@ 
     }
 
     /**
-    * Set the value of File / file.
-    *
-    * @param $value string
-    */
+     * Set the value of File / file.
+     *
+     * @param $value string
+     */
     public function setFile($value)
     {
         $this->_validateString('File', $value);
@@ -349,10 +349,10 @@ 
     }
 
     /**
-    * Set the value of LineStart / line_start.
-    *
-    * @param $value int
-    */
+     * Set the value of LineStart / line_start.
+     *
+     * @param $value int
+     */
     public function setLineStart($value)
     {
         $this->_validateInt('LineStart', $value);
@@ -367,10 +367,10 @@ 
     }
 
     /**
-    * Set the value of LineEnd / line_end.
-    *
-    * @param $value int
-    */
+     * Set the value of LineEnd / line_end.
+     *
+     * @param $value int
+     */
     public function setLineEnd($value)
     {
         $this->_validateInt('LineEnd', $value);
@@ -385,11 +385,11 @@ 
     }
 
     /**
-    * Set the value of Severity / severity.
-    *
-    * Must not be null.
-    * @param $value int
-    */
+     * Set the value of Severity / severity.
+     *
+     * Must not be null.
+     * @param $value int
+     */
     public function setSeverity($value)
     {
         $this->_validateNotNull('Severity', $value);
@@ -405,11 +405,11 @@ 
     }
 
     /**
-    * Set the value of Message / message.
-    *
-    * Must not be null.
-    * @param $value string
-    */
+     * Set the value of Message / message.
+     *
+     * Must not be null.
+     * @param $value string
+     */
     public function setMessage($value)
     {
         $this->_validateNotNull('Message', $value);
@@ -425,11 +425,11 @@ 
     }
 
     /**
-    * Set the value of CreatedDate / created_date.
-    *
-    * Must not be null.
-    * @param $value \DateTime
-    */
+     * Set the value of CreatedDate / created_date.
+     *
+     * Must not be null.
+     * @param $value \DateTime
+     */
     public function setCreatedDate($value)
     {
         $this->_validateNotNull('CreatedDate', $value);
@@ -471,10 +471,10 @@ 
     }
 
     /**
-    * Set Build - Accepts an ID, an array representing a Build or a Build model.
-    *
-    * @param $value mixed
-    */
+     * Set Build - Accepts an ID, an array representing a Build or a Build model.
+     *
+     * @param $value mixed
+     */
     public function setBuild($value)
     {
         // Is this an instance of Build?
@@ -492,10 +492,10 @@ 
     }
 
     /**
-    * Set Build - Accepts a Build model.
-    * 
-    * @param $value \PHPCI\Model\Build
-    */
+     * Set Build - Accepts a Build model.
+     * 
+     * @param $value \PHPCI\Model\Build
+     */
     public function setBuildObject(\PHPCI\Model\Build $value)
     {
         return $this->setBuildId($value->getId());

Spacing +11 added lines, -11 removed lines

@@ -165,7 +165,7 @@ 
     */
     public function getId()
     {
-        $rtn    = $this->data['id'];
+        $rtn = $this->data['id'];
 
         return $rtn;
     }
@@ -177,7 +177,7 @@ 
     */
     public function getBuildId()
     {
-        $rtn    = $this->data['build_id'];
+        $rtn = $this->data['build_id'];
 
         return $rtn;
     }
@@ -189,7 +189,7 @@ 
     */
     public function getPlugin()
     {
-        $rtn    = $this->data['plugin'];
+        $rtn = $this->data['plugin'];
 
         return $rtn;
     }
@@ -201,7 +201,7 @@ 
     */
     public function getFile()
     {
-        $rtn    = $this->data['file'];
+        $rtn = $this->data['file'];
 
         return $rtn;
     }
@@ -213,7 +213,7 @@ 
     */
     public function getLineStart()
     {
-        $rtn    = $this->data['line_start'];
+        $rtn = $this->data['line_start'];
 
         return $rtn;
     }
@@ -225,7 +225,7 @@ 
     */
     public function getLineEnd()
     {
-        $rtn    = $this->data['line_end'];
+        $rtn = $this->data['line_end'];
 
         return $rtn;
     }
@@ -237,7 +237,7 @@ 
     */
     public function getSeverity()
     {
-        $rtn    = $this->data['severity'];
+        $rtn = $this->data['severity'];
 
         return $rtn;
     }
@@ -249,7 +249,7 @@ 
     */
     public function getMessage()
     {
-        $rtn    = $this->data['message'];
+        $rtn = $this->data['message'];
 
         return $rtn;
     }
@@ -261,10 +261,10 @@ 
     */
     public function getCreatedDate()
     {
-        $rtn    = $this->data['created_date'];
+        $rtn = $this->data['created_date'];
 
         if (!empty($rtn)) {
-            $rtn    = new \DateTime($rtn);
+            $rtn = new \DateTime($rtn);
         }
         
         return $rtn;
@@ -459,7 +459,7 @@ 
             return null;
         }
 
-        $cacheKey   = 'Cache.Build.' . $key;
+        $cacheKey   = 'Cache.Build.'.$key;
         $rtn        = $this->cache->get($cacheKey, null);
 
         if (empty($rtn)) {

PHPCI/Model/Build.php

Doc Comments +2 added lines, -1 removed lines

@@ -74,6 +74,7 @@ 
 
     /**
      * Store build metadata
+     * @param string $key
      */
     public function storeMeta($key, $value)
     {
@@ -181,7 +182,7 @@ 
 
     /**
      * Return a value from the build's "extra" JSON array.
-     * @param null $key
+     * @param string $key
      * @return mixed|null|string
      */
     public function getExtra($key = null)

Indentation +12 added lines, -12 removed lines

@@ -1,11 +1,11 @@ 
 <?php
 /**
- * PHPCI - Continuous Integration for PHP
- *
- * @copyright    Copyright 2014, Block 8 Limited.
- * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
- * @link         https://www.phptesting.org/
- */
+     * PHPCI - Continuous Integration for PHP
+     *
+     * @copyright    Copyright 2014, Block 8 Limited.
+     * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
+     * @link         https://www.phptesting.org/
+     */
 
 namespace PHPCI\Model;
 
@@ -31,16 +31,16 @@ 
     public $currentBuildPath;
 
     /**
-    * Get link to commit from another source (i.e. Github)
-    */
+     * Get link to commit from another source (i.e. Github)
+     */
     public function getCommitLink()
     {
         return '#';
     }
 
     /**
-    * Get link to branch from another source (i.e. Github)
-    */
+     * Get link to branch from another source (i.e. Github)
+     */
     public function getBranchLink()
     {
         return '#';
@@ -56,8 +56,8 @@ 
     }
 
     /**
-    * Send status updates to any relevant third parties (i.e. Github)
-    */
+     * Send status updates to any relevant third parties (i.e. Github)
+     */
     public function sendStatusPostback()
     {
         return;

Spacing +7 added lines, -7 removed lines

@@ -105,13 +105,13 @@ 
         }
 
         // Try .phpci.yml
-        if (is_file($buildPath . '/.phpci.yml')) {
-            $build_config = file_get_contents($buildPath . '/.phpci.yml');
+        if (is_file($buildPath.'/.phpci.yml')) {
+            $build_config = file_get_contents($buildPath.'/.phpci.yml');
         }
 
         // Try phpci.yml first:
-        if (empty($build_config) && is_file($buildPath . '/phpci.yml')) {
-            $build_config = file_get_contents($buildPath . '/phpci.yml');
+        if (empty($build_config) && is_file($buildPath.'/phpci.yml')) {
+            $build_config = file_get_contents($buildPath.'/phpci.yml');
         }
 
         // Fall back to zero config plugins:
@@ -135,7 +135,7 @@ 
      */
     protected function getZeroConfigPlugins(Builder $builder)
     {
-        $pluginDir = PHPCI_DIR . 'PHPCI/Plugin/';
+        $pluginDir = PHPCI_DIR.'PHPCI/Plugin/';
         $dir = new \DirectoryIterator($pluginDir);
 
         $config = array(
@@ -257,8 +257,8 @@ 
         }
 
         if (empty($this->currentBuildPath)) {
-            $buildDirectory = $this->getId() . '_' . substr(md5(microtime(true)), 0, 5);
-            $this->currentBuildPath = PHPCI_BUILD_ROOT_DIR . $buildDirectory . DIRECTORY_SEPARATOR;
+            $buildDirectory = $this->getId().'_'.substr(md5(microtime(true)), 0, 5);
+            $this->currentBuildPath = PHPCI_BUILD_ROOT_DIR.$buildDirectory.DIRECTORY_SEPARATOR;
         }
 
         return $this->currentBuildPath;

PHPCI/Model/Build/SubversionBuild.php

Doc Comments +1 added lines, -1 removed lines

@@ -157,7 +157,7 @@
     /**
      * Create an SSH wrapper script for Svn to use, to disable host key checking, etc.
      * @param $cloneTo
-     * @param $keyFile
+     * @param string $keyFile
      * @return string
      */
     protected function writeSshWrapper($cloneTo, $keyFile)

Spacing +9 added lines, -9 removed lines

@@ -38,7 +38,7 @@ 
         if (empty($branch) || $branch == 'trunk') {
             $url .= 'trunk';
         } else {
-            $url .= 'branches/' . $branch;
+            $url .= 'branches/'.$branch;
         }
 
         return $url;
@@ -63,7 +63,7 @@ 
         $depth = $builder->getConfig('clone_depth');
 
         if (!is_null($depth)) {
-            $cmd .= ' --depth ' . intval($depth) . ' ';
+            $cmd .= ' --depth '.intval($depth).' ';
         }
 
         $this->svnCommand = $cmd;
@@ -117,12 +117,12 @@ 
      */
     protected function cloneBySsh(Builder $builder, $cloneTo)
     {
-        $cmd = $this->svnCommand . ' %s "%s"';
+        $cmd = $this->svnCommand.' %s "%s"';
 
         if (!IS_WIN) {
             $keyFile    = $this->writeSshKey($cloneTo);
             $sshWrapper = $this->writeSshWrapper($cloneTo, $keyFile);
-            $cmd        = 'export SVN_SSH="' . $sshWrapper . '" && ' . $cmd;
+            $cmd        = 'export SVN_SSH="'.$sshWrapper.'" && '.$cmd;
         }
 
         $success = $builder->executeCommand($cmd, $this->getCloneUrl(), $cloneTo);
@@ -143,8 +143,8 @@ 
      */
     protected function writeSshKey($cloneTo)
     {
-        $keyPath = dirname($cloneTo . '/temp');
-        $keyFile = $keyPath . '.key';
+        $keyPath = dirname($cloneTo.'/temp');
+        $keyFile = $keyPath.'.key';
 
         // Write the contents of this project's svn key to the file:
         file_put_contents($keyFile, $this->getProject()->getSshPrivateKey());
@@ -162,8 +162,8 @@ 
      */
     protected function writeSshWrapper($cloneTo, $keyFile)
     {
-        $path        = dirname($cloneTo . '/temp');
-        $wrapperFile = $path . '.sh';
+        $path        = dirname($cloneTo.'/temp');
+        $wrapperFile = $path.'.sh';
 
         $sshFlags = '-o CheckHostIP=no -o IdentitiesOnly=yes -o StrictHostKeyChecking=no -o PasswordAuthentication=no';
 
@@ -175,7 +175,7 @@ 
 OUT;
 
         file_put_contents($wrapperFile, $script);
-        shell_exec('chmod +x "' . $wrapperFile . '"');
+        shell_exec('chmod +x "'.$wrapperFile.'"');
 
         return $wrapperFile;
     }

Indentation +6 added lines, -6 removed lines

@@ -1,11 +1,11 @@
 <?php
 /**
- * PHPCI - Continuous Integration for PHP
- *
- * @copyright    Copyright 2014, Block 8 Limited.
- * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
- * @link         https://www.phptesting.org/
- */
+     * PHPCI - Continuous Integration for PHP
+     *
+     * @copyright    Copyright 2014, Block 8 Limited.
+     * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
+     * @link         https://www.phptesting.org/
+     */
 
 namespace PHPCI\Service;
 

PHPCI/Plugin/Campfire.php

Doc Comments +1 added lines, -1 removed lines

@@ -114,7 +114,7 @@
 
     /**
      * Make a request to Campfire.
-     * @param $page
+     * @param string $page
      * @param null $data
      * @return bool|mixed
      */

Spacing +3 added lines, -3 removed lines

@@ -63,7 +63,7 @@ 
      */
     public function execute()
     {
-        $url = PHPCI_URL . "build/view/" . $this->build->getId();
+        $url = PHPCI_URL."build/view/".$this->build->getId();
         $message = str_replace("%buildurl%", $url, $this->message);
         $this->joinRoom($this->roomId);
         $status = $this->speak($message, $this->roomId);
@@ -120,7 +120,7 @@ 
      */
     private function getPageByPost($page, $data = null)
     {
-        $url = $this->url . $page;
+        $url = $this->url.$page;
         // The new API allows JSON, so we can pass
         // PHP data structures instead of old school POST
         $json = json_encode($data);
@@ -133,7 +133,7 @@ 
         curl_setopt($handle, CURLOPT_USERAGENT, $this->userAgent);
         curl_setopt($handle, CURLOPT_VERBOSE, $this->verbose);
         curl_setopt($handle, CURLOPT_FOLLOWLOCATION, 1);
-        curl_setopt($handle, CURLOPT_USERPWD, $this->authToken . ':x');
+        curl_setopt($handle, CURLOPT_USERPWD, $this->authToken.':x');
         curl_setopt($handle, CURLOPT_HTTPHEADER, array("Content-type: application/json"));
         curl_setopt($handle, CURLOPT_COOKIEFILE, $this->cookie);
 

Indentation +6 added lines, -6 removed lines

@@ -1,11 +1,11 @@
 <?php
 /**
- * PHPCI - Continuous Integration for PHP
- *
- * @copyright    Copyright 2014, Block 8 Limited.
- * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
- * @link         https://www.phptesting.org/
- */
+     * PHPCI - Continuous Integration for PHP
+     *
+     * @copyright    Copyright 2014, Block 8 Limited.
+     * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
+     * @link         https://www.phptesting.org/
+     */
 
 namespace PHPCI\Service;
 

PHPCI/Plugin/Codeception.php

Doc Comments +3 added lines, -3 removed lines

@@ -57,7 +57,7 @@ 
 
     /**
      * Try and find the codeception YML config file.
-     * @param $buildPath
+     * @param string $buildPath
      * @return null|string
      */
     public static function findConfigFile($buildPath)
@@ -113,8 +113,8 @@ 
 
     /**
      * Run tests from a Codeception config file.
-     * @param $configPath
-     * @return bool|mixed
+     * @param string $configPath
+     * @return boolean
      * @throws \Exception
      */
     protected function runConfigFile($configPath)

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 use PHPCI\Helper\Lang;
 use PHPCI\Model\Build;
 use PHPCI\Plugin\Util\TestResultParsers\Codeception as Parser;
-use Psr\Log\LogLevel;
 
 /**
  * Codeception Plugin - Enables full acceptance, unit, and functional testing.

Spacing +9 added lines, -9 removed lines

@@ -62,11 +62,11 @@ 
      */
     public static function findConfigFile($buildPath)
     {
-        if (file_exists($buildPath . 'codeception.yml')) {
+        if (file_exists($buildPath.'codeception.yml')) {
             return 'codeception.yml';
         }
 
-        if (file_exists($buildPath . 'codeception.dist.yml')) {
+        if (file_exists($buildPath.'codeception.dist.yml')) {
             return 'codeception.dist.yml';
         }
 
@@ -83,7 +83,7 @@ 
     {
         $this->phpci = $phpci;
         $this->build = $build;
-        $this->path = 'tests' . DIRECTORY_SEPARATOR . '_output' . DIRECTORY_SEPARATOR;
+        $this->path = 'tests'.DIRECTORY_SEPARATOR.'_output'.DIRECTORY_SEPARATOR;
 
         if (empty($options['config'])) {
             $this->ymlConfigFile = self::findConfigFile($this->phpci->buildPath);
@@ -91,7 +91,7 @@ 
             $this->ymlConfigFile = $options['config'];
         }
         if (isset($options['args'])) {
-            $this->args = (string) $options['args'];
+            $this->args = (string)$options['args'];
         }
         if (isset($options['path'])) {
             $this->path = $options['path'];
@@ -129,21 +129,21 @@ 
             return false;
         }
 
-        $cmd = 'cd "%s" && ' . $codecept . ' run -c "%s" --xml ' . $this->args;
+        $cmd = 'cd "%s" && '.$codecept.' run -c "%s" --xml '.$this->args;
 
         if (IS_WIN) {
-            $cmd = 'cd /d "%s" && ' . $codecept . ' run -c "%s" --xml ' . $this->args;
+            $cmd = 'cd /d "%s" && '.$codecept.' run -c "%s" --xml '.$this->args;
         }
 
-        $configPath = $this->phpci->buildPath . $configPath;
+        $configPath = $this->phpci->buildPath.$configPath;
         $success = $this->phpci->executeCommand($cmd, $this->phpci->buildPath, $configPath);
 
         $this->phpci->log(
-            'Codeception XML path: '. $this->phpci->buildPath . $this->path . 'report.xml',
+            'Codeception XML path: '.$this->phpci->buildPath.$this->path.'report.xml',
             Loglevel::DEBUG
         );
 
-        $xml = file_get_contents($this->phpci->buildPath . $this->path . 'report.xml', false);
+        $xml = file_get_contents($this->phpci->buildPath.$this->path.'report.xml', false);
         $parser = new Parser($this->phpci, $xml);
         $output = $parser->parse();
 

Indentation +6 added lines, -6 removed lines

@@ -1,11 +1,11 @@
 <?php
 /**
- * PHPCI - Continuous Integration for PHP
- *
- * @copyright    Copyright 2014, Block 8 Limited.
- * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
- * @link         https://www.phptesting.org/
- */
+     * PHPCI - Continuous Integration for PHP
+     *
+     * @copyright    Copyright 2014, Block 8 Limited.
+     * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
+     * @link         https://www.phptesting.org/
+     */
 
 namespace PHPCI\Service;
 

PHPCI/Plugin/Email.php

Doc Comments -1 removed lines

@@ -44,7 +44,6 @@
      * Set up the plugin, configure options, etc.
      * @param Builder $phpci
      * @param Build $build
-     * @param \Swift_Mailer $mailer
      * @param array $options
      */
     public function __construct(

Spacing +2 added lines, -2 removed lines

@@ -207,7 +207,7 @@ 
     protected function getMailTemplate()
     {
         if (isset($this->options['template'])) {
-            return new View('Email/' . $this->options['template']);
+            return new View('Email/'.$this->options['template']);
         }
 
         return $this->getDefaultMailTemplate();
@@ -222,6 +222,6 @@ 
     {
         $template = $this->build->isSuccessful() ? 'short' : 'long';
 
-        return new View('Email/' . $template);
+        return new View('Email/'.$template);
     }
 }

Unused Use Statements -1 removed lines

@@ -10,7 +10,6 @@
 namespace PHPCI\Plugin;
 
 use PHPCI\Builder;
-use PHPCI\Helper\Lang;
 use PHPCI\Model\Build;
 
 /**

Indentation +6 added lines, -6 removed lines

@@ -1,11 +1,11 @@
 <?php
 /**
- * PHPCI - Continuous Integration for PHP
- *
- * @copyright    Copyright 2014, Block 8 Limited.
- * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
- * @link         https://www.phptesting.org/
- */
+     * PHPCI - Continuous Integration for PHP
+     *
+     * @copyright    Copyright 2014, Block 8 Limited.
+     * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
+     * @link         https://www.phptesting.org/
+     */
 
 namespace PHPCI\Service;
 

PHPCI/Plugin/Irc.php

Doc Comments +3 added lines, -3 removed lines

@@ -94,8 +94,8 @@ 
 
     /**
      * @param resource $socket
-     * @param array $commands
-     * @return bool
+     * @param string[] $commands
+     * @return boolean|null
      */
     private function executeIrcCommands($socket, array $commands)
     {
@@ -123,7 +123,7 @@ 
      *
      * @param resource $socket
      * @param string $command
-     * @return bool
+     * @return boolean|null
      */
     private function executeIrcCommand($socket, $command)
     {

Spacing +6 added lines, -6 removed lines

@@ -80,12 +80,12 @@ 
         stream_set_timeout($sock, 1);
 
         $connectCommands = array(
-            'USER ' . $this->nick . ' 0 * :' . $this->nick,
-            'NICK ' . $this->nick,
+            'USER '.$this->nick.' 0 * :'.$this->nick,
+            'NICK '.$this->nick,
         );
         $this->executeIrcCommands($sock, $connectCommands);
-        $this->executeIrcCommand($sock, 'JOIN ' . $this->room);
-        $this->executeIrcCommand($sock, 'PRIVMSG ' . $this->room . ' :' . $msg);
+        $this->executeIrcCommand($sock, 'JOIN '.$this->room);
+        $this->executeIrcCommand($sock, 'PRIVMSG '.$this->room.' :'.$msg);
 
         fclose($sock);
 
@@ -100,7 +100,7 @@ 
     private function executeIrcCommands($socket, array $commands)
     {
         foreach ($commands as $command) {
-            fputs($socket, $command . "\n");
+            fputs($socket, $command."\n");
         }
 
         $pingBack = false;
@@ -114,7 +114,7 @@ 
         }
 
         if ($pingBack) {
-            $command = 'PONG :' . $pingBack . "\n";
+            $command = 'PONG :'.$pingBack."\n";
             fputs($socket, $command);
         }
     }

Indentation +6 added lines, -6 removed lines

@@ -1,11 +1,11 @@
 <?php
 /**
- * PHPCI - Continuous Integration for PHP
- *
- * @copyright    Copyright 2014, Block 8 Limited.
- * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
- * @link         https://www.phptesting.org/
- */
+     * PHPCI - Continuous Integration for PHP
+     *
+     * @copyright    Copyright 2014, Block 8 Limited.
+     * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
+     * @link         https://www.phptesting.org/
+     */
 
 namespace PHPCI\Service;
 

PHPCI/Plugin/PhpCodeSniffer.php

Doc Comments +1 added lines, -1 removed lines

@@ -185,7 +185,7 @@
 
     /**
      * Process options and produce an arguments string for PHPCS.
-     * @return array
+     * @return string[]
      */
     protected function getFlags()
     {

Indentation +8 added lines, -8 removed lines

@@ -1,11 +1,11 @@ 
 <?php
 /**
- * PHPCI - Continuous Integration for PHP
- *
- * @copyright    Copyright 2014, Block 8 Limited.
- * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
- * @link         https://www.phptesting.org/
- */
+     * PHPCI - Continuous Integration for PHP
+     *
+     * @copyright    Copyright 2014, Block 8 Limited.
+     * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
+     * @link         https://www.phptesting.org/
+     */
 
 namespace PHPCI\Plugin;
 
@@ -142,8 +142,8 @@ 
     }
 
     /**
-    * Runs PHP Code Sniffer in a specified directory, to a specified standard.
-    */
+     * Runs PHP Code Sniffer in a specified directory, to a specified standard.
+     */
     public function execute()
     {
         list($ignore, $standard, $suffixes) = $this->getFlags();

Spacing +6 added lines, -6 removed lines

@@ -122,7 +122,7 @@ 
         }
 
         if (!empty($options['encoding'])) {
-            $this->encoding = ' --encoding=' . $options['encoding'];
+            $this->encoding = ' --encoding='.$options['encoding'];
         }
 
         $this->setOptions($options);
@@ -152,7 +152,7 @@ 
 
         $this->phpci->logExecOutput(false);
 
-        $cmd = $phpcs . ' --report=json %s %s %s %s %s "%s"';
+        $cmd = $phpcs.' --report=json %s %s %s %s %s "%s"';
         $this->phpci->executeCommand(
             $cmd,
             $standard,
@@ -160,7 +160,7 @@ 
             $ignore,
             $this->tab_width,
             $this->encoding,
-            $this->phpci->buildPath . $this->path
+            $this->phpci->buildPath.$this->path
         );
 
         $output = $this->phpci->getLastOutput();
@@ -191,7 +191,7 @@ 
     {
         $ignore = '';
         if (count($this->ignore)) {
-            $ignore = ' --ignore=' . implode(',', $this->ignore);
+            $ignore = ' --ignore='.implode(',', $this->ignore);
         }
 
         if (strpos($this->standard, '/') !== false) {
@@ -202,7 +202,7 @@ 
 
         $suffixes = '';
         if (count($this->suffixes)) {
-            $suffixes = ' --extensions=' . implode(',', $this->suffixes);
+            $suffixes = ' --extensions='.implode(',', $this->suffixes);
         }
 
         return array($ignore, $standard, $suffixes);
@@ -233,7 +233,7 @@ 
                 $this->build->reportError(
                     $this->phpci,
                     'php_code_sniffer',
-                    'PHPCS: ' . $message['message'],
+                    'PHPCS: '.$message['message'],
                     $message['type'] == 'ERROR' ? BuildError::SEVERITY_HIGH : BuildError::SEVERITY_LOW,
                     $fileName,
                     $message['line']

PHPCI/Plugin/PhpCpd.php

Doc Comments +2 added lines, -2 removed lines

@@ -108,8 +108,8 @@
 
     /**
      * Process the PHPCPD XML report.
-     * @param $xmlString
-     * @return array
+     * @param string $xmlString
+     * @return integer
      * @throws \Exception
      */
     protected function processReport($xmlString)

Indentation +8 added lines, -8 removed lines

@@ -1,11 +1,11 @@ 
 <?php
 /**
- * PHPCI - Continuous Integration for PHP
- *
- * @copyright    Copyright 2014, Block 8 Limited.
- * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
- * @link         https://www.phptesting.org/
- */
+     * PHPCI - Continuous Integration for PHP
+     *
+     * @copyright    Copyright 2014, Block 8 Limited.
+     * @license      https://github.com/Block8/PHPCI/blob/master/LICENSE.md
+     * @link         https://www.phptesting.org/
+     */
 
 namespace PHPCI\Plugin;
 
@@ -67,8 +67,8 @@ 
     }
 
     /**
-    * Runs PHP Copy/Paste Detector in a specified directory.
-    */
+     * Runs PHP Copy/Paste Detector in a specified directory.
+     */
     public function execute()
     {
         $ignore = '';

Spacing +7 added lines, -7 removed lines

@@ -54,7 +54,7 @@ 
         $this->ignore = $phpci->ignore;
 
         if (!empty($options['path'])) {
-            $this->path = $phpci->buildPath . $options['path'];
+            $this->path = $phpci->buildPath.$options['path'];
         }
 
         if (!empty($options['standard'])) {
@@ -73,14 +73,14 @@ 
     {
         $ignore = '';
         if (count($this->ignore)) {
-            $map = function ($item) {
+            $map = function($item) {
                 // remove the trailing slash
                 $item = rtrim($item, DIRECTORY_SEPARATOR);
 
-                if (is_file(rtrim($this->path, DIRECTORY_SEPARATOR) . DIRECTORY_SEPARATOR . $item)) {
-                    return ' --names-exclude ' . $item;
+                if (is_file(rtrim($this->path, DIRECTORY_SEPARATOR).DIRECTORY_SEPARATOR.$item)) {
+                    return ' --names-exclude '.$item;
                 } else {
-                    return ' --exclude ' . $item;
+                    return ' --exclude '.$item;
                 }
 
             };
@@ -93,7 +93,7 @@ 
 
         $tmpfilename = tempnam('/tmp', 'phpcpd');
 
-        $cmd = $phpcpd . ' --log-pmd "%s" %s "%s"';
+        $cmd = $phpcpd.' --log-pmd "%s" %s "%s"';
         $success = $this->phpci->executeCommand($cmd, $tmpfilename, $ignore, $this->path);
 
         print $this->phpci->getLastOutput();
@@ -142,7 +142,7 @@ 
                     BuildError::SEVERITY_NORMAL,
                     $fileName,
                     $file['line'],
-                    (int) $file['line'] + (int) $duplication['lines']
+                    (int)$file['line'] + (int)$duplication['lines']
                 );
             }