OfferModelTest - Code Metrics - Inspection of "Added YandexMarketYmlModuleTest" - corpsepk/yii2-yandex-market-yml - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7d8259...93df27 )

by Alexsandr

created 2017-03-06 07:56 UTC

OfferModelTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	346
Duplicated Lines	29.77 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	17
lcom	1
cbo	3
dl	103
loc	346
rs	10
c	1
b	0
f	0

14 Methods

Rating	Name	Duplication	Size	Complexity
A	testValidateId()	0	21	1
A	testValidateUrl()	16	16	1
A	testValidatePrice()	0	8	1
B	testValidateOldPrice()	0	28	1
A	testValidateCurrencyId()	0	16	2
B	testValidateCategoryId()	6	36	3
B	testValidatePicture()	0	29	1
A	testValidateLocalDeliveryCost()	16	16	1
A	testValidateVendor()	17	17	1
A	testValidateVendorCode()	16	16	1
A	testValidateDescription()	0	10	1
A	testValidateSaleNotes()	16	16	1
A	testValidateBarcode()	16	16	1
B	testValidateParam()	0	25	1

How to fix Duplicated Code

<?php
namespace tests;

use corpsepk\yml\models\Offer;
use yii\base\Security;

/**
 * OfferModelTest
 */
class OfferModelTest extends \PHPUnit_Framework_TestCase
{
    public function testValidateId()
    {
        $model = new Offer();

        // Обязательный атрибут
        $model->id = null;
        $this->assertFalse($model->validate(['id']));

        $model->id = '123';
        $this->assertTrue($model->validate(['id']));

        $model->id = 123;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $this->assertTrue($model->validate(['id']));

        $model->id = 'abc';
        $this->assertTrue($model->validate(['id']));

        // Максимальная длина - 20 символов
        $model->id = (new Security())->generateRandomString(21);
        $this->assertFalse($model->validate(['id']));
    }

    // TODO

//    public function testValidateType() {}

    // TODO

//    public function testValidateAvailable() {}

    // TODO

//    public function testValidateCBid() {}

    public function testValidateUrl()

    {
        $model = new Offer();

        // Необязательный элемент для магазинов-салонов
        $model->url = null;
        $this->assertTrue($model->validate(['url']));

        // Максимальная длина - 512 символов
        $model->url = (new Security())->generateRandomString(10);
        $this->assertTrue($model->validate(['url']));

        // Максимальная длина - 512 символов
        $model->url = (new Security())->generateRandomString(513);
        $this->assertFalse($model->validate(['url']));
    }

    public function testValidatePrice()
    {
        $model = new Offer();

        // Обязательный элемент
        $model->price = null;
        $this->assertFalse($model->validate(['price']));
    }

    public function testValidateOldPrice()
    {
        $model = new Offer();

        // В <oldprice> указывается старая цена товара, которая должна быть обязательно выше новой цены (<price>)
        $model->price = null;
        $model->oldprice = 2;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $this->assertFalse($model->validate(['price', 'oldprice']));

        // В <oldprice> указывается старая цена товара, которая должна быть обязательно выше новой цены (<price>)
        $model->price = 2;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $model->oldprice = 1;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $this->assertFalse($model->validate(['oldprice']));

        // В <oldprice> указывается старая цена товара, которая должна быть обязательно выше новой цены (<price>)
        $model->price = 1;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $model->oldprice = 2;
        $this->assertTrue($model->validate(['oldprice']));

        // Скидка может показываться в процентах.
        $model->price = 20;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $model->oldprice = '10%';
        $this->assertTrue($model->validate(['oldprice']));

        $model->price = '20';
        $model->oldprice = '10%';
        $this->assertTrue($model->validate(['oldprice']));
    }

    public function testValidateCurrencyId()
    {
        $model = new Offer();

        foreach (Offer::CURRENCY_AVAILABLE as $currency)
        {
            $model->currencyId = $currency;
            $this->assertTrue($model->validate(['currencyId']));
        }

        $model->currencyId = 'NON';
        $this->assertFalse($model->validate(['currencyId']));

        $model->currencyId = null;
        $this->assertFalse($model->validate(['currencyId']));
    }

    public function testValidateCategoryId()
    {
        $model = new Offer();

        // Идентификатор категории товара (целое число не более 18 знаков)
        for ($i = 1; $i <= 18; $i++) {

            $model->categoryId .= rand(1, 9);
        }
        $this->assertTrue($model->validate(['categoryId']));

        // Идентификатор категории товара (целое число не более 18 знаков)
        for ($i = 1; $i <= 19; $i++) {

            $model->categoryId .= rand(1, 9);
        }
        $this->assertTrue($model->validate(['categoryId']));

        // Идентификатор категории товара (целое число не более 18 знаков)
        $model->categoryId = (new Security())->generateRandomKey(19);
        $this->assertFalse($model->validate(['categoryId']));

        // Элемент offer может содержать только один элемент categoryId
        $model->categoryId = [1, 2, 3];

        $this->assertFalse($model->validate(['categoryId']));

        // Идентификатор категории товара (целое число не более 18 знаков)
        $model->categoryId = 'abc';
        $this->assertFalse($model->validate(['categoryId']));

        // Идентификатор категории товара не может быть равен нулю
        $model->categoryId = 0;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $this->assertFalse($model->validate(['categoryId']));

        // Идентификатор категории товара не может быть равен нулю
        $model->categoryId = '0';
        $this->assertFalse($model->validate(['categoryId']));
    }

    public function testValidatePicture()
    {
        $model = new Offer();
        $randomString20Symbols = (new Security())->generateRandomString(20);
        $randomString513Symbols = (new Security())->generateRandomString(513);

        $model->picture = null;
        $this->assertTrue($model->validate(['picture']));

        // Может быть строкой
        $model->picture = $randomString20Symbols;
        $this->assertTrue($model->validate(['picture']));

        // Может быть массивом
        $model->picture = [$randomString20Symbols, $randomString20Symbols];
        $this->assertTrue($model->validate(['picture']));

        // Максимальная длина URL — 512 символов
        $model->picture = $randomString513Symbols;
        $this->assertFalse($model->validate(['picture']));

        // Максимальная длина URL — 512 символов
        $model->picture = [$randomString513Symbols, $randomString20Symbols];
        $this->assertFalse($model->validate(['picture']));

        // Массив должен состоять не более чем из 10ти элементов
        $model->picture = array_fill(0, 11, $randomString20Symbols);
        $this->assertFalse($model->validate(['picture']));
    }

    // TODO

//    public function testValidateStore() {}

    // TODO

//    public function testValidatePickup() {}

    // TODO

//    public function testValidateDelivery() {}

    public function testValidateLocalDeliveryCost()

    {
        $model = new Offer();

        $model->local_delivery_cost = null;
        $this->assertTrue($model->validate(['local_delivery_cost']));

        $model->local_delivery_cost = 100;

        $this->assertTrue($model->validate(['local_delivery_cost']));

        $model->local_delivery_cost = '100';
        $this->assertTrue($model->validate(['local_delivery_cost']));

        $model->local_delivery_cost = 'abc';
        $this->assertFalse($model->validate(['local_delivery_cost']));
    }

    // TODO

//    public function testValidateTypePrefix() {}

    // TODO

//    public function testValidateName() {}

    public function testValidateVendor()

    {
        $model = new Offer();

        // Обязательный элемент
        $model->vendor = null;
        $this->assertFalse($model->validate(['vendor']));

        $model->vendor = '123abc';
        $this->assertTrue($model->validate(['vendor']));

        $model->vendor = 'abc';
        $this->assertTrue($model->validate(['vendor']));

        $model->vendor = 123;
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $this->assertFalse($model->validate(['vendor']));
    }

    public function testValidateVendorCode()

    {
        $model = new Offer();

        $model->vendorCode = null;
        $this->assertTrue($model->validate(['vendorCode']));

        $model->vendorCode = 123;

        $this->assertTrue($model->validate(['vendorCode']));

        $model->vendorCode = '123';
        $this->assertTrue($model->validate(['vendorCode']));

        $model->vendorCode = 'abc';
        $this->assertTrue($model->validate(['vendorCode']));
    }

    // TODO

//    public function testValidateModel() {}

    public function testValidateDescription()
    {
        $model = new Offer();

        $model->description = null;
        $this->assertTrue($model->validate(['description']));

        $model->description = (new Security())->generateRandomString(1000);
        $this->assertTrue($model->validate(['description']));
    }

    public function testValidateSaleNotes()

    {
        $model = new Offer();

        // Необязательный элемент
        $model->sale_notes = null;
        $this->assertTrue($model->validate(['sale_notes']));

        // Допустимая длина текста в элементе — 50 символов
        $model->sale_notes = (new Security())->generateRandomString(50);
        $this->assertTrue($model->validate(['sale_notes']));

        // Допустимая длина текста в элементе — 50 символов
        $model->sale_notes = (new Security())->generateRandomString(51);
        $this->assertFalse($model->validate(['sale_notes']));
    }

    // TODO

//    public function testValidateManufacturerWarranty() {}

    // TODO

//    public function testValidateSellerWarranty() {}

    // TODO

//    public function testValidateCountryOfOrigin() {}

    // TODO

//    public function testValidateDownloadable() {}

    // TODO

//    public function testValidateAdult() {}

    // TODO

//    public function testValidateAge() {}

    public function testValidateBarcode()

    {
        $model = new Offer();

        $model->barcode = null;
        $this->assertTrue($model->validate(['barcode']));

        $model->barcode = (new Security())->generateRandomString(20);
        $this->assertTrue($model->validate(['barcode']));

        $model->barcode = [
            (new Security())->generateRandomString(20),
            (new Security())->generateRandomString(20)
        ];
        $this->assertTrue($model->validate(['barcode']));
    }

    // TODO

//    public function testValidateCpa() {}

    // TODO

//    public function testValidateRec() {}

    // TODO

//    public function testValidateExpiry() {}

    // TODO

//    public function testValidateWeight() {}

    // TODO

//    public function testValidateDimensions() {}

    public function testValidateParam()
    {
        $model = new Offer();

        $model->param = null;
        $this->assertTrue($model->validate(['param']));

        $model->param = [];
        $this->assertTrue($model->validate(['param']));

        $model->param = [
            ['name' => 'Размер', 'value' => '42-44'],
            ['name' => 'Цвет', 'value' => 'Красный']
        ];
        $this->assertTrue($model->validate(['param']));

        $model->param = ['Размер', '42-44'];
        $this->assertFalse($model->validate(['param']));

        $model->param = [
            ['name' => 'Размер', 'value' => '42-44'],
            ['name' => 'Цвет', 1 => 'Красный'],
        ];
        $this->assertFalse($model->validate(['param']));
    }
}


1			<?php
2			namespace tests;
3
4			use corpsepk\yml\models\Offer;
5			use yii\base\Security;
6
7			/**
8			* OfferModelTest
9			*/
10			class OfferModelTest extends \PHPUnit_Framework_TestCase
11			{
12			public function testValidateId()
13			{
14			$model = new Offer();
15
16			// Обязательный атрибут
17			$model->id = null;
18			$this->assertFalse($model->validate(['id']));
19
20			$model->id = '123';
21			$this->assertTrue($model->validate(['id']));
22
23			$model->id = 123;
			1 ignored issue – show Documentation Bug introduced 2017-02-09 16:10 UTC by Report Bug Copy Issue Report The property `$id` was declared of type `string`, but `123` is of type `integer`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
24			$this->assertTrue($model->validate(['id']));
25
26			$model->id = 'abc';
27			$this->assertTrue($model->validate(['id']));
28
29			// Максимальная длина - 20 символов
30			$model->id = (new Security())->generateRandomString(21);
31			$this->assertFalse($model->validate(['id']));
32			}
33
34			// TODO
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-03-06 07:59 UTC by Report Bug Copy Issue Report `43%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
35			// public function testValidateType() {}
36
37			// TODO
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-03-06 07:59 UTC by Report Bug Copy Issue Report `43%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...

corpsepk / yii2-yandex-market-yml

GitHub Access Token became invalid

Push — master ( 7d8259...93df27 )

OfferModelTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

14 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like