cornernote\dashboard\models\query\DashboardPanelQuery

Complexity

Total Complexity

7

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	enabled()	0	4	1
A	orderBySort()	0	4	1
A	all()	0	4	1
A	allCanView()	0	11	3
A	one()	0	4	1

<?php

namespace cornernote\dashboard\models\query;

use yii\db\ActiveQuery;
use cornernote\dashboard\models\DashboardPanel;
use cornernote\dashboard\components;

/**
 * This is the ActiveQuery class for [[\cornernote\dashboard\models\DashboardPanel]].
 *
 * @see DashboardPanel
 */
class DashboardPanelQuery extends ActiveQuery
{
    /**
     * @return static
     */
    public function enabled()
    {
        return $this->andWhere(['enabled' => 1]);
    }

    /**
     * @return static
     */
    public function orderBySort()
    {
        return $this->orderBy(['sort' => SORT_ASC]);
    }

    /**
     * @inheritdoc
     * @return DashboardPanel[]|array
     */
    public function all($db = null)
    {
        return parent::all($db);
    }

    /**
	 * @return DashboardPanel[]|array
	 */
	public function allCanView($db = null)
	{
		$models = parent::all($db);

It seems like you call parent on a different method (all() instead of allCanView()). Are you sure this is correct? If so, you might want to change this to $this->all().

		foreach ($models as $k => $model) {
			if (!components\DashboardPanelAccess::userHasAccess($model->name)) {
				unset($models[$k]);
			}
		}

		return $models;
	}

	/**
	 * @inheritdoc
	 * @return DashboardPanel|array|null
	 */
    public function one($db = null)
    {
        return parent::one($db);

The expression parent::one($db); of type yii\db\ActiveRecord|array|null adds the type yii\db\ActiveRecord to the return on line 62 which is incompatible with the return type declared by the interface yii\db\QueryInterface::one of type array|boolean.

    }
}