Anax\Model\IpValidation::toJson()

Complexity

Conditions	4
Paths	6

Size

Total Lines	33
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	17
CRAP Score	4.0027

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function toJson($ip) : array
    {
            if (filter_var($ip, FILTER_VALIDATE_IP, FILTER_FLAG_IPV4)) {
                $ipv = "Ipv4";
            } elseif (filter_var($ip, FILTER_VALIDATE_IP, FILTER_FLAG_IPV6)) {
                $ipv = "Ipv6";
            } else {
                $ipv = null;
            }

            if ($ipv != null) {

It seems like you are loosely comparing $ipv of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

                $details = json_decode(file_get_contents("http://api.ipstack.com/{$ip}?access_key=9e9f05f2e74673444b90a999a579ab3f"));
                $domain = gethostbyaddr($ip);
            return [
                "valid" => "valid IP",
                "ip" => $ip,
                "ipv" => $ipv,
                "domain" => $domain,
                "lat" => $details->latitude,
                "lon" => $details->longitude,
                "country" => $details->country_name,
                "city" => $details->city
            ];
            } else {
                return [
                    "valid" => "Not Valid IP",
                    "ip" => null,
                    "ipv" => null,
                    "domain" => null,
                    "lat" => null,
                    "lon" => null,
                    "country" => null,
                    "city" => null
                ];