Venue::fromApi() - Code Metrics - Inspection of "Use explicit models instead of anonymous arrays" - core23/setlistfm-php-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fc424a...ea923b )

by Christian

created 2018-03-31 15:25 UTC

Venue::fromApi() A

↳ Parent: Venue

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	9
nc	2
nop	1

<?php

declare(strict_types=1);

/*
 * (c) Christian Gripp <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Core23\SetlistFm\Model;

final class Venue
{
    /**
     * @var string
     */
    private $id;

    /**
     * @var string
     */
    private $name;

    /**
     * @var string|null
     */
    private $url;

    /**
     * @var City|null
     */
    private $city;

    /**
     * Venue constructor.
     *
     * @param string      $id
     * @param string      $name
     * @param null|string $url
     * @param City|null   $city
     */
    public function __construct(string $id, string $name, ?string $url, ?City $city)
    {
        $this->id   = $id;
        $this->name = $name;
        $this->url  = $url;
        $this->city = $city;
    }

    /**
     * @return string
     */
    public function getId(): string
    {
        return $this->id;
    }

    /**
     * @return string
     */
    public function getName(): string
    {
        return $this->name;
    }

    /**
     * @return null|string
     */
    public function getUrl(): ?string
    {
        return $this->url;
    }

    /**
     * @return City|null
     */
    public function getCity(): ?City
    {
        return $this->city;
    }

    /**
     * @param array $data
     *
     * @return Venue
     */
    public static function fromApi(array $data): self
    {
        $city = null;

        if ($data['city']) {
            $city = City::fromApi($data['city']);
        }

        return new self(
            $data['id'],
            $data['name'],
            $data['url'],
            $city
        );
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* (c) Christian Gripp <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Core23\SetlistFm\Model;
13
14			final class Venue
15			{
16			/**
17			* @var string
18			*/
19			private $id;
20
21			/**
22			* @var string
23			*/
24			private $name;
25
26			/**
27			* @var string\|null
28			*/
29			private $url;
30
31			/**
32			* @var City\|null
33			*/
34			private $city;
35
36			/**
37			* Venue constructor.
38			*
39			* @param string $id
40			* @param string $name
41			* @param null\|string $url
42			* @param City\|null $city
43			*/
44			public function __construct(string $id, string $name, ?string $url, ?City $city)
45			{
46			$this->id = $id;
47			$this->name = $name;
48			$this->url = $url;
49			$this->city = $city;
50			}
51
52			/**
53			* @return string
54			*/
55			public function getId(): string
56			{
57			return $this->id;
58			}
59
60			/**
61			* @return string
62			*/
63			public function getName(): string
64			{
65			return $this->name;
66			}
67
68			/**
69			* @return null\|string
70			*/
71			public function getUrl(): ?string
72			{
73			return $this->url;
74			}
75
76			/**
77			* @return City\|null
78			*/
79			public function getCity(): ?City
80			{
81			return $this->city;
82			}
83
84			/**
85			* @param array $data
86			*
87			* @return Venue
88			*/
89			public static function fromApi(array $data): self
90			{
91			$city = null;
92
93			if ($data['city']) {
94			$city = City::fromApi($data['city']);
95			}
96
97			return new self(
98			$data['id'],
99			$data['name'],
100			$data['url'],
101			$city
102			);
103			}
104			}
105

core23 / setlistfm-php-api

GitHub Access Token became invalid

Push — master ( fc424a...ea923b )

Venue::fromApi() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like