Core23\LastFm\Crawler\AbstractCrawler

Complexity

Total Complexity

14

Size/Duplication

Total Lines	112
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	crawl()	0	6	1
A	parseUrl()	0	12	4
A	parseImage()	0	4	1
B	parseString()	0	18	5
A	parseDate()	0	10	2

<?php

/*
 * This file is part of the ni-ju-san CMS.
 *
 * (c) Christian Gripp <mail@core23.de>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Core23\LastFm\Crawler;

use Core23\LastFm\Connection\ConnectionInterface;
use Symfony\Component\DomCrawler\Crawler;

abstract class AbstractCrawler
{
    const URL_PREFIX = 'http://last.fm';

    /**
     * @var ConnectionInterface
     */
    protected $connection;

    /**
     * AbstractService constructor.
     *
     * @param ConnectionInterface $connection
     */
    public function __construct(ConnectionInterface $connection)
    {
        $this->connection = $connection;
    }

    /**
     * Crawles a url.
     *
     * @param string $url
     *
     * @return Crawler
     */
    final protected function crawl($url)
    {
        $content = $this->connection->loadPage($url);

        return new Crawler($content);
    }

    /**
     * Parses a url node.
     *
     * @param Crawler $node
     * @param string  $attr
     *
     * @return null|string
     */
    final protected function parseUrl(Crawler $node, $attr = 'href')
    {
        if ($node == null || $node->count() === 0) {
            return;
        }

        if ($url = $node->attr($attr)) {
            return preg_replace('/^\//', static::URL_PREFIX.'/', $url);
        }

        return;
    }

    /**
     * Parses an image node.
     *
     * @param Crawler $node
     *
     * @return null|string
     */
    final protected function parseImage(Crawler $node)
    {
        return $this->parseUrl($node, 'src');
    }

    /**
     * Parses a string node.
     *
     * @param Crawler $node
     *
     * @param bool    $multiline
     *
     * @return null|string
     */
    final protected function parseString(Crawler $node, $multiline = false)
    {
        if ($node == null || $node->count() === 0) {
            return;
        }

        $content = $node->attr('content');

        if (!$content) {

The expression $content of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

            if ($multiline) {
                $content = strip_tags($node->html());
            } else {
                $content = $node->text();
            }
        }

        return trim($content);
    }

    /**
     * Parses a date note.
     *
     * @param Crawler $node
     *
     * @return \DateTime|null
     */
    final protected function parseDate(Crawler $node)
    {
        $content = $this->parseString($node);

        if ($content) {

The expression $content of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            return new \DateTime($content);
        }

        return;
    }
}