LibraryService::__construct() - Code Metrics - Inspection of "[MAJOR] Refactored client" - core23/lastfm-php-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 625674...909c28 )

by Christian

created 2019-04-12 20:20 UTC

LibraryService::__construct() A

↳ Parent: LibraryService

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

declare(strict_types=1);

/*
 * (c) Christian Gripp <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Core23\LastFm\Service;

use Core23\LastFm\Client\ApiClientInterface;
use Core23\LastFm\Model\ArtistInfo;
use Core23\LastFm\Util\ApiHelper;

final class LibraryService implements LibraryServiceInterface
{
    /**
     * @var ApiClientInterface
     */
    private $client;

    /**
     * @param ApiClientInterface $client
     */
    public function __construct(ApiClientInterface $client)
    {
        $this->client = $client;
    }

    /**
     * {@inheritdoc}
     */
    public function getArtists(string $user, int $limit = 50, int $page = 1): array

    {
        $response = $this->client->unsignedCall('library.getArtists', [
            'user'  => $user,
            'limit' => $limit,
            'page'  => $page,
        ]);

        if (!isset($response['artists']['artist'])) {
            return [];
        }

        return ApiHelper::mapList(
            static function ($data) {
                return ArtistInfo::fromApi($data);
            },
            $response['artists']['artist']
        );
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		/*
6		* (c) Christian Gripp <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Core23\LastFm\Service;
13
14		use Core23\LastFm\Client\ApiClientInterface;
15		use Core23\LastFm\Model\ArtistInfo;
16		use Core23\LastFm\Util\ApiHelper;
17
18		final class LibraryService implements LibraryServiceInterface
19		{
20		/**
21		* @var ApiClientInterface
22		*/
23		private $client;
24
25		/**
26		* @param ApiClientInterface $client
27		*/
28		public function __construct(ApiClientInterface $client)
29		{
30		$this->client = $client;
31		}
32
33		/**
34		* {@inheritdoc}
35		*/
36	View Code Duplication	public function getArtists(string $user, int $limit = 50, int $page = 1): array
		0 ignored issues – show Duplication introduced 2018-03-31 15:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37		{
38		$response = $this->client->unsignedCall('library.getArtists', [
39		'user' => $user,
40		'limit' => $limit,
41		'page' => $page,
42		]);
43
44		if (!isset($response['artists']['artist'])) {
45		return [];
46		}
47
48		return ApiHelper::mapList(
49		static function ($data) {
50		return ArtistInfo::fromApi($data);
51		},
52		$response['artists']['artist']
53		);
54		}
55		}
56

core23 / lastfm-php-api

GitHub Access Token became invalid

Push — master ( 625674...909c28 )

LibraryService::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like