Chart::fromApi() - Code Metrics - Inspection of "Use explicit models instead of anonymous arrays" - core23/lastfm-php-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 547017...c67bb4 )

by Christian

created 2018-03-31 15:24 UTC

Chart::fromApi() A

↳ Parent: Chart

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	7
rs	9.4285
cc	1
eloc	4
nc	1
nop	1

<?php

declare(strict_types=1);

/*
 * (c) Christian Gripp <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Core23\LastFm\Model;

final class Chart
{
    /**
     * @var \DateTime
     */
    private $from;

    /**
     * @var \DateTime
     */
    private $to;

    /**
     * Chart constructor.
     *
     * @param \DateTime $from
     * @param \DateTime $to
     */
    public function __construct(\DateTime $from, \DateTime $to)
    {
        $this->from = $from;
        $this->to   = $to;
    }

    /**
     * @return \DateTime
     */
    public function getFrom(): \DateTime
    {
        return $this->from;
    }

    /**
     * @return \DateTime
     */
    public function getTo(): \DateTime
    {
        return $this->to;
    }

    /**
     * @param array $data
     *
     * @return Chart
     */
    public static function fromApi(array $data): self
    {
        return new self(
            \DateTime::createFromFormat('U', $data['from']),

            \DateTime::createFromFormat('U', $data['to'])

        );
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* (c) Christian Gripp <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Core23\LastFm\Model;
13
14			final class Chart
15			{
16			/**
17			* @var \DateTime
18			*/
19			private $from;
20
21			/**
22			* @var \DateTime
23			*/
24			private $to;
25
26			/**
27			* Chart constructor.
28			*
29			* @param \DateTime $from
30			* @param \DateTime $to
31			*/
32			public function __construct(\DateTime $from, \DateTime $to)
33			{
34			$this->from = $from;
35			$this->to = $to;
36			}
37
38			/**
39			* @return \DateTime
40			*/
41			public function getFrom(): \DateTime
42			{
43			return $this->from;
44			}
45
46			/**
47			* @return \DateTime
48			*/
49			public function getTo(): \DateTime
50			{
51			return $this->to;
52			}
53
54			/**
55			* @param array $data
56			*
57			* @return Chart
58			*/
59			public static function fromApi(array $data): self
60			{
61			return new self(
62			\DateTime::createFromFormat('U', $data['from']),
			0 ignored issues – show Security Bug introduced 2018-03-31 15:29 UTC by Report Bug Copy Issue Report It seems like `\DateTime::createFromFormat('U', $data['from'])` targeting `DateTime::createFromFormat()` can also be of type `false`; however, `Core23\LastFm\Model\Chart::__construct()` does only seem to accept `object<DateTime>`, did you maybe forget to handle an error condition? Loading history...
63			\DateTime::createFromFormat('U', $data['to'])
			0 ignored issues – show Security Bug introduced 2018-03-31 15:29 UTC by Report Bug Copy Issue Report It seems like `\DateTime::createFromFormat('U', $data['to'])` targeting `DateTime::createFromFormat()` can also be of type `false`; however, `Core23\LastFm\Model\Chart::__construct()` does only seem to accept `object<DateTime>`, did you maybe forget to handle an error condition? Loading history...
64			);
65			}
66			}
67

core23 / lastfm-php-api

GitHub Access Token became invalid

Push — master ( 547017...c67bb4 )

Chart::fromApi() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like