Artist::fromApi() - Code Metrics - Inspection of "Use explicit models instead of anonymous arrays" - core23/lastfm-php-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 547017...c67bb4 )

by Christian

created 2018-03-31 15:24 UTC

Artist::fromApi() A

↳ Parent: Artist

Complexity

Conditions	3
Paths	2

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	17
rs	9.4285
cc	3
eloc	10
nc	2
nop	1

<?php

declare(strict_types=1);

/*
 * (c) Christian Gripp <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Core23\LastFm\Model;

final class Artist
{
    /**
     * @var string
     */
    private $name;

    /**
     * @var string|null
     */
    private $mbid;

    /**
     * @var Image[]
     */
    private $image;

    /**
     * @var string|null
     */
    private $url;

    /**
     * Artist constructor.
     *
     * @param string      $name
     * @param null|string $mbid
     * @param Image[]     $image
     * @param null|string $url
     */
    public function __construct(string $name, ?string $mbid, array $image, ?string $url)
    {
        $this->name  = $name;
        $this->mbid  = $mbid;
        $this->image = $image;
        $this->url   = $url;
    }

    /**
     * @return string
     */
    public function getName(): string
    {
        return $this->name;
    }

    /**
     * @return null|string
     */
    public function getMbid(): ?string
    {
        return $this->mbid;
    }

    /**
     * @return Image[]
     */
    public function getImage(): array
    {
        return $this->image;
    }

    /**
     * @return null|string
     */
    public function getUrl(): ?string
    {
        return $this->url;
    }

    /**
     * @param array $data
     *
     * @return Artist
     */
    public static function fromApi(array $data): self
    {
        $images = [];

        if (array_key_exists('image', $data)) {
            foreach ((array) $data['image'] as $image) {
                $images[] = new Image($image['#text']);
            }
        }

        return new self(
            $data['name'] ?? $data['#text'],
            $data['mbid'] ?? null,
            $images,
            $data['url'] ?? null
        );
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* (c) Christian Gripp <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Core23\LastFm\Model;
13
14			final class Artist
15			{
16			/**
17			* @var string
18			*/
19			private $name;
20
21			/**
22			* @var string\|null
23			*/
24			private $mbid;
25
26			/**
27			* @var Image[]
28			*/
29			private $image;
30
31			/**
32			* @var string\|null
33			*/
34			private $url;
35
36			/**
37			* Artist constructor.
38			*
39			* @param string $name
40			* @param null\|string $mbid
41			* @param Image[] $image
42			* @param null\|string $url
43			*/
44			public function __construct(string $name, ?string $mbid, array $image, ?string $url)
45			{
46			$this->name = $name;
47			$this->mbid = $mbid;
48			$this->image = $image;
49			$this->url = $url;
50			}
51
52			/**
53			* @return string
54			*/
55			public function getName(): string
56			{
57			return $this->name;
58			}
59
60			/**
61			* @return null\|string
62			*/
63			public function getMbid(): ?string
64			{
65			return $this->mbid;
66			}
67
68			/**
69			* @return Image[]
70			*/
71			public function getImage(): array
72			{
73			return $this->image;
74			}
75
76			/**
77			* @return null\|string
78			*/
79			public function getUrl(): ?string
80			{
81			return $this->url;
82			}
83
84			/**
85			* @param array $data
86			*
87			* @return Artist
88			*/
89			public static function fromApi(array $data): self
90			{
91			$images = [];
92
93			if (array_key_exists('image', $data)) {
94			foreach ((array) $data['image'] as $image) {
95			$images[] = new Image($image['#text']);
96			}
97			}
98
99			return new self(
100			$data['name'] ?? $data['#text'],
101			$data['mbid'] ?? null,
102			$images,
103			$data['url'] ?? null
104			);
105			}
106			}
107

core23 / lastfm-php-api

GitHub Access Token became invalid

Push — master ( 547017...c67bb4 )

Artist::fromApi() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like