Album::fromApi() - Code Metrics - Inspection of "Use explicit models instead of anonymous arrays" - core23/lastfm-php-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 547017...c67bb4 )

by Christian

created 2018-03-31 15:24 UTC

Album::fromApi() A

↳ Parent: Album

Complexity

Conditions	4
Paths	2

Size

Total Lines	18
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	18
rs	9.2
cc	4
eloc	11
nc	2
nop	1

<?php

declare(strict_types=1);

/*
 * (c) Christian Gripp <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Core23\LastFm\Model;

final class Album
{
    /**
     * @var string|null
     */
    private $name;

    /**
     * @var Artist|null
     */
    private $artist;

    /**
     * @var string|null
     */
    private $mbid;

    /**
     * @var string|null
     */
    private $url;

    /**
     * @var Image[]
     */
    private $images;

    /**
     * Album constructor.
     *
     * @param null|string $name
     * @param Artist|null $artist
     * @param null|string $mbid
     * @param null|string $url
     * @param Image[]     $images
     */
    public function __construct(?string $name, ?Artist $artist, ?string $mbid, ?string $url, array $images)
    {
        $this->name   = $name;
        $this->artist = $artist;
        $this->mbid   = $mbid;
        $this->url    = $url;
        $this->images = $images;
    }

    /**
     * @return null|string
     */
    public function getName(): ?string
    {
        return $this->name;
    }

    /**
     * @return Artist|null
     */
    public function getArtist(): ?Artist
    {
        return $this->artist;
    }

    /**
     * @return null|string
     */
    public function getMbid(): ?string
    {
        return $this->mbid;
    }

    /**
     * @return null|string
     */
    public function getUrl(): ?string
    {
        return $this->url;
    }

    /**
     * @return Image[]
     */
    public function getImages(): array
    {
        return $this->images;
    }

    /**
     * @param array $data
     *
     * @return Album
     */
    public static function fromApi(array $data): self
    {
        $images = [];

        if (array_key_exists('image', $data)) {
            foreach ((array) $data['image'] as $image) {
                $images[] = new Image($image['#text']);
            }
        }

        return new self(
            $data['name'],
            $data['artist'] ? Artist::fromApi($data['artist']) : null,
            $data['mbid'] ?? null,
            $data['url'] ?? null,
            $images
        );
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* (c) Christian Gripp <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Core23\LastFm\Model;
13
14			final class Album
15			{
16			/**
17			* @var string\|null
18			*/
19			private $name;
20
21			/**
22			* @var Artist\|null
23			*/
24			private $artist;
25
26			/**
27			* @var string\|null
28			*/
29			private $mbid;
30
31			/**
32			* @var string\|null
33			*/
34			private $url;
35
36			/**
37			* @var Image[]
38			*/
39			private $images;
40
41			/**
42			* Album constructor.
43			*
44			* @param null\|string $name
45			* @param Artist\|null $artist
46			* @param null\|string $mbid
47			* @param null\|string $url
48			* @param Image[] $images
49			*/
50			public function __construct(?string $name, ?Artist $artist, ?string $mbid, ?string $url, array $images)
51			{
52			$this->name = $name;
53			$this->artist = $artist;
54			$this->mbid = $mbid;
55			$this->url = $url;
56			$this->images = $images;
57			}
58
59			/**
60			* @return null\|string
61			*/
62			public function getName(): ?string
63			{
64			return $this->name;
65			}
66
67			/**
68			* @return Artist\|null
69			*/
70			public function getArtist(): ?Artist
71			{
72			return $this->artist;
73			}
74
75			/**
76			* @return null\|string
77			*/
78			public function getMbid(): ?string
79			{
80			return $this->mbid;
81			}
82
83			/**
84			* @return null\|string
85			*/
86			public function getUrl(): ?string
87			{
88			return $this->url;
89			}
90
91			/**
92			* @return Image[]
93			*/
94			public function getImages(): array
95			{
96			return $this->images;
97			}
98
99			/**
100			* @param array $data
101			*
102			* @return Album
103			*/
104			public static function fromApi(array $data): self
105			{
106			$images = [];
107
108			if (array_key_exists('image', $data)) {
109			foreach ((array) $data['image'] as $image) {
110			$images[] = new Image($image['#text']);
111			}
112			}
113
114			return new self(
115			$data['name'],
116			$data['artist'] ? Artist::fromApi($data['artist']) : null,
117			$data['mbid'] ?? null,
118			$data['url'] ?? null,
119			$images
120			);
121			}
122			}
123

core23 / lastfm-php-api

GitHub Access Token became invalid

Push — master ( 547017...c67bb4 )

Album::fromApi() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like