EventInfoCrawler - Code Metrics - Inspection of "Use explicit models instead of anonymous arrays" - core23/lastfm-php-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 547017...c67bb4 )

by Christian

created 2018-03-31 15:24 UTC

EventInfoCrawler A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	92
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	6
c	2
b	0
f	0
lcom	1
cbo	6
dl	0
loc	92
rs	10

4 Methods

Rating	Name	Size	Complexity
B	getEventInfo()	24	2
A	readArtists()	15	2
A	readVenues()	19	1
A	crawlEvent()	6	1

<?php

declare(strict_types=1);

/*
 * (c) Christian Gripp <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Core23\LastFm\Crawler;

use Core23\LastFm\Model\Artist;
use Core23\LastFm\Model\EventInfo;
use Core23\LastFm\Model\Venue;
use Core23\LastFm\Model\VenueAddress;
use Symfony\Component\DomCrawler\Crawler;

final class EventInfoCrawler extends AbstractCrawler
{
    /**
     * Get all event information.
     *
     * @param int $id
     *
     * @return EventInfo|null
     */
    public function getEventInfo(int $id): ?EventInfo
    {
        $node = $this->crawlEvent($id);

        if (null === $node) {
            return null;
        }

        $timeNode = $node->filter('.qa-event-date');

        return new EventInfo(
            $id,
            $this->parseString($node->filter('h1.header-title')),
            $this->parseString($node->filter('.qa-event-description'), true),
            $this->parseDate($timeNode->filter('[itemprop="startDate"]')),
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
            $this->parseDate($timeNode->filter('[itemprop="endDate"]')),
            $this->parseString($node->filter('.qa-event-link a')),
            $this->parseImage($node->filter('.event-poster-preview')),
            $this->parseUrl($node->filter('link[rel="canonical"]')),
            $node->filter('.namespace--events_festival_overview')->count() > 0,
            $this->readVenues($node),
            $this->readArtists($node)
        );
    }

    /**
     * @param Crawler $node
     *
     * @return Artist[]
     */
    private function readArtists(Crawler $node): array
    {
        $artistNode = $node->filter('.grid-items');

        return $artistNode->filter('.grid-items-item')->each(function (Crawler $node): Artist {
            $image = $this->parseImage($node->filter('.grid-items-cover-image-image img'));

            return new Artist(
                $this->parseString($node->filter('.grid-items-item-main-text')),
                null,
                $image ? [$image] : [],
                $this->parseUrl($node->filter('.grid-items-item-main-text a'))
            );
        });
    }

    /**
     * @param Crawler $node
     *
     * @return Venue
     */
    private function readVenues(Crawler $node): Venue
    {
        $venueNode   = $node->filter('.event-detail');
        $addressNode = $venueNode->filter('.event-detail-address');

        $adress = new VenueAddress(
            $this->parseString($addressNode->filter('[itemprop="streetAddress"]')),
            $this->parseString($addressNode->filter('[itemprop="postalCode"]')),
            $this->parseString($addressNode->filter('[itemprop="addressLocality"]')),
            $this->parseString($addressNode->filter('[itemprop="addressCountry"]'))
        );

        return new Venue(
            $this->parseString($venueNode->filter('[itemprop="name"]')),
            $this->parseUrl($venueNode->filter('.event-detail .qa-event-link a')),
            $this->parseString($venueNode->filter('.event-detail-tel span')),
            $adress
        );
    }

    /**
     * @param int $id
     *
     * @return Crawler|null
     */
    private function crawlEvent(int $id): ?Crawler
    {
        $url = 'http://www.last.fm/de/event/'.$id;

        return $this->crawl($url);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* (c) Christian Gripp <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Core23\LastFm\Crawler;
13
14			use Core23\LastFm\Model\Artist;
15			use Core23\LastFm\Model\EventInfo;
16			use Core23\LastFm\Model\Venue;
17			use Core23\LastFm\Model\VenueAddress;
18			use Symfony\Component\DomCrawler\Crawler;
19
20			final class EventInfoCrawler extends AbstractCrawler
21			{
22			/**
23			* Get all event information.
24			*
25			* @param int $id
26			*
27			* @return EventInfo\|null
28			*/
29			public function getEventInfo(int $id): ?EventInfo
30			{
31			$node = $this->crawlEvent($id);
32
33			if (null === $node) {
34			return null;
35			}
36
37			$timeNode = $node->filter('.qa-event-date');
38
39			return new EventInfo(
40			$id,
41			$this->parseString($node->filter('h1.header-title')),
42			$this->parseString($node->filter('.qa-event-description'), true),
43			$this->parseDate($timeNode->filter('[itemprop="startDate"]')),
			0 ignored issues – show Bug introduced 2018-03-31 15:29 UTC by Report Bug Copy Issue Report It seems like `$this->parseDate($timeNo...temprop="startDate"]'))` can be `null`; however, `__construct()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
44			$this->parseDate($timeNode->filter('[itemprop="endDate"]')),
45			$this->parseString($node->filter('.qa-event-link a')),
46			$this->parseImage($node->filter('.event-poster-preview')),
47			$this->parseUrl($node->filter('link[rel="canonical"]')),
48			$node->filter('.namespace--events_festival_overview')->count() > 0,
49			$this->readVenues($node),
50			$this->readArtists($node)
51			);
52			}
53
54			/**
55			* @param Crawler $node
56			*
57			* @return Artist[]
58			*/
59			private function readArtists(Crawler $node): array
60			{
61			$artistNode = $node->filter('.grid-items');
62
63			return $artistNode->filter('.grid-items-item')->each(function (Crawler $node): Artist {
64			$image = $this->parseImage($node->filter('.grid-items-cover-image-image img'));
65
66			return new Artist(
67			$this->parseString($node->filter('.grid-items-item-main-text')),
68			null,
69			$image ? [$image] : [],
70			$this->parseUrl($node->filter('.grid-items-item-main-text a'))
71			);
72			});
73			}
74
75			/**
76			* @param Crawler $node
77			*
78			* @return Venue
79			*/
80			private function readVenues(Crawler $node): Venue
81			{
82			$venueNode = $node->filter('.event-detail');
83			$addressNode = $venueNode->filter('.event-detail-address');
84
85			$adress = new VenueAddress(
86			$this->parseString($addressNode->filter('[itemprop="streetAddress"]')),
87			$this->parseString($addressNode->filter('[itemprop="postalCode"]')),
88			$this->parseString($addressNode->filter('[itemprop="addressLocality"]')),
89			$this->parseString($addressNode->filter('[itemprop="addressCountry"]'))
90			);
91
92			return new Venue(
93			$this->parseString($venueNode->filter('[itemprop="name"]')),
94			$this->parseUrl($venueNode->filter('.event-detail .qa-event-link a')),
95			$this->parseString($venueNode->filter('.event-detail-tel span')),
96			$adress
97			);
98			}
99
100			/**
101			* @param int $id
102			*
103			* @return Crawler\|null
104			*/
105			private function crawlEvent(int $id): ?Crawler
106			{
107			$url = 'http://www.last.fm/de/event/'.$id;
108
109			return $this->crawl($url);
110			}
111			}
112

core23 / lastfm-php-api

GitHub Access Token became invalid

Push — master ( 547017...c67bb4 )

EventInfoCrawler A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like